From patchwork Tue Nov 30 16:10:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12647765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A30DC433F5 for ; Tue, 30 Nov 2021 16:11:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.235292.408270 (Exim 4.92) (envelope-from ) id 1ms5if-0006nu-La; Tue, 30 Nov 2021 16:11:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 235292.408270; Tue, 30 Nov 2021 16:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ms5if-0006nn-Hv; Tue, 30 Nov 2021 16:11:01 +0000 Received: by outflank-mailman (input) for mailman id 235292; Tue, 30 Nov 2021 16:11:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ms5ie-0006nh-Dp for xen-devel@lists.xenproject.org; Tue, 30 Nov 2021 16:11:00 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b11b562-51f8-11ec-976b-d102b41d0961; Tue, 30 Nov 2021 17:10:59 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-4cwugFaiPOSFvVtxASZV-g-1; Tue, 30 Nov 2021 17:10:57 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6671.eurprd04.prod.outlook.com (2603:10a6:803:11f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Tue, 30 Nov 2021 16:10:56 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Tue, 30 Nov 2021 16:10:56 +0000 Received: from [10.156.60.236] (37.24.206.209) by AS9PR06CA0244.eurprd06.prod.outlook.com (2603:10a6:20b:45f::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Tue, 30 Nov 2021 16:10:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b11b562-51f8-11ec-976b-d102b41d0961 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638288658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wX2v+CXmZtuqLTLe/ypVZSOZdElCTK6pbhJs32Pc9K8=; b=WyngbVEIRSj1KQ4psMMMHtgKOOpK6eYVS2IktLENBzKHv2tUokIj8YjXCT/DEhN9YCNG8Z eJbD1tRHpHRD2eFTk4GhQTT4Q9q2bxhF/lKaInDsjOn4t9JhIAq7paqgUw/PmR8pYnmPt+ t/HL+kd78DLdpBCaNeM+I0q86ff7juA= X-MC-Unique: 4cwugFaiPOSFvVtxASZV-g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RssAVVZ4Zq6/fv68nZe4LU0qehjGdk1CR33nnpNWYPpsJSfKUC9feZGuMLigqqn5BGV7F3aXjVe4xT+IIlpdWiJtIwyquW8PyPDa4XuiKYrDpNoisjjCuTLQFWlDaMpMWKOlZDQ1AAROXysaYuaB7/dITNuB2gT9EwkKLGeSN9KuUV6UYeZU6efAAp1dxaO2IOxkSbaCVK/aownNDjegf/LS2/cFZCDFWA2SxRmuVPV5W5nByGAl8rGgrT28W28yEjQ/0/q8qg2HLJLQARCx437FK9FLjzcR3QYlY6yZGutHOY4wu8KA50rPmc96vdiksnzchZ4FFWWMbcoz8SviQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wX2v+CXmZtuqLTLe/ypVZSOZdElCTK6pbhJs32Pc9K8=; b=kzeqwOot+TT18VljJv5Mz86LJX0zCfrkPgx7xXr7XsuqTBLKyO09fRm6G8EXTbBivmShlQNeF4t46qVCOg75/m3zyT1Bs56PzKlknmPcb/hff426YHLG/nUv4KejabyhYhMzqHBPGnfGmtGFVIQBbJZHB3rxk+Vb+UuWkxAT0GVTvujUCebZ7LFTsHdU2dj605EgNiA9jThd3aC2onKHGyuoWEK0UjXFeYDilhI/XcoI7X25lXsgmOFM2VQmePCoh2/ROMpSmIM3++fc24U8t0mcSHma0e+0RtzKYiuQP2pLlvAxJitqdi9dE3P6dcQ9KEM835qw+QUEwSZN6UXhIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 30 Nov 2021 17:10:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Jun Nakajima , Kevin Tian From: Jan Beulich Subject: [PATCH] x86/EPT: squash meaningless TLB flush X-ClientProxiedBy: AS9PR06CA0244.eurprd06.prod.outlook.com (2603:10a6:20b:45f::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5401fb7d-8295-4fc3-d9be-08d9b41bfd59 X-MS-TrafficTypeDiagnostic: VE1PR04MB6671: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Au62YujUgPkqdbAfN76T75b4l1UL6v0sZhCR+ZkcdxmkE6CR5z52y96zOdInvKb2mO4T2U5jCFUrtT4uyQi0JisGXKddTYAg5UQRunwqi/sNOlbG0AN2Jn13bGtfSa3TycbOxQJioktrr2eFkIsPGhOVht9SU2Kno4OA+fDT6OwviraxR/ItlhUQNp0HkaftZgHHMb4Lr6IJ5aMHpCCh4gGSoEPRGEBozMHkhzMY81baJB6oX5Cmtk0y5aXkbgGZHWYgtW7gKOQd9mpdZqwRDDt6DfF36Q63uw3mAtNRrWe0V1EXUy2OKAg0xXh8XG/sjRnnR6e5X5prGTvu3KHaEQVvO00LxHrcqEXUbVuP3QNgR79+FI/uu7xkSKDy7KSh6WBUWhQld02/PnA6Wy/GNXu0Jo4xfxW1iOBKjy2WjRrmMmfN12eloHyuOi87LcDHbsn0sVFbSYHybANcKjdVLnqF+tyUmP+Bvj7iMdjjiyhY7PWfL9Yx+u+Ucn7oGAaI9dwfyoevM77FuuewQNkh3wdZNot1fM1QBFFd1Sy9Y3L0qB7fRGPEh0ZMan4+Bkmf8xzCqQajrmTtdrr7Kmg5Bks4fkXjaWoiC7DD8s7ZjuGxhxqui2QH/l1jHRGeMpbD7U2lRyFobm3Urjn0rtrSxw59hcwgajMcYllRxopPyLOYLW2qUfrYo2DdvN6reL7y99ENzbAwEmroXaCRVxeIr3Lk8SmVIfslL6kgbKlC3UY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(36756003)(956004)(2906002)(8676002)(66476007)(508600001)(86362001)(4744005)(66556008)(4326008)(31696002)(66946007)(5660300002)(2616005)(16576012)(31686004)(38100700002)(6486002)(26005)(6916009)(54906003)(316002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?HI9m4IIxsLgNZX4IRArKJaMQyjVu?= =?utf-8?q?JOjBqQU71GJwMM2Q6UC81moUY75xY7w6Pa/5dSLumfqbZKreFWqPdii1FSdkJ6C4z?= =?utf-8?q?5SpsSsjTBhkS2a0axgJXxEVc2Ek019GQZw5jH0pzgtVJS0WZ8UgdisbxltfqfWtV+?= =?utf-8?q?ulRy0JT2q/E9DVwGBXijmeX0M21sf6wBoFjQCsXrRfrz9IDBzKqg/ib24mWDhpdr1?= =?utf-8?q?ceyyW8A5rZyS2ThvpqI4ESQS8AttNLdQfVc3DgLJmvhx5KSaPuXNhfh2RodahqsBz?= =?utf-8?q?OH//knesq/416/4r5jTMdkGIQXjaI5GhYihGsaw/Z0sTX8IiL2c5yhAbjHLJK0UYP?= =?utf-8?q?VcsXuS1ilDLpAzoTicRdQa4+K9g5Er1nZAai/RDrfVR9ukMnZT9s8fxd75LGbPoqh?= =?utf-8?q?jZr4SanpHizBQNadA5db9gdfOO0RrAeacGPL/fLqZvvVhLFajRTRIorZbOHJdyzXE?= =?utf-8?q?oFTMXxQz7ZbQV659mCnbZzpGjcnyCpD8cOxLaGQTXV3L5P3/8tHjh0FQ8aIpni5hM?= =?utf-8?q?hT9c7gHSEadOQZDB22kE3bmbGACZQmkHQ081QQHB1jOAsJQ7vpy1wP/ZRS9cYg53F?= =?utf-8?q?MQTsno9OIJ77m7yHf9sMeTri0U/OvXrC4beQk/iy6qKXnrxJThJUd2GVabgrDYP2c?= =?utf-8?q?l38G/G4b1QcSbDlVwGUfaNWSYeSy+AUDWheiHEicBP5hFqKGfK9FepzmTicxFi4dx?= =?utf-8?q?TwoMzDQBSa3lEm6QguCIYdIZWphR7IzEyg1PjooGN+OtiYQPX4zDRpvCFA9BTpoXq?= =?utf-8?q?VrLx5GjE3rbv1ENev7fmN6Ld81mrLIoloegQi2N28jhYlgAor9wDN3T1+UDO5L20z?= =?utf-8?q?W/QtE4J8LU0RRjWjrFWlpuwqMxoz2bpmlsQnRK8ymqyzxhPg3NI3YXl2AfyU07kxU?= =?utf-8?q?KUpVAvSUrFOtCoI//YSLxqWvj1jsWvMCGxWeBWL/Zi2JaGSbBh3x3aEmdIcrdg/hj?= =?utf-8?q?prAArHp915G2Fa++bWn1l61MEs7+ezhZCoNVeYLKoQJBNz5s9NQcSbAHgCCj7GEKQ?= =?utf-8?q?/i3UKoydD6cgQCDVBBJTZJvvtmGIKkIHQwYL8HHi2YNskIUxrUabAD0pjOEdUpaM0?= =?utf-8?q?9dZrvQoOxupPsWXiBIDSgTIdQNjoSejV1teuJ3wbiXw275DgV4P4cJ8d7FLns1H70?= =?utf-8?q?SXijaTSXo/c/HxP6SIuOE+820KkhwBrd28QWMJbtvp5nLItemOXpZ6if6cZatIMnT?= =?utf-8?q?UVVwT9Ncr4dLAZrkyfixn4oh0FKA0VsjOrmEzlUiO9VeCbWhGK44cyXvD1LW2NUgE?= =?utf-8?q?rh+R8XmOxwODGkN8PSJ6bBx1Z5GdeAdYWmF66x/wkkayQ4hLOtMsYiRW3+L6kJzYI?= =?utf-8?q?mMs33nI1RExdXfCLFMJc/T/F+kWjl+NIZLS4AavRDzf5WCtwbVDdwDECu+xIYSq5n?= =?utf-8?q?3oBXa5wqaNYk8sbnDxNayupPgBMTa8LhsrkqtuQKW25RV+2bESfSWqf/Q9I2rqvOf?= =?utf-8?q?s1Vf8havJPdYv8+8G17BCsbSLX9rZMPhbr/66uK3ln35qeN5rmHF1ptD5FWnjZdoC?= =?utf-8?q?AxzYUv+edn703wwLT6K76fo18bdGlfIgb7zd3juBiAMOwxP7z+jhc58=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5401fb7d-8295-4fc3-d9be-08d9b41bfd59 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 16:10:55.9355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9z/613/ztaqoawVokm8A8DGqoDLG02HNokjAo/mtE4inOQ+IijQHqN/gbZfnFsRkCKVLUplQiqPVHJEknxyuZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6671 ept_free_entry() gets called after a flush - if one is necessary in the first place - was already issued. That behavior is similar to NPT, which also doesn't have any further flush in p2m_free_entry(). (Furthermore, the function being recursive, in case of recursiveness way too many flushes would have been issued.) Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Kevin Tian --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -246,8 +246,7 @@ static void ept_free_entry(struct p2m_do ept_free_entry(p2m, epte + i, level - 1); unmap_domain_page(epte); } - - p2m_tlb_flush_sync(p2m); + p2m_free_ptp(p2m, mfn_to_page(_mfn(ept_entry->mfn))); }