From patchwork Wed Dec 14 09:14:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Razvan Cojocaru X-Patchwork-Id: 9473895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 97633607EE for ; Wed, 14 Dec 2016 09:16:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F320286F9 for ; Wed, 14 Dec 2016 09:16:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 734F928704; Wed, 14 Dec 2016 09:16:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 65197286F9 for ; Wed, 14 Dec 2016 09:16:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH5dM-0002XK-49; Wed, 14 Dec 2016 09:13:56 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH5dK-0002XE-B3 for xen-devel@lists.xen.org; Wed, 14 Dec 2016 09:13:54 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id 77/40-08140-15D01585; Wed, 14 Dec 2016 09:13:53 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRWlGSWpSXmKPExsUSfTxjoW4Ab2C Ewb6HNhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8a5TVPYCxYJV7yYcJOxgXGlQBcjJ4eQgLvE znnfWboYuYDstYwSr06+ZYJIXGWUuDRZB8L2kDh8bgkTRNEiRomGCS9ZQBLCAkES585/AGsQE VCW6P31mwWioVZixqy/YFOZBZ4yShzomM4GkmATMJRYvbEFzOYVcJLY/2MTaxcjBweLgKrE7q VgpqhAuMTVw+YQFYISJ2c+ARvJKWAv0dW4lR3EZhbQk9hx/RcrhC0vsf3tHGYQW0IgR+Lv37X MIGMkBKQk/rcqgVwgIbCIReLCjVOsEDUyEo8m3mSbwCg6C8mKWUjGzkIydgEj8ypGjeLUorLU Il1DE72kosz0jJLcxMwcXUMDY73c1OLixPTUnMSkYr3k/NxNjMC4YACCHYwrtnseYpTkYFIS5 eW6GhAhxJeUn1KZkVicEV9UmpNafIhRhoNDSYL3F3dghJBgUWp6akVaZg4wQmHSEhw8SiK8C0 DSvMUFibnFmekQqVOMilLivCdAEgIgiYzSPLg2WFK4xCgrJczLCHSIEE9BalFuZgmq/CtGcQ5 GJWHeHSBTeDLzSuCmvwJazAS0WHSJP8jikkSElFQDo3m0j++TimUJd3WPmzbKtwkkNa5wKTxz dGvz50xrleRJh3do/5+U6cPiznmii2n3t9D9Os51iu1GSe9+vEp+dObOs0DT3eZlsx6rxcUXe rruZLRe5S02lfn9rzI+n2Y735UTTCNSe3Rm6ArdzHyTuZHPI72W64YJe6LEtfy3JeEH6g9P7e 1XYinOSDTUYi4qTgQAaCFC8wUDAAA= X-Env-Sender: rcojocaru@bitdefender.com X-Msg-Ref: server-13.tower-31.messagelabs.com!1481706832!75380744!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 58704 invoked from network); 14 Dec 2016 09:13:52 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-13.tower-31.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 14 Dec 2016 09:13:52 -0000 Received: (qmail 5002 invoked from network); 14 Dec 2016 11:13:51 +0200 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 14 Dec 2016 11:13:51 +0200 Received: from smtp01.buh.bitdefender.com (smtp.bitdefender.biz [10.17.80.75]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 5D5857FBE9 for ; Wed, 14 Dec 2016 11:13:51 +0200 (EET) Received: (qmail 22298 invoked from network); 14 Dec 2016 11:13:51 +0200 Received: from rcojocaru.dsd.ro (HELO ?10.10.14.59?) (rcojocaru@bitdefender.com@10.10.14.59) by smtp01.buh.bitdefender.com with SMTP; 14 Dec 2016 11:13:51 +0200 To: Jan Beulich References: <1481640609-19224-1-git-send-email-rcojocaru@bitdefender.com> <585119480200007800128FE3@prv-mh.provo.novell.com> From: Razvan Cojocaru Message-ID: Date: Wed, 14 Dec 2016 11:14:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <585119480200007800128FE3@prv-mh.provo.novell.com> X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp01.buh.bitdefender.com, sigver: 7.68491 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.8.1074, Dats: 437357, Stamp: 3], Multi: [Enabled, t: (0.000011, 0.014587)], BW: [Enabled, t: (0.000010)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.005106), Flags: 85D2ED72; NN_CHECK_OUT; NN_FORGED_THUNDERBIRD_2; NN_LEGIT_VALID_REPLY; NN_LEGIT_SUMM_400_WORDS; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS], SGN: [Enabled, t: (0.010524,0.000161)], URL: [Enabled, t: (0.000025)], RTDA: [Enabled, t: (0.023424), Hit: No, Details: v2.4.2; Id: 5eu3g9.1b3tckshf.5qi4], total: 0(775) X-BitDefender-CF-Stamp: none Cc: kevin.tian@intel.com, sstabellini@kernel.org, suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org, julien.grall@arm.com, tamas@tklengyel.com, jun.nakajima@intel.com, boris.ostrovsky@oracle.com Subject: Re: [Xen-devel] [PATCH V6] x86/vm_event: Added support for VM_EVENT_REASON_INTERRUPT X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 12/14/2016 11:04 AM, Jan Beulich wrote: >>>> On 13.12.16 at 15:50, wrote: >> Added support for a new event type, VM_EVENT_REASON_INTERRUPT, >> which is now fired in a one-shot manner when enabled via the new >> VM_EVENT_FLAG_GET_NEXT_INTERRUPT vm_event response flag. >> The patch also fixes the behaviour of the xc_hvm_inject_trap() >> hypercall, which would lead to non-architectural interrupts >> overwriting pending (specifically reinjected) architectural ones. >> >> Signed-off-by: Razvan Cojocaru >> Acked-by: Tamas K Lengyel >> Acked-by: Jan Beulich >> Acked-by: Kevin Tian >> Acked-by: Suravee Suthikulpanit >> Acked-by: Julien Grall >> >> --- >> Changes since V5: >> - Rebased on master and re-tested. > > I have to admit that I find this rather annoying: The patch still > didn't apply cleanly (perhaps because you indeed did what is > written above, instead of re-basing onto staging, albeit otoh I > don't see how you would then have run into the build issue you > reported), which again I took the time to fix up, just to find that > again things don't build (for ARM at least). I first tried it on staging, and I found the build failure I've reported. I could have just run 'make' in the xen/ subdirectory, but decided instead to make sure that everything still runs properly by rebasing on master instead, which did build, and actually do a few introspection test runs with Xen 4.9. So I was simply being thorough, and working with the master branch is the recommended in the official Xen patching guide: https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches Sorry about the ARM build, I will check it out. I've assumed that since this is the only ARM change in the patch, it couldn't possibly cause any issues: #endif /* __ASM_ARM_VM_EVENT_H__ */ I'll rebase the patch on staging, check out the ARM build, and send V7. Thanks, Razvan diff --git a/xen/include/asm-arm/vm_event.h b/xen/include/asm-arm/vm_event.h index 66f2474..ab9c8cb 100644 --- a/xen/include/asm-arm/vm_event.h +++ b/xen/include/asm-arm/vm_event.h @@ -52,4 +52,10 @@ void vm_event_emulate_check(struct vcpu *v, vm_event_response_t *rsp) /* Not supported on ARM. */ } +static inline +void vm_event_monitor_next_interrupt(struct vcpu *v) +{ + /* Not supported on ARM. */ +} +