From patchwork Thu Aug 17 12:39:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13356381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34D72C2FC14 for ; Thu, 17 Aug 2023 12:40:16 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.585376.916475 (Exim 4.92) (envelope-from ) id 1qWcIA-0000Z2-34; Thu, 17 Aug 2023 12:39:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 585376.916475; Thu, 17 Aug 2023 12:39:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qWcI9-0000Xg-Sj; Thu, 17 Aug 2023 12:39:57 +0000 Received: by outflank-mailman (input) for mailman id 585376; Thu, 17 Aug 2023 12:39:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qWcI8-0000KH-OJ for xen-devel@lists.xenproject.org; Thu, 17 Aug 2023 12:39:56 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2af64e13-3cfb-11ee-9b0c-b553b5be7939; Thu, 17 Aug 2023 14:39:55 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 384034EE073D; Thu, 17 Aug 2023 14:39:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2af64e13-3cfb-11ee-9b0c-b553b5be7939 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Julien Grall , Jan Beulich , Andrew Cooper , George Dunlap , Wei Liu Subject: [XEN PATCH v2 2/3] vpci/msix: make 'get_slot' static Date: Thu, 17 Aug 2023 14:39:27 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The function can become static since it's used only within this file. This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence of a declaration before the function definition. Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X table") Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini Reviewed-by: Roger Pau Monné --- Changes in v2: - Corrected wrong prefix in the commit subject. CC-ing maintainers from "THE REST" as well, perhaps this trivial change can go in straight away. --- xen/drivers/vpci/msix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 25bde77586a4..f9df506f29bf 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -223,7 +223,7 @@ static void __iomem *get_table(const struct vpci *vpci, unsigned int slot) return msix->table[slot]; } -unsigned int get_slot(const struct vpci *vpci, unsigned long addr) +static unsigned int get_slot(const struct vpci *vpci, unsigned long addr) { unsigned long pfn = PFN_DOWN(addr);