Message ID | c71ac406-15a9-6291-d670-0f965a59bebf@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [4.16] VT-d: drop undue address-of from check_cleanup_domid_map() | expand |
On Tue, Mar 08, 2022 at 04:27:00PM +0100, Jan Beulich wrote: > For an unknown reason I added back the operator while backporting, > despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs > to have dynamic size"). I can only assume that I mistakenly took the > 4.15 backport as basis and/or reference. > > Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function") > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
> From: Jan Beulich <jbeulich@suse.com> > Sent: Tuesday, March 8, 2022 11:27 PM > > For an unknown reason I added back the operator while backporting, > despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs > to have dynamic size"). I can only assume that I mistakenly took the > 4.15 backport as basis and/or reference. > > Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function") > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> > > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -197,7 +197,7 @@ static void check_cleanup_domid_map(stru > > if ( !found ) > { > - clear_bit(iommu->index, &dom_iommu(d)->arch.vtd.iommu_bitmap); > + clear_bit(iommu->index, dom_iommu(d)->arch.vtd.iommu_bitmap); > cleanup_domid_map(d, iommu); > } > }
--- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -197,7 +197,7 @@ static void check_cleanup_domid_map(stru if ( !found ) { - clear_bit(iommu->index, &dom_iommu(d)->arch.vtd.iommu_bitmap); + clear_bit(iommu->index, dom_iommu(d)->arch.vtd.iommu_bitmap); cleanup_domid_map(d, iommu); } }
For an unknown reason I added back the operator while backporting, despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs to have dynamic size"). I can only assume that I mistakenly took the 4.15 backport as basis and/or reference. Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function") Signed-off-by: Jan Beulich <jbeulich@suse.com>