From patchwork Tue Mar 8 15:27:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12773962 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79FC6C433F5 for ; Tue, 8 Mar 2022 15:27:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.287093.486906 (Exim 4.92) (envelope-from ) id 1nRbjv-0001BQ-GP; Tue, 08 Mar 2022 15:27:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 287093.486906; Tue, 08 Mar 2022 15:27:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nRbjv-0001BJ-D6; Tue, 08 Mar 2022 15:27:07 +0000 Received: by outflank-mailman (input) for mailman id 287093; Tue, 08 Mar 2022 15:27:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nRbju-0001B7-PF for xen-devel@lists.xenproject.org; Tue, 08 Mar 2022 15:27:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35d3bb5c-9ef4-11ec-8eba-a37418f5ba1a; Tue, 08 Mar 2022 16:27:05 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13-39R90pkVMt-CHVmX-VWmMw-1; Tue, 08 Mar 2022 16:27:04 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB4792.eurprd04.prod.outlook.com (2603:10a6:20b:2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.19; Tue, 8 Mar 2022 15:27:02 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022 15:27:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35d3bb5c-9ef4-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646753225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bi41F84unF7k8jt/I9MJYkNADDQudK8erSyx/4BpEpI=; b=L4kyAodO7512kEBY64qZXeO6cwAWYm+iQqwsGOBKrZuAQ0F5b8WJwuStou1JM8sK6EG4ZQ r6Vtgww/MiOcG7nBpPHcve3O7z7ALy5z44I43n+4QABuM0yrrXKVA33R3SVrDV2iRjrFfv 1h2682qK7D5yI1C1Mx69z8O4hvCrSoU= X-MC-Unique: 39R90pkVMt-CHVmX-VWmMw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsgK1CJulYFy30pduwbL/qFCWgLYSse7cegho/cj6rDfVf/qKFS6LJWrd4rJRNyAbrIC08VVu/iYeVJgRUpXgAIxku/L7Vhb50LHQCKWwCnhTp0GWutvLti1DTEVWI646GVmhdfxIAdAa/p1GuhCKFRDCVHQQ2y5cAQSUvQpFqhv+Eqc4S3k7ijxe3mGHeg586Zstf+sUbcwUXLFj9S3EMq+7uITtaJJExB2ZPKwPtKl8wKA0a0P/g3cUIg9moovQZeWNpyC39H2eNBVzYEuuM2QdDmhvyKXRuFu6fOzm5kpC0sGJoB9WXhpUP6QmzL6WYhlfwnpUJUcahJrbpnSVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bi41F84unF7k8jt/I9MJYkNADDQudK8erSyx/4BpEpI=; b=eyaeXPppK0oph3OgreKbwOOQp2DV5hIum29LY06FYoUGzNxDrAC23U9tOTh0PxzI+WNRyZg9I9r4uWf2IED/u9vjoMvP8TDpqTFv9azaKJGJ7Si1AqMLiwCTugXGfWnPZZUYOyC/ZEYtVWSSpd3uDQpAgx7X+rpyXGf5hkowKQ9QusmTiYafV2J25qtI5WUu/rJfsQA2tO3Oee7JtFSgWcAb2UQDG9BpbIF0eEpLqg924J4ULg1S0J+QdnhZW75NSM48bAC3A1mpv8HYygyLoYSHifCjQLlaqKxL+p2dYN9a8QWjYO+gjVfFSD0hFrcECgjQ0WncB0BnFoOGWOdZAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Mar 2022 16:27:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Paul Durrant From: Jan Beulich Subject: [PATCH 4.16] VT-d: drop undue address-of from check_cleanup_domid_map() X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30fd100e-076c-4de5-a96f-08da011817d6 X-MS-TrafficTypeDiagnostic: AM6PR04MB4792:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Rnmbr2UR7wYE38pPGTdwFCIdA/yhkhNbBEY0ob18nUf8wjxaA/rNytA0F8hzyUpwKJUkkfy1DCBdgFJqPMeAyzw+mSrEDZH2cfLqLhvkqkFrC5B1n+FHowKR4lIeWHuhSBUI9HbAsp14J+E8VupM5mSuQAFFf4zh6nyIttH48syWlvcskQNHIArdpeUvDw+ZNTbxP8cYqQFAO85s/a+qgFzAejwtUZ23AVyNkatteUAtr9UgJb9Rj8yIC6avQJoQ+9efChZofESJO8xxg/eIwq33+7LxvR3e8TsDiRH5o/iIc1sL4aH8i5bypQC1q4U2p1YPdaVpk03ZTUc3ITyxn+xVX9JTZ7OkVoTYAlRw1k6AeKlKUycnefVjuh9z1wJQkB1O0+jLMMQB7k/ATVz6sC0KiwHNqHsyhu48rtAJBuC+9RLP4YMuR/by3+QcPybExz6QZ73QQ3ZM14eQIB65ClF0o0hg3Jk9B4dht2CIOz8XbstJ+j6fftmo2LeKyNDGc+IvAELCtEAalLzaUfSgdlKPQiMhyqJIEM3L7LHv2CQe6f7FTHnw4fA/M2f93DLRPdKw2ZKoi/v34c7frxZeV7Eiq/3XzMqqg67Gk/71Vc4hJAlO8l7Q5v8fnDANKyAZKtn5JurS7QvgJ/S1NzQonsKcl8FGRUdRhwVgyODRCS9k+jHF8yIsPrOxBdVxbSxv6ij54WJ+Wl7DEF6FN0NjfYfA1fcMkSJwMvNvBKcdng= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(6512007)(2906002)(4744005)(36756003)(2616005)(38100700002)(31696002)(86362001)(316002)(6506007)(8676002)(4326008)(6916009)(54906003)(66946007)(66556008)(66476007)(508600001)(31686004)(5660300002)(8936002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dLg0XznZfl5a0OXGBkWn4KwP25rm?= =?utf-8?q?3VwWTtUnBhJY2rF4iHcgX6Xolz6Zos+GuBZkygl+5xVFYGRV9RDE1bXoscxCMKZMc?= =?utf-8?q?1A7BL9TatPaPecQ+mHm+3QA/TgKwLi4oEIKFcev/uet1DFv4ecN4qgBGNQyG7OEAq?= =?utf-8?q?Dxg4Aj9BUdfJxaQ367T14Oa2KrBdJ7+itLygDTBvCnIORlNvdZnUk905TGo62gVzh?= =?utf-8?q?VBd2ZmC90x/Ei+T3yFVjdJ0pGxGCThHCEjo+Rp1SG7CIN07PQxsK4M3YOcq7XkCgq?= =?utf-8?q?nmnhEtEs9eFqtsCuzcM7xOXOWgD4dz/gvsCBMXIozh7Mw1pribP8kci13Ny0Syisn?= =?utf-8?q?tgWaw2mvx2Du/UUmUSAkjzuO6WR2dcKrpUsEW+pPif9Hfmwgk2nKFRc52rM2CAqk+?= =?utf-8?q?3mz+IxycyP/N8IMU415/LXAKSwWYv2Ux8Sxp3xKz/UPW8WoCx7/cqFEEo62sD29/k?= =?utf-8?q?RwqGO4jEePxtZxoriMVl6hyZKy8KgJnxyZIwtdDWax/IfpV8ANZQVY5+ETb4iq4xu?= =?utf-8?q?IN8sxj2VFmZ7WcWsu+GzzMOV/kkhN/N0c/KhTH2qQW1Rzm6LI+FsfJ4Z/Q3pX4tnJ?= =?utf-8?q?I1UIhVMXYMrDdq47r2D797d5bU1S6A7/MvqQAON4g227tcYz89UmQ1IIFFC5+OW2I?= =?utf-8?q?Qctah4PSzsiYKdHYnI+L/vZ+n0Z3iuqs9yvhBs8hRBQAP/eHCqa5hafPo/KkfikIx?= =?utf-8?q?IXud9TpuRANtOvJmTEyTFdC0r3LknH5zoKsvUPrAIXCUpaclw39B8vzQLQpGe15M7?= =?utf-8?q?JQPe16osiHlzEj7NH993ReFv6yTGVpNvsHwVamkSFcg1sfCQFslb6Oy3bvarvC+3b?= =?utf-8?q?THASnctQqGqlzNAzfbaPvrK/fU08Df4+2ZLN6bZ4K1U1JUSbiF+PhORUBdhOknL2e?= =?utf-8?q?uskdhIcZ0nq4YnFGXStrFSbGp2jCkqFrniNRDoHQvtMonh7eVNoAWwD+ImWDSXG5m?= =?utf-8?q?9golzCqCfGlwkHoMNkXSjp7qmOta5U/aD1jcnmlI0Lom5sq+XuHNeO2Wv59WUdM5H?= =?utf-8?q?MJRNMbEYBIRZXagziONE7daYNWLtAvbtRkGfD+MGZINZBtK0nKv1cUoqS6HVfCIsL?= =?utf-8?q?ef+blhvKmgrtFM1pUV7T1pLATddLPN3sFuVNK4zUhub7x5FtMOowSKh0oRR/JcI/L?= =?utf-8?q?+TsqKZW5+QF7lxWbVSgwzUIvV3IYenhcP29GULlzSIcXkil4LkSk50fvDirjUMaDl?= =?utf-8?q?6W4glvcr55Pg2ntj7D78lsmYd/KcFRs10QgSW3q5ZAZqHbiDCdRI/t0jbaUR/jsYg?= =?utf-8?q?qrhZ1lRkYW2pjp38CLGfqN5gLUMYxLd2Gydry30SJfWKTgoGs7cJZpZLyzsNUoiKW?= =?utf-8?q?18eFBRUYxpGE1S25eP/UEFMeuAaUzu0ZPChkU93ZmQYXMPueWl5UkqishBBz9yc01?= =?utf-8?q?DReQEFepBaHGy+dr+TDlYEmRNK9JBXjbQR59nzCnExfIi8BKsX0OVGYJaYtLs3RJa?= =?utf-8?q?dotlefyBp/+vVah2pV3FiKJNJP5JF+hY1jrFe87BykPzxa2bjxJSkQVtBL17uGcou?= =?utf-8?q?9claroZn503RjZtQV3ZHmQGUObleVkuUyctygHdwbnu2CXRvjN9utd4=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30fd100e-076c-4de5-a96f-08da011817d6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 15:27:01.8383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P8C8cm5NovRdtwJJZm6sdRWivnL4VEa5ZlOlqPTKbkHGy/8FffWb44ehu0CeEhNc2pKUi6jCXY8MALcHMm+2/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4792 For an unknown reason I added back the operator while backporting, despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs to have dynamic size"). I can only assume that I mistakenly took the 4.15 backport as basis and/or reference. Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Kevin Tian --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -197,7 +197,7 @@ static void check_cleanup_domid_map(stru if ( !found ) { - clear_bit(iommu->index, &dom_iommu(d)->arch.vtd.iommu_bitmap); + clear_bit(iommu->index, dom_iommu(d)->arch.vtd.iommu_bitmap); cleanup_domid_map(d, iommu); } }