From patchwork Fri Nov 24 14:03:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467704 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6C9CC61DF4 for ; Fri, 24 Nov 2023 14:05:46 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640732.999372 (Exim 4.92) (envelope-from ) id 1r6WnU-0005Qq-90; Fri, 24 Nov 2023 14:04:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640732.999372; Fri, 24 Nov 2023 14:04:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnU-0005PS-2w; Fri, 24 Nov 2023 14:04:44 +0000 Received: by outflank-mailman (input) for mailman id 640732; Fri, 24 Nov 2023 14:04:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnS-0005N0-Ea for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 693b14e9-8ad2-11ee-98e2-6d05b1d4d9a1; Fri, 24 Nov 2023 15:04:41 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id DE3034EE0C8B; Fri, 24 Nov 2023 15:04:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 693b14e9-8ad2-11ee-98e2-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 01/11] xen/console: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:16 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/drivers/char/console.c | 4 ++-- xen/include/xen/console.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 946af5e625..0666564ec9 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -393,9 +393,9 @@ long read_console_ring(struct xen_sysctl_readconsole *op) static char serial_rx_ring[SERIAL_RX_SIZE]; static unsigned int serial_rx_cons, serial_rx_prod; -static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; +static void (*serial_steal_fn)(const char *str, size_t nr) = early_puts; -int console_steal(int handle, void (*fn)(const char *, size_t nr)) +int console_steal(int handle, void (*fn)(const char *str, size_t nr)) { if ( (handle == -1) || (handle != sercon_handle) ) return 0; diff --git a/xen/include/xen/console.h b/xen/include/xen/console.h index ab5c30c0da..68759862e8 100644 --- a/xen/include/xen/console.h +++ b/xen/include/xen/console.h @@ -36,7 +36,7 @@ struct domain *console_input_domain(void); * Steal output from the console. Returns +ve identifier, else -ve error. * Takes the handle of the serial line to steal, and steal callback function. */ -int console_steal(int handle, void (*fn)(const char *, size_t nr)); +int console_steal(int handle, void (*fn)(const char *str, size_t nr)); /* Give back stolen console. Takes the identifier returned by console_steal. */ void console_giveback(int id);