From patchwork Tue Oct 1 08:48:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13817656 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECCE6CE7CE7 for ; Tue, 1 Oct 2024 08:48:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.807825.1219498 (Exim 4.92) (envelope-from ) id 1svYYS-0005Z4-Lk; Tue, 01 Oct 2024 08:48:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 807825.1219498; Tue, 01 Oct 2024 08:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1svYYS-0005Yx-HS; Tue, 01 Oct 2024 08:48:24 +0000 Received: by outflank-mailman (input) for mailman id 807825; Tue, 01 Oct 2024 08:48:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1svYYR-0005SS-AU for xen-devel@lists.xenproject.org; Tue, 01 Oct 2024 08:48:23 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9ac109a-7fd1-11ef-99a2-01e77a169b0f; Tue, 01 Oct 2024 10:48:21 +0200 (CEST) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2facf481587so17435401fa.1 for ; Tue, 01 Oct 2024 01:48:21 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c88245e9a9sm5725263a12.45.2024.10.01.01.48.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 01:48:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9ac109a-7fd1-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727772501; x=1728377301; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=JsdkVH+X0fQ3rqwF8jUU29eSJxEXcZhVYOG6vCFDcVQ=; b=H7zTi2EG24CyP4nES8R2CQYbNevenAxRFdWLwyJyqKNov0duQwdM0dNKzFwynyFet/ OXw1lIviDgLAE1oOZHMP8qU8l/GS8uTxDbD1MwA6ZhEmgrbzOAnZCTM0+oNUjTNLCda8 pxpgh9nuNTNs2KDhuZURQY+yS+cr/Vxk6gGrY49ADMUNGhREazv7IHDBBdVaLGsnGluz qSmqtYm9lTdd3KnxyuOrBa5TATDmH0aPNEsdSuYU78ZNd7/85k1Q4S4pRnlTR0fUk4El w4mJgZe/CdVvFeCGJ60FuhrJTC/nv6jD5DqG0wD3nna9nV+iu9iKS0okBykZPagQjpGN /qPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727772501; x=1728377301; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JsdkVH+X0fQ3rqwF8jUU29eSJxEXcZhVYOG6vCFDcVQ=; b=TtVybr2juXmkMroH0kL7ZkJf9t18Bxy7sUBrYdUTqp+XnKdsFGN32Q8sotNyqVEGjt FLWP473LjG08xWTMjmF3g53dydMGQBv1SwSObLbEp+x710lOsBLrXsuTj0XAJGx/dF30 zf+lBYkKeSJlR/kLFufw4jPWynfPVUx7hcw3lKskeDgKR2CbgAXN7d/TuwAmLr2E0DSa k7gp2hyZYmnT8ZtTrOxPlEJUd1/ZHRT3+9+znaighreGyIebnZt/hhUTca/eTyWNGJig ddpI9V2P07HEWCZe6VDuLscaLdkwczRxKlw0VB7YxYxX2r7CKk+Xd10hjD4nRJMrU6fE 7iHg== X-Gm-Message-State: AOJu0Yz1ExfKpRHBgyLcgF4RyyqMgSVbVZHgQ5Rr5ZiUrx0lRQlSEi/e Y3QRTk8Oa++bLM9mC6UhyI4NVLkCdW1HG26c+JTO6OLWoOjCDyY5lg2T7js/DfKng+WUFodtgys = X-Google-Smtp-Source: AGHT+IGanKpX2xFoj2bmLlkMMYkH3lGBJI+CvYWvEEARMiaH8VhUZE63n7rEvefc4wnlZsd4hjBUmA== X-Received: by 2002:a2e:4e11:0:b0:2f3:f7cf:2f01 with SMTP id 38308e7fff4ca-2f9d419888fmr60033161fa.41.1727772501003; Tue, 01 Oct 2024 01:48:21 -0700 (PDT) Message-ID: Date: Tue, 1 Oct 2024 10:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/5] x86/HVM: correct MMIO emulation cache bounds check From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?utf-8?q?Roger_Pau_Monn?= =?utf-8?q?=C3=A9?= References: <3294f629-f91f-4b5d-9eb0-40a34aa2ec3e@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <3294f629-f91f-4b5d-9eb0-40a34aa2ec3e@suse.com> To avoid overrunning the internal buffer we need to take the offset into the buffer into account. Fixes: d95da91fb497 ("x86/HVM: grow MMIO cache data size to 64 bytes") Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -935,7 +935,7 @@ static int hvmemul_phys_mmio_access( } /* Accesses must not overflow the cache's buffer. */ - if ( size > sizeof(cache->buffer) ) + if ( offset + size > sizeof(cache->buffer) ) { ASSERT_UNREACHABLE(); return X86EMUL_UNHANDLEABLE;