From patchwork Thu Aug 18 14:05:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12947174 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E15A0C00140 for ; Thu, 18 Aug 2022 14:05:53 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.389569.626578 (Exim 4.92) (envelope-from ) id 1oOg9X-000199-4y; Thu, 18 Aug 2022 14:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 389569.626578; Thu, 18 Aug 2022 14:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOg9X-000192-1D; Thu, 18 Aug 2022 14:05:43 +0000 Received: by outflank-mailman (input) for mailman id 389569; Thu, 18 Aug 2022 14:05:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOg9W-000100-EC for xen-devel@lists.xenproject.org; Thu, 18 Aug 2022 14:05:42 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00077.outbound.protection.outlook.com [40.107.0.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d80d2d95-1efe-11ed-bd2e-47488cf2e6aa; Thu, 18 Aug 2022 16:05:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5604.eurprd04.prod.outlook.com (2603:10a6:208:134::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Thu, 18 Aug 2022 14:05:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Thu, 18 Aug 2022 14:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d80d2d95-1efe-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ja7fNlj6APz6aoc3bsYXpBkJccaGpTRFgpUx7arLTOFFHrTSi2pnmy2/9Fvmzaak7qA1wai7gE5/69SxsfzCVrI0rxKm3PBAo+SRIIK97Mx6wJxM5tghgh4v9VSPtPSy2LXbDxA/EmAMeLDYxari4TDDC7a3/4HUvkbo1j0io2Y9ZJ+/NGIxvok3KoknGWtNJ74gGfaDZoYao5kKtYJOuDZU05x/k4tTurW/jZfzi5V4rYu9cnctO+j617kvpEunnIIvRXxO3CbGp59hwX4IW44Il7dOtyYqwyc20wxfkXXp7ScBMFzxMeXYpn28/apUF989YCXd4aqvnDmI8dNhsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ikzkcZ37zHqRA4Dqg0pshN1gxxIDaS6qACe6NnbT6Qk=; b=AIN7gmgZOpPgJUq94pOgGKuqkUmbKz0clooKrCLSNQuRhxZLKTTJv8IQENxuC6vSIDfrnzbCMIwBInLmSJi4gux1XeQe9I5kD8FObyW8f70OkJD9+P85Ye2/QHGRINKELk2jJpxySTZqBiz19U7Q/rOQnicLPWaYqLdR+wE/cUC+63Mik530t7sUga/kzKPQQE6BDfyUZE+ILMVPN+XYBBTSM2XuLQbiaqI482Vdl8fO6zeJM2bUiqeCbvlb+FuRxc4Dq9XHFnZD8seAL1U0Ua/8E7uOBtulBtiz9/JoMwsO98CDRHN6MLb1J6ur+9vU2DSJfk8TUUIrGltxGc422g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ikzkcZ37zHqRA4Dqg0pshN1gxxIDaS6qACe6NnbT6Qk=; b=0t3wKKetX/kuq9fcERq5F8KTAVPsHbn1SWFX1442HVQCaSGTbKa3cFFRcY9bgdh7PVSXpC8horB0Rg5KRsAcTMy2LrHDp9Bi9SmTyAunEp4CUn9k6EGgyZ5wCpWSTEAi9EmPWLcIPsBojgdYDgN/ywrAl/P9ZkGv4WzT0pMIJt+Mh+Cg0qlEIorwZL86K+4CL0cscP07/8BK4HsDvv9IJNClGVDBDfXNQTH0eYlp/NAHbMRqLLGEkoNkIr0QS/X1sRajfKgxIWwPnOWqwyMRTYybZNPAqbVhM+jOmf1dodJEJnbO/JlhVVRmjvWSuM3Vv4sYfScj+5m65R9j9URRXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 18 Aug 2022 16:05:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 1/3] xenbaked: properly use time_t in dump_stats() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> In-Reply-To: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> X-ClientProxiedBy: FR3P281CA0160.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8aedc4d8-1299-4787-a838-08da8122bb11 X-MS-TrafficTypeDiagnostic: AM0PR04MB5604:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mzAYTQScDSjo5k/IOVn3WJgRyAe0W8q7jw6b7ouD3ALBcegZRiwNOraNghH6lPUwNJLVvGESVQHnDD5E18ky9f+/+ECaiCdrkDNIozlS+jl7XWNKOH6kmqTJvfN3qTPPIdnkYbvwVOl/754O8px876KNLkT6vrth6HeqwVqfk5dCvmIVbTwVtESimTKz8SIHkqIszJY84tTjXc+99gyBC0Fz//wKqzx4E0QJ/xvdxkNXb9+kSoXBh9AlMni5BE7BvG5v2+SbOtcsYRJDFHh6p9ECWnHBsa9y9eobtkLYfHqdyhsrMIys9/7ByuXlpSccBnDz1acTJNA7JU3AqrwFW/dW/w7JYPQWLAc1dHBXAJ9fGPZrjDDL24oUcTy+5QmfY5PdGp7euFDSjtRpZWirfIPUYruMfoHxnLs8C1RXWDcwjbVF5tlyZ4FHD0D7bJOn7vSteCbTPA3nA9/fKO0HOiSqVimnL4r3sIoAJWR5uIpvvMoRwgZRPZfdRMj/I7+hQSFV0CMH2AxskBVvn1qVOKR60clPfendF1I0X9AyZ9fx/yZsMEYkeOXqYD2tiP/Q+LvoLJv3JyrlDVQCMnm/B1WrQihiwY6uCbLUYYD3wGpPJFbWtTpV32EuRdRKN8kHudb3C1uFk4101ogFo61nwBtiGf6jT4aAEY/hJGyJkfLoQa1fXM+gQnRkt+3Tut/xDV31T+VBgFWd2ScU9btzGW8+SWz4BlCjdQgM750BomifYjjn5qD1CsgsLOvKUYMD1oqTwQcdwFQRggpho6Jb+rbYCpsy2vgHItXoxZlFYK16mmlUbS6RG6zDfFTKFMjuFj5TGaxmZ5ffrEPYBCIUWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(39860400002)(396003)(376002)(6512007)(186003)(6506007)(2616005)(26005)(31686004)(84970400001)(2906002)(5660300002)(8936002)(36756003)(38100700002)(478600001)(66556008)(316002)(4326008)(8676002)(41300700001)(31696002)(86362001)(6916009)(54906003)(66946007)(6486002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?SqIy115/olrUBtho42R4h0M7AaZa?= =?utf-8?q?ab1XLQyW5w3qsNzyFowUJouSAosng6XcPlkmgWZJilx6TiAF+KECXo23x9xaHbxW/?= =?utf-8?q?O6rbzFe8yLkeXwx/908NAW70EEGnW9n0vdcwJ0QSHNZf03XlSmbzI/7/5jETrqb2X?= =?utf-8?q?rivMRfsK9yRh4RlYNYRpgbZGo3UGDheFlJdYA47nojnTqT1VYB5W7dMdteQ35xgvY?= =?utf-8?q?u4MBaM5NM0YPA2DA7hZSBIkRxBu7CkUb02/XFu0cpDv1ep5oWlEBISMDPQBvIg/5Y?= =?utf-8?q?dcXy42g6jCZkSf46rMXr+aB7a4RxPIP3ki/nHBi3roOdu74A6bt+UxveJUjsgIJG9?= =?utf-8?q?UbkHoQK2A+fWEauz4bcQb7YQGzZlp7YRwEgdpVl08t8unt6akpvYmKmmef5iKtill?= =?utf-8?q?hx3UyVmuxTxH9JYxZXDwyt/NXFCGNPWPEAH1/H/h4X7qSFvbof4AqdLYQBs4L18+L?= =?utf-8?q?VlXGvzQaC/cTOaln9c66pkQ+H8kIbUfAA7xsbtRQn/a9hYO8kdOMM0qlG68CU03WW?= =?utf-8?q?CuzIS60KqUrdAR3lXokXM0zOdMyRnc9ZNGn6aekwbzFA1TJ6wNVFiqNmvEv4qBKd4?= =?utf-8?q?BohvaW25w3TMkVSBHQqXHtZyLSx1rVcfD6OujKgJitsJCkja9oY0ercRPKHCqfAt6?= =?utf-8?q?VDQHc45P6RvRQdjBWHvKArEnjBkgdZ05HtQqj0IoogvXnJ7gYDiLE1CpwIvr2Zw+K?= =?utf-8?q?DDuXj8AoALnZgUDPH8pbVM5Pe0nEdjudoiNvcm/NrG8GOdGsQ2bCwmhNb2FnqFwK5?= =?utf-8?q?4xIzDYgyENWRmAHkR3vpbgAZjv9hNqWtHaifc6RvXFalok3YENq1igR4TJPqFAKKg?= =?utf-8?q?DA0iX0kerzvpHdgMkD3wYfJ5ViORwFJJave2OIpYDhyTQYFZxUKM1ylmfro1ySlOB?= =?utf-8?q?zfp5T8EMQ28xO7KEeJkemfJi9mEF6w72hhijHnEPYVfeQT81JMzm+c1kiVszeE4EY?= =?utf-8?q?C3TagzeBt2gcEHDadIiSE8Cswe0BjS0sg8y/ZSaix8vKNfzQjZY+0YKPJMQKDeOjw?= =?utf-8?q?8AGbbwvGQqoIOkhRekIq5nN0Yk0OKdlsLHPuLCJTZ56UAFxF0gxUuBP6p3lW5Fv6Q?= =?utf-8?q?CmHCm8j8kOIbaCQ7UngYgAJXo8Ypf9RZr+WPxta2AtAQGZBNGuhOaq1HSUidQoYNL?= =?utf-8?q?k2qD0aPCJyezdCf04klDAHljQ/u7TtKJR/GhwU+jITVcocTyMsc6MitKvtC0YN4sT?= =?utf-8?q?s1qEfx/YpVRCLPrG4vkGfdYOM+StZeGBowvJCgh5NPaLl7Dp0Q6yLy0jyJNjryJCF?= =?utf-8?q?swacyQOJhPPMtB92AKiZ9LpUoxDYE5WHBEMHXrMmGImU5f2CGPbg6qCvuJZ6+Mq+2?= =?utf-8?q?8U5Z71kwn/LT/nBqijFNeZrysjWpAvJwecw46lwACWNcIWm6D8dwfn1xOOFvdx/rN?= =?utf-8?q?qpRJZNVLLYbEWnDKA/dqCGM3W4Wz8FeLWc2kchTXlxB3EvvYc/W1636M4Y9D6xxql?= =?utf-8?q?nBt5uczmTRzg6FJLo0b3QwA5M7QcJPF2rAusfgjdxT+oJH9diJzNvGztwLKcGgzwo?= =?utf-8?q?1j8E0ADR+K51?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aedc4d8-1299-4787-a838-08da8122bb11 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 14:05:39.4651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JDS0cu7CoVchXfr5Fa7Ecmk3DQAos0qguWUb14ZhUuxGqF2RBcyDt7PwFYuQFlcCg02TikIRY+7o8ELAXChjPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5604 "int" is not a suitable type to convert time()'s return value to. Avoid casts and other extra fiddling by using difftime(), on the assumption that the overhead of using "double" doesn't matter here. Coverity ID: 1509374 Signed-off-by: Jan Beulich --- unstable.orig/tools/xenmon/xenbaked.c 2022-01-06 16:12:39.000000000 +0100 +++ unstable/tools/xenmon/xenbaked.c 2022-08-18 15:36:39.918706853 +0200 @@ -230,11 +230,7 @@ static void check_gotten_sum(void) static void dump_stats(void) { stat_map_t *smt = stat_map; - time_t end_time, run_time; - - time(&end_time); - - run_time = end_time - start_time; + double run_time = difftime(time(NULL), start_time); printf("Event counts:\n"); while (smt->text != NULL) { @@ -242,13 +238,11 @@ static void dump_stats(void) smt++; } - printf("processed %d total records in %d seconds (%ld per second)\n", - rec_count, (int)run_time, - run_time ? (long)(rec_count/run_time) : 0L); + printf("processed %d total records in %0f seconds (%0f per second)\n", + rec_count, run_time, run_time ? rec_count / run_time : 0); - printf("woke up %d times in %d seconds (%ld per second)\n", - wakeups, (int) run_time, - run_time ? (long)(wakeups/run_time) : 0L); + printf("woke up %d times in %0f seconds (%0f per second)\n", + wakeups, run_time, run_time ? wakeups / run_time : 0); check_gotten_sum(); }