| Message ID | d255a6e6-01c6-c1b3-eecb-71898b3a5554@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access( | expand |
On 30/09/2022 08:27, Jan Beulich wrote: > > > While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute > from gic_iomem_deny_access()"), the issue really became apparent only > when iomem_deny_access() was switched to have a non-const first > parameter. > > Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Michal Orzel <michal.orzel@amd.com> and Tested-by: Michal Orzel <michal.orzel@amd.com> ~Michal
Hi Jan, > On 30 Sep 2022, at 08:27, Jan Beulich <jbeulich@suse.com> wrote: > > While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute > from gic_iomem_deny_access()"), the issue really became apparent only > when iomem_deny_access() was switched to have a non-const first > parameter. > > Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> Cheers Bertrand > > --- a/xen/arch/arm/gic-v3-its.c > +++ b/xen/arch/arm/gic-v3-its.c > @@ -892,7 +892,7 @@ struct pending_irq *gicv3_assign_guest_e > return pirq; > } > > -int gicv3_its_deny_access(const struct domain *d) > +int gicv3_its_deny_access(struct domain *d) > { > int rc = 0; > unsigned long mfn, nr; > --- a/xen/arch/arm/include/asm/gic_v3_its.h > +++ b/xen/arch/arm/include/asm/gic_v3_its.h > @@ -139,7 +139,7 @@ unsigned long gicv3_its_make_hwdom_madt( > #endif > > /* Deny iomem access for its */ > -int gicv3_its_deny_access(const struct domain *d); > +int gicv3_its_deny_access(struct domain *d); > > bool gicv3_its_host_has_its(void); > > @@ -206,7 +206,7 @@ static inline unsigned long gicv3_its_ma > } > #endif > > -static inline int gicv3_its_deny_access(const struct domain *d) > +static inline int gicv3_its_deny_access(struct domain *d) > { > return 0; > }
--- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -892,7 +892,7 @@ struct pending_irq *gicv3_assign_guest_e return pirq; } -int gicv3_its_deny_access(const struct domain *d) +int gicv3_its_deny_access(struct domain *d) { int rc = 0; unsigned long mfn, nr; --- a/xen/arch/arm/include/asm/gic_v3_its.h +++ b/xen/arch/arm/include/asm/gic_v3_its.h @@ -139,7 +139,7 @@ unsigned long gicv3_its_make_hwdom_madt( #endif /* Deny iomem access for its */ -int gicv3_its_deny_access(const struct domain *d); +int gicv3_its_deny_access(struct domain *d); bool gicv3_its_host_has_its(void); @@ -206,7 +206,7 @@ static inline unsigned long gicv3_its_ma } #endif -static inline int gicv3_its_deny_access(const struct domain *d) +static inline int gicv3_its_deny_access(struct domain *d) { return 0; }
While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute from gic_iomem_deny_access()"), the issue really became apparent only when iomem_deny_access() was switched to have a non-const first parameter. Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Jan Beulich <jbeulich@suse.com>