diff mbox series

[v9,1/7] automation: introduce fixed randconfig for RISC-V

Message ID d8e330c26394d9415a0d76b2d951bf57b0b6dd4b.1708086092.git.oleksii.kurochko@gmail.com (mailing list archive)
State New
Headers show
Series Introduce generic headers | expand

Commit Message

Oleksii Kurochko Feb. 16, 2024, 12:39 p.m. UTC
This patch introduces the anchor riscv-fixed-randconfig,
which includes all configurations that should be disabled for
randconfig builds.

Suggested-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
The patch were introduced after discussion in a topic:
 https://lore.kernel.org/xen-devel/cover.1701966261.git.oleksii.kurochko@gmail.com/
---
Changes in V9:
 - add '|' symbol after EXTRA_FIXED_RANDCONFIG to make variables in EXTRA_FIXED_RANDCONFIG
   be separated by new line.
 - instead of introduction of new file for riscv-fixed-randconfig, introduce an anchor
   inside build.yaml
---
Changes in V8:
 - Nothing changed. Only rebase
---
Changes in V7:
 - Nothing changed. Only rebase
---
Changes in V6:
 - The patch was introduced in this version of patch series.
---
 automation/gitlab-ci/build.yaml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Comments

Michal Orzel Feb. 16, 2024, 12:48 p.m. UTC | #1
Hi,

On 16/02/2024 13:39, Oleksii Kurochko wrote:
> 
> 
> This patch introduces the anchor riscv-fixed-randconfig,
> which includes all configurations that should be disabled for
> randconfig builds.
> 
> Suggested-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal
Oleksii Kurochko March 7, 2024, 5:13 p.m. UTC | #2
Hello Doug and Stefano,

While Michal has reviewed this patch, I understand that I still need
your Acked-by.

Could you please take a moment to review the patch?

Thanks in advance.

~ Oleksii

On Fri, 2024-02-16 at 13:39 +0100, Oleksii Kurochko wrote:
> This patch introduces the anchor riscv-fixed-randconfig,
> which includes all configurations that should be disabled for
> randconfig builds.
> 
> Suggested-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
> The patch were introduced after discussion in a topic:
>  
> https://lore.kernel.org/xen-devel/cover.1701966261.git.oleksii.kurochko@gmail.com
> /
> ---
> Changes in V9:
>  - add '|' symbol after EXTRA_FIXED_RANDCONFIG to make variables in
> EXTRA_FIXED_RANDCONFIG
>    be separated by new line.
>  - instead of introduction of new file for riscv-fixed-randconfig,
> introduce an anchor
>    inside build.yaml
> ---
> Changes in V8:
>  - Nothing changed. Only rebase
> ---
> Changes in V7:
>  - Nothing changed. Only rebase
> ---
> Changes in V6:
>  - The patch was introduced in this version of patch series.
> ---
>  automation/gitlab-ci/build.yaml | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-
> ci/build.yaml
> index 6d2cb18b88..aac29ee13a 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -512,6 +512,14 @@ alpine-3.18-gcc-debug-arm64-boot-cpupools:
>        CONFIG_BOOT_TIME_CPUPOOLS=y
>  
>  # RISC-V 64 cross-build
> +.riscv-fixed-randconfig:
> +  variables: &riscv-fixed-randconfig
> +    EXTRA_FIXED_RANDCONFIG: |
> +      CONFIG_COVERAGE=n
> +      CONFIG_EXPERT=y
> +      CONFIG_GRANT_TABLE=n
> +      CONFIG_MEM_ACCESS=n
> +
>  archlinux-current-gcc-riscv64:
>    extends: .gcc-riscv64-cross-build
>    variables:
> @@ -532,8 +540,7 @@ archlinux-current-gcc-riscv64-randconfig:
>      CONTAINER: archlinux:current-riscv64
>      KBUILD_DEFCONFIG: tiny64_defconfig
>      RANDCONFIG: y
> -    EXTRA_FIXED_RANDCONFIG:
> -      CONFIG_COVERAGE=n
> +    <<: *riscv-fixed-randconfig
>  
>  archlinux-current-gcc-riscv64-debug-randconfig:
>    extends: .gcc-riscv64-cross-build-debug
> @@ -541,8 +548,7 @@ archlinux-current-gcc-riscv64-debug-randconfig:
>      CONTAINER: archlinux:current-riscv64
>      KBUILD_DEFCONFIG: tiny64_defconfig
>      RANDCONFIG: y
> -    EXTRA_FIXED_RANDCONFIG:
> -      CONFIG_COVERAGE=n
> +    <<: *riscv-fixed-randconfig
>  
>  # Power cross-build
>  debian-bullseye-gcc-ppc64le:
Stefano Stabellini March 7, 2024, 8:31 p.m. UTC | #3
On Thu, 7 Mar 2024, Oleksii wrote:
> Hello Doug and Stefano,
> 
> While Michal has reviewed this patch, I understand that I still need
> your Acked-by.
> 
> Could you please take a moment to review the patch?
> 
> Thanks in advance.

Acked-by: Stefano Stabellini <sstabellini@kernel.org>



> ~ Oleksii
> 
> On Fri, 2024-02-16 at 13:39 +0100, Oleksii Kurochko wrote:
> > This patch introduces the anchor riscv-fixed-randconfig,
> > which includes all configurations that should be disabled for
> > randconfig builds.
> > 
> > Suggested-by: Stefano Stabellini <sstabellini@kernel.org>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> > The patch were introduced after discussion in a topic:
> >  
> > https://lore.kernel.org/xen-devel/cover.1701966261.git.oleksii.kurochko@gmail.com
> > /
> > ---
> > Changes in V9:
> >  - add '|' symbol after EXTRA_FIXED_RANDCONFIG to make variables in
> > EXTRA_FIXED_RANDCONFIG
> >    be separated by new line.
> >  - instead of introduction of new file for riscv-fixed-randconfig,
> > introduce an anchor
> >    inside build.yaml
> > ---
> > Changes in V8:
> >  - Nothing changed. Only rebase
> > ---
> > Changes in V7:
> >  - Nothing changed. Only rebase
> > ---
> > Changes in V6:
> >  - The patch was introduced in this version of patch series.
> > ---
> >  automation/gitlab-ci/build.yaml | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-
> > ci/build.yaml
> > index 6d2cb18b88..aac29ee13a 100644
> > --- a/automation/gitlab-ci/build.yaml
> > +++ b/automation/gitlab-ci/build.yaml
> > @@ -512,6 +512,14 @@ alpine-3.18-gcc-debug-arm64-boot-cpupools:
> >        CONFIG_BOOT_TIME_CPUPOOLS=y
> >  
> >  # RISC-V 64 cross-build
> > +.riscv-fixed-randconfig:
> > +  variables: &riscv-fixed-randconfig
> > +    EXTRA_FIXED_RANDCONFIG: |
> > +      CONFIG_COVERAGE=n
> > +      CONFIG_EXPERT=y
> > +      CONFIG_GRANT_TABLE=n
> > +      CONFIG_MEM_ACCESS=n
> > +
> >  archlinux-current-gcc-riscv64:
> >    extends: .gcc-riscv64-cross-build
> >    variables:
> > @@ -532,8 +540,7 @@ archlinux-current-gcc-riscv64-randconfig:
> >      CONTAINER: archlinux:current-riscv64
> >      KBUILD_DEFCONFIG: tiny64_defconfig
> >      RANDCONFIG: y
> > -    EXTRA_FIXED_RANDCONFIG:
> > -      CONFIG_COVERAGE=n
> > +    <<: *riscv-fixed-randconfig
> >  
> >  archlinux-current-gcc-riscv64-debug-randconfig:
> >    extends: .gcc-riscv64-cross-build-debug
> > @@ -541,8 +548,7 @@ archlinux-current-gcc-riscv64-debug-randconfig:
> >      CONTAINER: archlinux:current-riscv64
> >      KBUILD_DEFCONFIG: tiny64_defconfig
> >      RANDCONFIG: y
> > -    EXTRA_FIXED_RANDCONFIG:
> > -      CONFIG_COVERAGE=n
> > +    <<: *riscv-fixed-randconfig
> >  
> >  # Power cross-build
> >  debian-bullseye-gcc-ppc64le:
>
diff mbox series

Patch

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index 6d2cb18b88..aac29ee13a 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -512,6 +512,14 @@  alpine-3.18-gcc-debug-arm64-boot-cpupools:
       CONFIG_BOOT_TIME_CPUPOOLS=y
 
 # RISC-V 64 cross-build
+.riscv-fixed-randconfig:
+  variables: &riscv-fixed-randconfig
+    EXTRA_FIXED_RANDCONFIG: |
+      CONFIG_COVERAGE=n
+      CONFIG_EXPERT=y
+      CONFIG_GRANT_TABLE=n
+      CONFIG_MEM_ACCESS=n
+
 archlinux-current-gcc-riscv64:
   extends: .gcc-riscv64-cross-build
   variables:
@@ -532,8 +540,7 @@  archlinux-current-gcc-riscv64-randconfig:
     CONTAINER: archlinux:current-riscv64
     KBUILD_DEFCONFIG: tiny64_defconfig
     RANDCONFIG: y
-    EXTRA_FIXED_RANDCONFIG:
-      CONFIG_COVERAGE=n
+    <<: *riscv-fixed-randconfig
 
 archlinux-current-gcc-riscv64-debug-randconfig:
   extends: .gcc-riscv64-cross-build-debug
@@ -541,8 +548,7 @@  archlinux-current-gcc-riscv64-debug-randconfig:
     CONTAINER: archlinux:current-riscv64
     KBUILD_DEFCONFIG: tiny64_defconfig
     RANDCONFIG: y
-    EXTRA_FIXED_RANDCONFIG:
-      CONFIG_COVERAGE=n
+    <<: *riscv-fixed-randconfig
 
 # Power cross-build
 debian-bullseye-gcc-ppc64le: