From patchwork Wed Jul 19 12:17:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9851895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4DD8C602BD for ; Wed, 19 Jul 2017 12:20:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D77426AE3 for ; Wed, 19 Jul 2017 12:20:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 30E7B2862A; Wed, 19 Jul 2017 12:20:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B8B2026AE3 for ; Wed, 19 Jul 2017 12:20:02 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXnvV-0008NA-1H; Wed, 19 Jul 2017 12:18:01 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXnvT-0008N2-L0 for xen-devel@lists.xen.org; Wed, 19 Jul 2017 12:17:59 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id 73/04-01993-6FD4F695; Wed, 19 Jul 2017 12:17:58 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRWlGSWpSXmKPExsWyU9JRQveLb36 kwezVIhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8bz62/YCjazVjReOMncwHiMpYuRk0NCwE/i zMaFTF2MHBzCAskSz+6qgoRFBNQlTndcZO1i5OIQEuhglFj/dRI7iMMsMJdRYuK892wgVWwC+ hK7X3xiArF5BWwlPr79zQpiswioSvx+dRLMFhUIl3jbeIQFokZQ4uTMJ2A2p4CXRP/ZKewgNr OAgcSRRXNYIWx5ie1v5zCD2EICahLX+i+xQxyaLrH17y/mCYz8s5CMmoWkfRaS9gWMzKsYNYp Ti8pSi3SNDPSSijLTM0pyEzNzdA0NTPVyU4uLE9NTcxKTivWS83M3MQLDsJ6BgXEHY+Nsv0OM khxMSqK8c3jzI4X4kvJTKjMSizPii0pzUosPMcpwcChJ8Pb6AOUEi1LTUyvSMnOAEQGTluDgU RLh1QBJ8xYXJOYWZ6ZDpE4x6nI0fdjyhUmIJS8/L1VKnDcQpEgApCijNA9uBCw6LzHKSgnzMj IwMAjxFKQW5WaWoMq/YhTnYFQS5j0AMoUnM68EbtMroCOYgI4Q9s0BOaIkESEl1cCYae/3+ea kL+Ulz3TWitwvz0rdXsO99sKa3nl3y+UjGELvZVeUZXHs9cmQOqW9qS3ZY+460aSXZi8+8LW5 CnUG81cuZY/faj5t1X6RaBaj13uWruqUTw0Petx73XGKY2Kco2VU2DUPvSXCc+yXnF3yY7fuy ljub7oTTpzY4TareMIXU4G+n+JKLMUZiYZazEXFiQCEunZkyQIAAA== X-Env-Sender: prvs=366acc0af=Andrew.Cooper3@citrix.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1500466676!64748967!1 X-Originating-IP: [185.25.65.24] X-SpamReason: No, hits=0.0 required=7.0 tests=received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.25; banners=-,-,- X-VirusChecked: Checked Received: (qmail 37446 invoked from network); 19 Jul 2017 12:17:56 -0000 Received: from smtp.eu.citrix.com (HELO SMTP.EU.CITRIX.COM) (185.25.65.24) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 19 Jul 2017 12:17:56 -0000 X-IronPort-AV: E=Sophos;i="5.40,380,1496102400"; d="scan'208";a="49555339" To: Xen-devel References: <1500465477-23793-1-git-send-email-andrew.cooper3@citrix.com> <1500465477-23793-3-git-send-email-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: Date: Wed, 19 Jul 2017 13:17:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1500465477-23793-3-git-send-email-andrew.cooper3@citrix.com> X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Cc: Boris Ostrovsky , Kevin Tian , Jun Nakajima , Jan Beulich Subject: Re: [Xen-devel] [PATCH 2/6] x86/vpmu: Use vmx_{clear, set}_msr_intercept() rather than opencoding them X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 19/07/17 12:57, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper I have just realise I can now drop msraddr_to_bitpos(), so have folded the additional hunk into this patch. unsigned int i; Acked-by: Kevin Tian diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index d58eca3..207e2e7 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -225,12 +225,6 @@ static int is_core2_vpmu_msr(u32 msr_index, int *type, int *index) } } -static inline int msraddr_to_bitpos(int x) -{ - ASSERT(x == (x & 0x1fff)); - return x; -} - static void core2_vpmu_set_msr_bitmap(struct vcpu *v) {