diff mbox series

xenoprof: default to off

Message ID e3034416-0c34-322b-732a-02008be514b3@suse.com (mailing list archive)
State New, archived
Headers show
Series xenoprof: default to off | expand

Commit Message

Jan Beulich July 10, 2023, 9:48 a.m. UTC 
This being x86-only right now, and its x86 bits being heavily outdated,
let's no longer enable this by default.

While there also adjust the "help" keyword spelling.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The adjustment to pvshim_defconfig of course isn't strictly necessary,
but I think the file would better have overrides for things that need a
non-default setting. (Visible in context, BIGMEM would then probably
also want dropping.) Yet if this causes concerns, I can certainly drop
again this part of the change.

Comments

Roger Pau Monne July 10, 2023, 3:52 p.m. UTC | #1 
On Mon, Jul 10, 2023 at 11:48:09AM +0200, Jan Beulich wrote:
> This being x86-only right now, and its x86 bits being heavily outdated,
> let's no longer enable this by default.
> 
> While there also adjust the "help" keyword spelling.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.
diff mbox series

Patch

--- a/xen/arch/x86/configs/pvshim_defconfig
+++ b/xen/arch/x86/configs/pvshim_defconfig
@@ -13,7 +13,6 @@  CONFIG_EXPERT=y
 # CONFIG_HYPFS is not set
 # CONFIG_BIGMEM is not set
 # CONFIG_KEXEC is not set
-# CONFIG_XENOPROF is not set
 # CONFIG_XSM is not set
 # CONFIG_UNSUPPORTED is not set
 # CONFIG_SCHED_CREDIT is not set
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -229,10 +229,9 @@  config EFI_SET_VIRTUAL_ADDRESS_MAP
       If unsure, say N.
 
 config XENOPROF
-	def_bool y
-	prompt "Xen Oprofile Support" if EXPERT
+	bool "Xen Oprofile Support" if EXPERT
 	depends on X86
-	---help---
+	help
 	  Xen OProfile (Xenoprof) is a system-wide profiler for Xen virtual
 	  machine environments, capable of profiling the Xen virtual machine
 	  monitor, multiple Linux guest operating systems, and applications