From patchwork Tue May 16 07:38:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13242713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBFE5C77B7A for ; Tue, 16 May 2023 07:39:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.534977.832514 (Exim 4.92) (envelope-from ) id 1pypGm-0005XQ-6N; Tue, 16 May 2023 07:38:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 534977.832514; Tue, 16 May 2023 07:38:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pypGm-0005XJ-1O; Tue, 16 May 2023 07:38:52 +0000 Received: by outflank-mailman (input) for mailman id 534977; Tue, 16 May 2023 07:38:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pypGk-0004Mf-KA for xen-devel@lists.xenproject.org; Tue, 16 May 2023 07:38:50 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0621.outbound.protection.outlook.com [2a01:111:f400:fe1f::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2c5e3d1-f3bc-11ed-b229-6b7b168915f2; Tue, 16 May 2023 09:38:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8988.eurprd04.prod.outlook.com (2603:10a6:20b:40b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 07:38:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%4]) with mapi id 15.20.6387.032; Tue, 16 May 2023 07:38:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2c5e3d1-f3bc-11ed-b229-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WsbByeVcUA2TyjPDo+eQZHTPCcDRQAcRIzA26v6kAm4IaqYEaFv3oxCdVG9DBhrlXNjhJhgfGG/QwHZfA+sd4J3uslvJ+nbH8ebxDTKSAxH9Lw3PQUoUNrRfigarVlIgZ0t04CqtrXh5Nut2/H6z0FVZC00Zv4ztvGTwXvChZQwyZzp9dHq3CQI6cMQ9899Wo8SEkTADxPeiFDruccfAEtOpeEbYkJ15mUFFm6PXtTlDnVxueqY+XgZeVXbIGExU4B+bql8dUe8hS1tmMqpDinMeviRB6/C1l8dtNVkW0oJcOQsxWsRbZgHJ3+C0DIZMMENa4qBh2B7+ecznzbopSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Je87SJkHd+CatcG6yu9Imtn4DlVtYLFfArWG7ib5DLQ=; b=g22gCHQBtUmWzEcRCNdnuLtFvbJF2keC/W5fLxStVxFoKzaNyoDkiqZazmS78d5HZnNa/odYGrgP2L6bry+5h/U51/ag15++MCBq87D0Zk5BYGgVJgPUDRSHXHZXeCEIW3uxDmMAIqCMZeNRVkqyyRoenS77PQ8pDR3HKcGxeqMkH7qPdQZ3eQQSzCYIum5nhOLxr4ZbxfKz/HDrmsBgQLyNaDXjeP8JsSPpvhDhlA/zF33ur25nZMzcbajCAYf87EaHEMm1ruvoSbwwRIkSZGHbe1PRJypIBbeIQQDOEDdDJLt9o6x/d5KY2V3TS+IKWaRBo6qmXThfwXdn5BGmBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Je87SJkHd+CatcG6yu9Imtn4DlVtYLFfArWG7ib5DLQ=; b=qQMD8gXRPi+CQFgc2yZrSKP+ersXlQjkow/OOxqCXtOALVXlxpsTcY53uBN/ylhy/rnQ9dybsAzerWv2/Ds2s8JYzlrGsSxrtrJkfg8OfcUc/S0WVG0GR13jn68dyXVWolt+7rEM3VUkC4FTBe6wxafLrIgluaz+xv1eKlsThSSaKeRE/riK/0x1vSP0Jf4v6zw7O0uuDRDiSla00joNegXsbslOnyHWNLsX4/Vy/X1H8J2W5GFIfN5zc1ofof9QP/XE1cv8THaP7/tQIxoxegbk0GYv353OLaks3GL4GheHRnRr25BKeCOSzoruXBJLZlhAiFSV0vVuDwHH1UvKQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 16 May 2023 09:38:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 03/12] x86/shadow: don't generate bogus "domain dying" trace entry from sh_page_fault() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Tim Deegan References: <184df995-e668-1cea-6f9f-8e79a1ffcbbd@suse.com> In-Reply-To: <184df995-e668-1cea-6f9f-8e79a1ffcbbd@suse.com> X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8988:EE_ X-MS-Office365-Filtering-Correlation-Id: db10e3db-deb2-4e41-8405-08db55e0964a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EiqFP7aoEJ9zFyqiC1Vn9hp85I5mBR2FImPg6n//IMGyxkHsbou1qp7YI3rQsav3oMHyeplVXTXp65wSp2t8nXGcM8OT6AK+MQV6W84jhfNXQPCh8WL919uUh10fH8L7dyBZtyZPaRh9/MAEsd7Nb38vICs7Ju2V6NYVxZ+md7o/Gj+VIt/K6UkmbVNA0n8zpHG02PdQ+jchUXOlDZs7RFY26EjsbUHaKV/EAhBeZ8WiKvkn9dh3+HgbllzKcQS5/S9P2dR8ZpOtONPGOx8GxKOBr3y0bFSd6Mog45FfhFZ+FxgQuHHhNHIzcBIowR2QiTdol6Tv97eOGtpWF8KNyDOadR6U8EqXWl1lEZnjspGgkQLO5VH7dGUFj1rKx06pCjtAmvdJHVnc+5QskopYXrZWWVq3j5zbJFXnmj/UIbwCPkYioMyrkTsxQp5yJl+Dp0ip+s8bJh31AY7gpQ1kIN9Cr5AEYzaFe63R6dV/LfMkbJu/JS81ES9/v0W9hDCpFcRcVB9C4pomBVr7VoysDRlXG3dbGKoxljnMv7GwLb5C4A+NAtBP57I88IdBFfJrflvuLY4OqUJm04pgmRC7quAREhjtn/mI767CdxrZ9Nzo29Q6p38ITsu5shW72Xa+7NSM3c1GrY8c00XteGP0eQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(2906002)(316002)(6916009)(31686004)(66946007)(4326008)(8676002)(5660300002)(8936002)(4744005)(66556008)(66476007)(41300700001)(86362001)(2616005)(478600001)(54906003)(6486002)(36756003)(6506007)(186003)(31696002)(83380400001)(6512007)(26005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?E/C/mk/5DbHQpWdoUgSMXwgNHS5S?= =?utf-8?q?dG1k8stG79p26GPQn3i+8rLnednYKVxeEnXMMkE5lp2WnGsd3BRNKwH9w4GHgcnL3?= =?utf-8?q?WQ5Z8a9YCQUDM6V9mtjEvuYlo3uURz34Qml8jxrYYZne+XS8MF46SbhzKTwMTevY/?= =?utf-8?q?479rnv1n8z0mcZJp9AFSDKa1AhXU0GkVI4g220i/oWiHUUeUUDtFL28yXvrZHLUbm?= =?utf-8?q?a2rCuo3T5x95L5nCm+pRrv90uGUmlU1KCgwgnWVBDt8qyQUHq80hwIWT1ThL2BHZ7?= =?utf-8?q?EQA+uTpBTy0xWZvbTZXXI1zYTVW3+T017+ST+w9NxPV6WypW4PeSIMmThZ3mv5ySZ?= =?utf-8?q?dHcq6HqT5YUMQFdB8m4RLFa6hlnhrPlY0O/UXO9e9G0TUnHpMHz/3RQH9zZ2I0DfH?= =?utf-8?q?n1QPcDvtogGypfqTXNde6dBGL8ibBRWZhVD0yOCT2IQ2wECum8wGeCpF4IPL7u+jQ?= =?utf-8?q?F6kwaIKdsrMBvkTMb/ZVTB0IpaVlUoDqFwafYKis5VzKcIEx0SpSy/hzoZHttJzNX?= =?utf-8?q?/7P8sYfUPlyZ61am+k2kw8Fs7SLokrvwFIpGmO9BKdnQYGZQlabVpuDnbkdpMr3gl?= =?utf-8?q?iCW3uhsLxaGzQrDrTefeBl9lcVe4ONvDZyde6zdL3WdiUmOEldm3DaYavrQKkm/At?= =?utf-8?q?mBSHuJG8ysujJSpFsOELxqfNfJbM0QdCVrhZ39DRVuoNOWRFOSmGS4lBqdlLNkOJe?= =?utf-8?q?30+aTQy8e2T/rR2O8AOs0Y1g1MTym5LzRszCJcnX/HTYR3MrNop/QldQZGVphLPl3?= =?utf-8?q?Y5krHxLd58Gr8fmMrlF3aTNcvDHQe8jYn5ZtdoNlmVph6FJklhI4qLR+WCVHkkp7a?= =?utf-8?q?Ds1Lci5VgGt6tU9RhhTStQ+/rHjXXgZhAruXdztGURFq6U6DxVYTZihCKlxcQrYO4?= =?utf-8?q?vebYkH/NyLpMPArJJPii9ZbI9O/QUgoDyapbkWfVSewHRIvsODt9l2ADd4rRQ5N7r?= =?utf-8?q?m00qg63+gMBFxEbqzz2/X1ndQtXM7OZJnW717xG4HUFzsfbchIjRNPCJZzcyZtWfB?= =?utf-8?q?GasTRRYHtU6Ou+XffJBf1gKmW5jUjXi7MV0LwgpR5+CENcquZ9VXvM8TO7Qgvrbu3?= =?utf-8?q?mLoyXRzVyJK4OB8S8gJojTOydKX2TcLSo2A+JAqNWYTEwh3PCEB5fAdIzFtNEX6ru?= =?utf-8?q?oiGKS0wLmf5nvWYOBJgIqeImuhwNMDOZEAyVOamBhwrHR9XHOQFzcEYYBBWZNRozg?= =?utf-8?q?iPEUU1sI3CAX0xXGftSWVIhxtUXCg+01jYNdoQ0U6iwPt1wtcraFXobB2PyLE2UPF?= =?utf-8?q?Bet5Gnv2k0fWnOZPO4Q9Cq4JjHjKOsqAF0C9UsYSJZxN/mkieIvIKTJ2R+4l/ozTg?= =?utf-8?q?w0x0XKuyVmp7xifukYa5egqpBrDT8+TE8aIOw1divSGEufnUgSQg9JGyZQllVxHJ4?= =?utf-8?q?xsjHJTVzIUgpPPSuXhEyQgDPPoytFxh4SdGfGK7sI5/4mqgdeXUBlAGP/ZbVp37h1?= =?utf-8?q?HFh6wBTP3OrqCfEOn+cMe1duDcXSWvpTWjZ49fRUpASkZIN8YDpNuXwfTBm1dhLtX?= =?utf-8?q?anbcNVApddn0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: db10e3db-deb2-4e41-8405-08db55e0964a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 07:38:48.6813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bF2Nbgncv27JcrxTSu9ShI3vhc/8/rLz00qzh7Rujxt0g1yYYPqW8waSrWNz1LMO5lM+QrzehQqCmF9HvE4ojw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8988 When in 3-level guest mode we help a guest to stay alive, we also shouldn't emit a trace entry to the contrary. Move the invocation up into the respective #ifdef, noting that while this moves it into the locked region, emitting trace records with the paging lock held is okay (as done elsewhere as well), just needlessly increasing lock holding time a little. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -2480,10 +2480,10 @@ static int cf_check sh_page_fault( sh_update_cr3(v, 0, false); #else ASSERT(d->is_shutting_down); + trace_shadow_gen(TRC_SHADOW_DOMF_DYING, va); #endif paging_unlock(d); put_gfn(d, gfn_x(gfn)); - trace_shadow_gen(TRC_SHADOW_DOMF_DYING, va); return 0; }