Message ID | e58ac418-b044-eb26-308c-5ddaa021daa4@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <xen-devel-bounces@lists.xenproject.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE4AFC636D4 for <xen-devel@archiver.kernel.org>; Wed, 15 Feb 2023 15:09:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.496040.766556 (Exim 4.92) (envelope-from <xen-devel-bounces@lists.xenproject.org>) id 1pSJOp-00037k-A0; Wed, 15 Feb 2023 15:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496040.766556; Wed, 15 Feb 2023 15:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <xen-devel-bounces@lists.xenproject.org>) id 1pSJOp-00037d-7J; Wed, 15 Feb 2023 15:08:47 +0000 Received: by outflank-mailman (input) for mailman id 496040; Wed, 15 Feb 2023 15:08:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <SRS0=7OvG=6L=suse.com=JBeulich@srs-se1.protection.inumbo.net>) id 1pSJOo-00037T-58 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:08:46 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061b.outbound.protection.outlook.com [2a01:111:f400:fe02::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a34ca140-ad42-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:08:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7317.eurprd04.prod.outlook.com (2603:10a6:10:1b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 15:08:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 15:08:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion <xen-devel.lists.xenproject.org> List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>, <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe> List-Post: <mailto:xen-devel@lists.xenproject.org> List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help> List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe> Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org> X-Inumbo-ID: a34ca140-ad42-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJMEqDCtqsW88J+7nFgVp4KSkaSxp+opvhoOviUvwV1IpHY2uP8gwCOJYb6/ruQgFGhMMmfnRjm1Ha6JfVB8nZ3IxdYrvbPMo0GsiY+Bw4gr/syS5cU3ywr+omuDTZ5YtQ1p+mVHnWaicCQe6u7u7eOH1I4fB4PKf07vKom16pbGaK37boLWqgXk3PVEBTPLoCHxJYDvGvbQ2jC6fP06Hx8N8qqCX1i8SF83ukoClfM70A3bbgjmmGzbGTqfhww9hHsQm+aIrfQHA0xSqfwwlTQDKEDYOgscZP3Oyw73a61i4g0At5CunGRXb4bNow3pC19jAGKsjCh1wLrTS0Ho5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jyt9Zb2uyb7Ppza5owbKi9EJTd2x28VYqhSfL00cOqI=; b=NUxtHyuAi12RV/hRAA3vUFqsgjtcK6D0apSkq+eEZ5ptrpmTkbaIB5s63R6H3iJ+pSBU8wRQf3yRoHJa3r5lWLCru22cKONzyMhrIXHdSbQyVZ7COLf8nXaE2aZaD+3wdlb311Zpwp8gvnjtlUX3xDan19pjaI0TvlzaEE9y8UWK3iLaQ38Ir1V3khGcNAZ13PEPj/PmlMPA/xCE6Wp/YrYoUbD8VUwhBXahb8uYVRVFmErKURzfk8qpKchzlOHqSyXq6n8TYyjhLbzdYBt186ggOBEYjGU0uGMdoe7cg0+h0Ybk1QoaHH+TJKzNDmOdwhjlvojkBlGRB/VwBm3n5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jyt9Zb2uyb7Ppza5owbKi9EJTd2x28VYqhSfL00cOqI=; b=r9i1Mur7lgtTDcdFfn2/yU8aulFg26WbqIUTOyzKdEuN8VWo/G6yVXS+ySsdP06tPCFqEqefTk7BCmZFkzkUFD3i9KfOq53wjQEq+s1tQpqYEahV/NKY5bMHNnBSdV++IlXkWXc5HZTKn2ZAlgEQFyOVYE1iMmVBHRzCqH5Kv1CiMDEz4F3z+n8E/g7ndKBVOx7KJzRSRJ5pW+YjXp8y/FwrBRu0ge9zYjQL6Dnhf5hZHlHFV/9jPyHPVYWKL5SonmSoVIP3uvVP238aMQspiOZps8A4k+MhK58/PZVM0klcMcSHK+iTZpKDoOWiIrY9wKPdOi1FSQXHUgQSdscg4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <e58ac418-b044-eb26-308c-5ddaa021daa4@suse.com> Date: Wed, 15 Feb 2023 16:08:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, =?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com> From: Jan Beulich <jbeulich@suse.com> Subject: [PATCH] libelf: relax ELF_PADDR_OFFSET && !VIRT_BASE check for PVH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7317:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cd94585-647a-445b-c469-08db0f66863e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d6zHFQTyspvI8qYT5WCpqTm56vLh0ePO9PKEFC1AKhH/9EK0nkM3qZJxkKEWD0C3JwTEVDQdzI4ZjI/mmmm25RM1leG9j6t4l2RCVy/bXb8MemJKu66GdjGjKuphc+/ZRi5Q7k9YVgylEXGWcxUzojNamUurDqGrxmQs5HYo/TAxJG7c6S2a61E7cwZN8OFlwK9t5eicKap1MX0uErjCVqc5VJqcxBQv/A1aYaP0jwWXQNJ0bh5NHgbr04eYiuj9L7mVg5TxELc9Ad1mfm+vEdzSLJ9ft6xRQ9wZoGqyjDBa1bdvExTi7ocWPWHblFK7hlx1EvM7PG8vYtWlxcrCY5+kZWv0b60wks3GZgdFDNC78zZyXgGGZnJpqV167S8qgsk4XU5BDVmo4Dg/7/IRECxefDjFUr5VHZe1spntzkkzghUmex3lb/H8RHWdN9gaRYik9RLPMB6sD3fT8yMibQdwhCXAi4rTVvJQpWgHilMAdgCLTuZ7yxU4a4JHAORockHE8O53O6qUtKk0hp9xe1SeO2h1DecVBQ0kxPbc/hbPo2TbuM/E4uOAQRoN2E1Lf2O5VAQJO30W7kSdVd5D5R/zu1yl8PRRioKShZ7zeSt3JM3NaaH5HUlYt955vql16dFK6r7MQia0Rz0OP89mDrSbDt2zBCYZpLf18NUrZqv2A0+eWNhqh61R1+Ex3CEayHh22s5XWdHCVS2U5opfTNlUmIhJfCYdI2w90eatOn0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39850400004)(346002)(136003)(376002)(451199018)(31696002)(6486002)(36756003)(316002)(54906003)(6916009)(66556008)(8676002)(66476007)(66946007)(4326008)(2906002)(8936002)(41300700001)(4744005)(5660300002)(38100700002)(26005)(6512007)(186003)(6506007)(2616005)(478600001)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?WWr5ibQ9oX+dMowP7iie8m86Se57?= =?utf-8?q?fELfeXOuMd4iJp8nuT+g/3T+AJUWB+LyVKAuXqrCbAEI3MitaMu1tq2w0ldutIQml?= =?utf-8?q?fIGrwqbxER8BjoE7N5jtZf/LugRN+67hKefcMurN3MmRtsIWv4EOY/FyOWPX2rZNi?= =?utf-8?q?uazqHILZvQgLqBUJtdxdEgcMUVHnohOgGytARWNxZVmmSycCgpd7GwyiYZDWGRf1a?= =?utf-8?q?gMghEhk0ppTUubZ0AWwv8L0k/gKFD1YZQBMaj2sqwBESXpuVe44BWf8ywAb8tA+4M?= =?utf-8?q?I9cKDPSqq60Uaj9MZW99MK0md/4lG6siqsE79otSkthSul/2JsV06LG9f6cW+8tgD?= =?utf-8?q?OWbogk5tSKNDt3OCovRevTiWdTUy0j6Boe5VBUo1a10YI+zjV7q7cr4ssxUJVP2/F?= =?utf-8?q?qPsR5tLCbHFRfIva6ux7EkqFmWWt3Yaj2h6xxSYQRbz19SvvAcqnBUiIOGSTXGdQV?= =?utf-8?q?O/uvJAUHGMtHjDi33CVxQhee6teOv2Fo45H7xktqY2dBLeZ2jQpJ6oWPYjwYJoG6x?= =?utf-8?q?oVu1jKSkF9qXR7PKqOG2o5vpq/u3VXnqjwd3Bd2QTgwY7NSZ9FQ+HJ93Xo7w2huxb?= =?utf-8?q?0ud98doqCvQpPioynw+z26KtkTUmhY/to75kcxq7PtsxfN0YLyDy+Q2CU/JOOF99x?= =?utf-8?q?IHD1gaBTi3nJliMrO+WFnUOphFYPHJkAd6OTwi+EOWuMsglAHGHxtAwJ+0eTlTsbp?= =?utf-8?q?gN1fG6nOdBsscncs0UJ22XIi5+KnGywoB2sE3ZAM8CCTzooqYcHCFXd+4pmbgwNrk?= =?utf-8?q?5cejirUaKKC1APjbZAKtM5UQK70M6MonJd0pXL31PFkJxukn35KEIECb8DeZGgVp0?= =?utf-8?q?C4eQJZzP8/Tqlz7TbDny34nADt3vgR8cASYP3AtcvFuDGxYnnENnisPZY3ThI5coM?= =?utf-8?q?HZPyy9UE/hwEhgTqFDyRUkURLsOB5f4L/KkU2ggIqmsQlfa/DizE5stsWPKF+hkgU?= =?utf-8?q?CugL2of6sI5DHOHgbjPpGOizrikxQnPW/tEoxxP98wIjK9X06wWwhKVubk/2rr4vV?= =?utf-8?q?LqINPmmudh/CxHIYkLhD91ABlslAhO0LjlZxs8jN4b841czvYKvztKkVUzU2TOanP?= =?utf-8?q?KTFIsQGRjxxT8c4Gfrw611Z0LzHwz+390P+M8sCDjRnGRLi+BSVsArwYY6IWifp4T?= =?utf-8?q?bR138o18uTh246230/UO0ZzsNMC32aYP3EteEWeAODsarTq1CNxYtNDnMTqhj0Oko?= =?utf-8?q?RbjF9Xz/vmHZ7gAKgSy8Ahd7/Er1jYBXRD3n40tlCDAj3jevXlEdbH1PaYFfx1KEy?= =?utf-8?q?in2TA/sppF3XfwkJNKxR/8izRQkOz6+cDZgC5FDQm5Pw7SI5VrEEOryGrYT27uZks?= =?utf-8?q?4DG2cJY76IslHGXuQLbMpGDuAIK+EOWhx0YhqkQ6VPZJhVMMhQY7Qh8Ml7Nk3ZO86?= =?utf-8?q?aXFswyH1Okl6fxo3a7EtdNVjbudkSRK8E+Mi/a3WA5dCVx5/8mEvPRFRwDrrweGUG?= =?utf-8?q?V73mPjLJnwi2QRXe5Xfvee3ce7IYQR/VA6Ym1QivTNn8DSiA0jBKz1DqqPUdCElEd?= =?utf-8?q?lsvxtbhLSx8v?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd94585-647a-445b-c469-08db0f66863e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:08:41.7960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Y4M/6o7aKlNzM3G/pFpOgTsGYBA9hk9PxPafP1kh9J6Ik6LykToBPMlPWyhhyukO2qVwBCak7xTXA9a8FvOzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7317 |
Series |
libelf: relax ELF_PADDR_OFFSET && !VIRT_BASE check for PVH
|
expand
|
On Wed, Feb 15, 2023 at 10:09 AM Jan Beulich <jbeulich@suse.com> wrote: > > Both values are unconditionally overridden (to 0) in the "hvm" (i.e. > PVH) case. There's therefore no reason to punish a PVH kernel for > setting the former but not the latter. > > Fixes: 632cbaf1243e ("libelf: improve PVH elfnote parsing") > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Jason Andryuk <jandryuk@gmail.com> Thanks, Jason
--- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/libelf-dominfo.c @@ -419,7 +419,8 @@ static elf_errorstatus elf_xen_addr_calc uint64_t virt_offset; if ( (parms->elf_paddr_offset != UNSET_ADDR) && - (parms->virt_base == UNSET_ADDR) ) + (parms->virt_base == UNSET_ADDR) && + !hvm ) { elf_err(elf, "ERROR: ELF_PADDR_OFFSET set, VIRT_BASE unset\n"); return -1;
Both values are unconditionally overridden (to 0) in the "hvm" (i.e. PVH) case. There's therefore no reason to punish a PVH kernel for setting the former but not the latter. Fixes: 632cbaf1243e ("libelf: improve PVH elfnote parsing") Signed-off-by: Jan Beulich <jbeulich@suse.com>