| Message ID | e6e161b23ad9860972a9af2e7dfa61ce1f0cacda.1652170719.git.lin.liu@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Implement byteswap and update references | expand |
On 10.05.2022 12:15, Lin Liu wrote: > --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c > +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c > @@ -31,7 +31,6 @@ typedef uint64_t __be64; > > #define __BYTEORDER_HAS_U64__ > #define __TYPES_H__ /* xen/types.h guard */ > -#include "../../xen/include/xen/byteorder/little_endian.h" > #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ > #include "../../xen/include/xen/unaligned.h" > #include "../../xen/include/xen/xxhash.h" Doesn't this need to come ahead of what is now patch 5? Jan
On 10.05.2022 12:15, Lin Liu wrote: >> --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c >> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c >> @@ -31,7 +31,6 @@ typedef uint64_t __be64; >> >> #define __BYTEORDER_HAS_U64__ >> #define __TYPES_H__ /* xen/types.h guard */ -#include >> "../../xen/include/xen/byteorder/little_endian.h" >> #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ #include >> "../../xen/include/xen/unaligned.h" >> #include "../../xen/include/xen/xxhash.h" > Doesn't this need to come ahead of what is now patch 5? > Jan Thanks for the feedback, I am preparing a new patch series for this.
diff --git a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c index 01eafaaaa6..47e071574d 100644 --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c @@ -31,7 +31,6 @@ typedef uint64_t __be64; #define __BYTEORDER_HAS_U64__ #define __TYPES_H__ /* xen/types.h guard */ -#include "../../xen/include/xen/byteorder/little_endian.h" #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ #include "../../xen/include/xen/unaligned.h" #include "../../xen/include/xen/xxhash.h"
xen/byteorder/little_endian.h is included but not used, Remove it. No functional change. Signed-off-by: Lin Liu <lin.liu@citrix.com> --- Cc: Wei Liu <wl@xen.org> Cc: Anthony PERARD <anthony.perard@citrix.com> Cc: Juergen Gross <jgross@suse.com> --- tools/libs/guest/xg_dom_decompress_unsafe_zstd.c | 1 - 1 file changed, 1 deletion(-)