| Message ID | ece6c5c2-43f8-36d2-370c-37d988baeb87@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tools/gdbsx: drop stray recursion into tools/include/ | expand |
Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"):
> Doing so isn't appropriate here - this gets done very early in the build
> process. If the directory is mean to to be buildable on its own,
> different arrangements would be needed.
>
> The issue has become more pronounced by 47654a0d7320 ("tools/include:
> fix (drop) dependencies of when to populate xen/"), but was there before
> afaict.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
On Thu, Oct 15, 2020 at 02:17:18PM +0100, Ian Jackson wrote: > Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"): > > Doing so isn't appropriate here - this gets done very early in the build > > process. If the directory is mean to to be buildable on its own, > > different arrangements would be needed. > > > > The issue has become more pronounced by 47654a0d7320 ("tools/include: > > fix (drop) dependencies of when to populate xen/"), but was there before > > afaict. > > > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com> I tried to applied this one but git didn't like it. Jan, feel free to apply it yourself. Wei.
On Fri, Oct 16, 2020 at 01:26:49PM +0000, Wei Liu wrote: > On Thu, Oct 15, 2020 at 02:17:18PM +0100, Ian Jackson wrote: > > Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"): > > > Doing so isn't appropriate here - this gets done very early in the build > > > process. If the directory is mean to to be buildable on its own, > > > different arrangements would be needed. > > > > > > The issue has become more pronounced by 47654a0d7320 ("tools/include: > > > fix (drop) dependencies of when to populate xen/"), but was there before > > > afaict. > > > > > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > > > Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com> > > I tried to applied this one but git didn't like it. > > Jan, feel free to apply it yourself. This is already applied. Sorry for the noise. Wei.
--- a/tools/debugger/gdbsx/xg/Makefile +++ b/tools/debugger/gdbsx/xg/Makefile @@ -12,7 +12,7 @@ CFLAGS += $(CFLAGS_xeninclude) all: build .PHONY: build -build: xen-headers xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile +build: xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile # build: mk-symlinks xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile # build: mk-symlinks xg_all.a @@ -21,9 +21,6 @@ xg_all.a: $(XG_OBJS) Makefile $(XG_HDRS) # $(LD) -b elf32-i386 $(LDFLAGS) -r -o $@ $^ # $(CC) -m32 -c -o $@ $^ -xen-headers: - $(MAKE) -C ../../../include - # xg_main.o: xg_main.c Makefile $(XG_HDRS) #$(CC) -c $(CFLAGS) -o $@ $<
Doing so isn't appropriate here - this gets done very early in the build process. If the directory is mean to to be buildable on its own, different arrangements would be needed. The issue has become more pronounced by 47654a0d7320 ("tools/include: fix (drop) dependencies of when to populate xen/"), but was there before afaict. Signed-off-by: Jan Beulich <jbeulich@suse.com>