diff mbox series

[net,RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case

Message ID ef9e1ab6-17b9-c2d7-ef6c-99ef6726a765@suse.com (mailing list archive)
State Accepted
Commit 3ede7f84c7c21f93c5eac611d60eba3f2c765e0f
Headers show
Series [net,RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case | expand

Commit Message

Jan Beulich Sept. 17, 2021, 6:27 a.m. UTC 
When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the
special considerations for the head of the SKB no longer apply. Don't
mistakenly report ERROR to the frontend for the first entry in the list,
even if - from all I can tell - this shouldn't matter much as the overall
transmit will need to be considered failed anyway.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 19, 2021, 11:20 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 17 Sep 2021 08:27:10 +0200 you wrote:
> When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the
> special considerations for the head of the SKB no longer apply. Don't
> mistakenly report ERROR to the frontend for the first entry in the list,
> even if - from all I can tell - this shouldn't matter much as the overall
> transmit will need to be considered failed anyway.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Paul Durrant <paul@xen.org>

Here is the summary with links:
  - [net,RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case
    https://git.kernel.org/netdev/net/c/3ede7f84c7c2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -499,7 +499,7 @@  check_frags:
 				 * the header's copy failed, and they are
 				 * sharing a slot, send an error
 				 */
-				if (i == 0 && sharedslot)
+				if (i == 0 && !first_shinfo && sharedslot)
 					xenvif_idx_release(queue, pending_idx,
 							   XEN_NETIF_RSP_ERROR);
 				else