| Message ID | f5de24818596d88da1c27075c674a823670ee44c.1693990010.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/x86: address some violations of MISRA C:2012 Rules 8.2 and 8.3 | expand |
On 06.09.2023 10:57, Federico Serafini wrote: > --- a/xen/arch/x86/include/asm/hap.h > +++ b/xen/arch/x86/include/asm/hap.h > @@ -30,7 +30,7 @@ void hap_vcpu_init(struct vcpu *v); > int hap_track_dirty_vram(struct domain *d, > unsigned long begin_pfn, > unsigned int nr_frames, > - XEN_GUEST_HANDLE(void) dirty_bitmap); > + XEN_GUEST_HANDLE(void) guest_dirty_bitmap); > > extern const struct paging_mode *hap_paging_get_mode(struct vcpu *); > int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted); How is this related to vPCI? Plus if you change the HAP function, please adjust its shadow counterpart too. Jan
diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h index 9d12327b12..05e124ad57 100644 --- a/xen/arch/x86/include/asm/hap.h +++ b/xen/arch/x86/include/asm/hap.h @@ -30,7 +30,7 @@ void hap_vcpu_init(struct vcpu *v); int hap_track_dirty_vram(struct domain *d, unsigned long begin_pfn, unsigned int nr_frames, - XEN_GUEST_HANDLE(void) dirty_bitmap); + XEN_GUEST_HANDLE(void) guest_dirty_bitmap); extern const struct paging_mode *hap_paging_get_mode(struct vcpu *); int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted); diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 0b8a2a3c74..d743d96a10 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev); __used_section(".data.vpci." p) = x /* Add vPCI handlers to device. */ -int __must_check vpci_add_handlers(struct pci_dev *dev); +int __must_check vpci_add_handlers(struct pci_dev *pdev); /* Remove all handlers and free vpci related structures. */ void vpci_remove_device(struct pci_dev *pdev);
Make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/include/asm/hap.h | 2 +- xen/include/xen/vpci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)