diff mbox series

x86/vPIC: correct vcpi_domain()

Message ID f7016076-19a4-4416-b7be-df16e8d4a017@suse.com (mailing list archive)
State New, archived
Headers show
Series x86/vPIC: correct vcpi_domain() | expand

Commit Message

Jan Beulich Nov. 23, 2023, 10:20 a.m. UTC 
Make it use its parameter in both places.

Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Andrew Cooper Nov. 23, 2023, 10:34 a.m. UTC | #1 
On 23/11/2023 10:20 am, Jan Beulich wrote:
> Make it use its parameter in both places.
>
> Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Roger Pau Monné Nov. 23, 2023, 10:41 a.m. UTC | #2 
^ typo in the subject :).

On Thu, Nov 23, 2023 at 11:20:24AM +0100, Jan Beulich wrote:
> Make it use its parameter in both places.
> 
> Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.
diff mbox series

Patch

--- a/xen/arch/x86/hvm/vpic.c
+++ b/xen/arch/x86/hvm/vpic.c
@@ -35,7 +35,7 @@ 
 #include <asm/hvm/save.h>
 
 #define vpic_domain(v) (container_of((v), struct domain, \
-                        arch.hvm.vpic[!vpic->is_master]))
+                                     arch.hvm.vpic[!(v)->is_master]))
 #define __vpic_lock(v) &container_of((v), struct hvm_domain, \
                                         vpic[!(v)->is_master])->irq_lock
 #define vpic_lock(v)   spin_lock(__vpic_lock(v))