From patchwork Mon Jun 12 11:46:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13276394 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD951C7EE25 for ; Mon, 12 Jun 2023 11:46:59 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.547063.854261 (Exim 4.92) (envelope-from ) id 1q8g0T-0000B7-Uz; Mon, 12 Jun 2023 11:46:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 547063.854261; Mon, 12 Jun 2023 11:46:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0T-0000A3-R1; Mon, 12 Jun 2023 11:46:45 +0000 Received: by outflank-mailman (input) for mailman id 547063; Mon, 12 Jun 2023 11:46:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0S-0008F8-7B for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:46:44 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0628.outbound.protection.outlook.com [2a01:111:f400:fe0e::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd3a102c-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:46:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:46:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:46:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd3a102c-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2z65NHZLHfHzPGCAaoJqmkwopKeWpZen0NY99NV8MNrBvKSxWzhbSm8iSIJUf5XNlNJH6KrsiGWIu5ZMxQXuPzr/ikF/5jio70MCwLdCXLRrv62FHLHYet/7pfrzTsKtfor8vKpSkAodyXqwy5FsdYLkQddIBkRKhNzTHUMkN5U4bllZB4wYY7UWi6JKGNChwLca4oCfFYQLK8tbuBjp3d62b/kNfF4WVe23FihmuEmn0w37wCiXc0sIodAVw2n0X1eTXnoKxgY/d567MLKYEPeGErJCsJ/FMJvtiUys9/DQb2WGG+DRLhRy+4q5ClzHPP00xqOI8BaJ3cBbS8SRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=Hb4EbkjUfxA6eW8v6YqVI0lcy8GneIngjRiI0Ypb5Z14bv9DNLRZ/+rFsw+Wb6W7BmBU3HXLaG1QzwzRmtgyjcaVvUU2Gko9exWNs5ST+8zRi28jU24vVElYHUPc54I31o7LM55z3Xudun98GWPeP5zGEqkWWooKxq8GQL6CaT+J1sdO0WYeV6HPN7PiOP2JCrx6TW0J40dXcfcvvNxWWcaSgfWp+RyYPzGqXHHS9Ycw2fwWPzuB0pE9JAUZBPFzE+zEtZ31fQhLH05VDv5ekfcGW79dvQMp+rdT1NnGOv9/yfhFby1/YLL42ZAcFIcU3Y2qP6ns4NSnF/rcdlHFJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=3uTip3c+Hntan0MmCkFCY9GXmpA27MUEZ0tmcnb7l/S98uqt8YiW5C+QZ4eTQzENtRWDFs85Yr3Yx3Og3U28bhdgAUmhhq86RXsUY6RMJwfqzdjppSSan0GwwMRkE8RwG/xULGcQ6Vnvt2MU0mG2GXFqzTQfs/C2Bid7kmlDcdr2tfh/LPtlQGdLE+CbQx3KkjCyr08UGOJiDNE7UzQPVGl1VGeY9KpIuQEX1v818CaClYFDc8zBtJkIUsUHj1S9huSZnZ7y9JtqUdLj58IbkdYdIZSDaidpcLveYsC5XYAEDAJVxDGGRY5EIAb2PFjSCd7b0iKX8xeHL8m4ImQdww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Jun 2023 13:46:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 3/5] libxg: drop dead assignment to "ptes" from xc_core_arch_map_p2m_list_rw() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> X-ClientProxiedBy: FR0P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: dbdcf97e-575a-459e-318d-08db6b3ab0be X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dmzPkbX53d/WwDSxNKurA3qeSA/VaGO/h5QllgK5+u2QFoFOiNErvfrycOxP+5Ruu7Bzo325I7Fc6Fi1qS734r6Ta9gb6mJW8Ga91WxprE/p0+uVSrkgzaTkTh0lL2TOYbgC+SiA0vlz/KTSHPxNbrR20wp4ak1lZ8rXqLNbPu3ojZ06Z6uw/kWWQhro6/yxn+uzIzkMEnsCYA3ZerKNH1rSmxIZX89xE6blLHyOYSgkRCyWufrPUd154upPTLmj8DcU85d3BdqIjQzAvo5tzqWUXfuW3puSzAAASz2m3ChdV4XD/V1fzc8bhZoCcTgmP26epmYLASCgnS4tHKVQQ2cEvVYLuccEKEFMH12HWkIihf0eLAC05oBdgK+8EFEbtVqESr+F4DGrCGqzjLq5vAVHX2llSglyKxKLLVO6gL1stUH0g1lSM7Bp9zxB85ul/jnVGUfLQ8hVhmfa5EAkPe9M4o2hLKI5E2Ofisg8BIUJy8AEd3Ci6nncNUD6vAPC6wU9U74GVvJwnoS/ONBVMtRm7rjzb89XH8BEimBLgFPYv6YwzPDAw/m3Doza65eg4JmQ/DobUIdYlvx1Im/SHouua/+xOepqFhuPQuVGp88YdOZUzfFJs1tHNPNCpvSyQssunFKO1nxcL5UK4P6duRIPuzS753e2caZbJWE1fkUFLLxqK4AEgsQQl9zyHxa+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(107886003)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(4744005)(2906002)(38100700002)(86362001)(36756003)(31696002)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?p/aOdfra3voJ/Qp88cFuhxArFFUI?= =?utf-8?q?a0p/3AtJszKEe6Hrd1CR37GsngU1pE7ApjpxU9mgJ7oJ7iqdE6u9dbEpYrf2x1BJ0?= =?utf-8?q?ye1V9HsWSaQUD7wD9xh56Go2KDjJJNWY9607akxUkWYAJRAgDIzw+uorlP1QMBDkm?= =?utf-8?q?A7YYWrYI9krUZWvxDtNXNUpH/qpNYJ6YVHZwZoxySaFhzQ6u7BNDmCFupF+xiKlV0?= =?utf-8?q?Hklltrm6aetaFY9xFwSYqX9ZO6JPos65DchtpJbWLdlmTiiMxHHLq2ZegSWur4rTp?= =?utf-8?q?0oGzVTPaJO5JYSiksnz0QiHN0gzqI5Dho70gF9VnR6yzHtNBsUUUf70+vXMm3Yo++?= =?utf-8?q?klqM0UyRe3F1dvQR7m7wmRQyzRowWMO8QItAFTcWg2lGMnCgVqDeljQOx3pwdJjC/?= =?utf-8?q?xt59ySyfkJRfbPKebMjtSsuq5Akfzuk4d02aWeTE0vtUbPhvxLeJvXcuXExIk8bsY?= =?utf-8?q?Yoaclrf33F7v25AaQnbkSJ4Zj7hyba7zDtHZhOcp/1kTX7Ot9lI0bohQQsqPIOhWf?= =?utf-8?q?66rmdhz5cP7eVV5FvzJkzCe27n/qXHhbjGCmlqb7Eza6GOkPn5pF0RbcPBPsv6bNb?= =?utf-8?q?VbNsUloNWNyBrjXJHf8N07b7EU0mpuwvatQ7ke2VweGZDQc1gxE2W+4Z2asp5qcsX?= =?utf-8?q?NryFQikSW0p4jZGjBCFNYxJ8f07hVc+hvBCXNZm0O5g0ziN1Halr3xktizo3A4xIW?= =?utf-8?q?WvJP2hfeDgUiqvc9B6Z6E434Lom/zMT3PtFUgrEYVwfNjYXBgnauVEarRsQwaax9T?= =?utf-8?q?dVp4h7CKYdy1lZMh1y01vSHXHUsQLOQwpUoQpm76McfEDvhN4O+9v6dYv17hZFDfw?= =?utf-8?q?c2bxhFvC9Osgbf0TGtNygLLAXAQ3Y+wVHWGMvqboKuc7a/A5HM77XPkp+SyhQpQTu?= =?utf-8?q?bQabokDQQxYVDiDc7pYrVaaVnyNlwIOfQUByKjj/uPei0YNuHcghP6bLKZu/8H9fB?= =?utf-8?q?dGTBSOCx9174sVZDwcPwob5YtxFSqKeXm25UBN6+rfmKVhxVF6zFQTkKNGF0TrNh+?= =?utf-8?q?2y/2B72SKB9e76yldBAT9NHhvmakrOi66IenwdrKBneJTFQfyVBcunOYZfB2Yub3q?= =?utf-8?q?LaUJcLxa0Us+q8hE8KgerHxynA+eaQNPG8wNyv6B5fRNJc59hHFwwjewxM3TRgHjv?= =?utf-8?q?FsTWN6dOPygjiglE6G671nvTxy5BGr2KWgLA0qYtd7uKaNtR7/U2vNvDytDpVwhBT?= =?utf-8?q?Ww00ST7bTw34O5pYlBBj73IVHGenEvI3jOsUC41SwdvfdU3yKnXjyMJcToJjVGkAA?= =?utf-8?q?/ce01lKkEKkD3yK5dqqPd++/2WhgmaHL1hsMA9N8F1JTxOaycAablJlCkhBiOv6Rd?= =?utf-8?q?jQEaM1OvgDB5eWjRivIC2bKTIe/ZfgzsL7RbyU+5pBHyoTezflj2/bQzfl7KoVvtN?= =?utf-8?q?NeHvaMl0FKW6hWqBIQNq81FphHafCWnEJWF4+wAHgu7BRG7cd68Nf/2wLMAUaccVD?= =?utf-8?q?5005gBNw5mekhTdgHlskL7mw48E9s5nx/9gimSEuM33hpE3ULA6qtjIMk8+uVFQ+J?= =?utf-8?q?56ZYc4obFOjy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbdcf97e-575a-459e-318d-08db6b3ab0be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:46:42.2189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: chZI6/Z//fRkk4+b/7Hm0CbFeNURtfK+8CT/r9k2Hed49sL6V1eYZRbJHuf5x1fH9/9NRFCUztb5J99RUClfyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 The function returns immediately after the enclosing if(). Coverity ID: 1532314 Fixes: bd7a29c3d0b9 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -210,7 +210,6 @@ xc_core_arch_map_p2m_list_rw(xc_interfac } munmap(ptes, n_pages * PAGE_SIZE); - ptes = NULL; off = p2m_vaddr & ((mask >> shift) << shift); }