mbox series

[0/8] add generic interface to set/get project

Message ID 1551449141-7884-1-git-send-email-wshilong1991@gmail.com (mailing list archive)
Headers show
Series add generic interface to set/get project | expand

Message

Wang Shilong March 1, 2019, 2:05 p.m. UTC
From: Wang Shilong <wshilong@ddn.com>

Currently, Filesystem use FS_IOC_FS_SETXATTR ioctl
to change project ID of file. However we don't
support ioctl on symlink files, and it is desirable
to change symlink files' project ID just like uid/gid.

This patch try to reuse existed interface fchownat(),
use group id to set project ID if flag AT_FCHOWN_PROJID
passed in.

Also extend statx() calles to get symlink files' project
ID and inherit attribute.

Wang Shilong (8):
  fs: add support to change project ID
  ext4: support project ID in ext4_setattr()
  f2fs: support project ID in f2fs_setattr()
  xfs: support project ID in xfs_setattr()
  fs: add project support to statx
  ext4: support project in ext4_getattr()
  f2fs: support project in f2fs_getattr()
  xfs: support project in xfs_getattr()

 fs/attr.c                        | 26 +++++++++++++--
 fs/ext4/inode.c                  | 15 +++++++--
 fs/f2fs/file.c                   | 12 +++++--
 fs/open.c                        | 29 +++++++++++++----
 fs/quota/dquot.c                 | 23 ++++++++++++++
 fs/stat.c                        |  1 +
 fs/xfs/xfs_iops.c                | 54 ++++++++++++++++++++++++++------
 fs/xfs/xfs_linux.h               | 10 ++++++
 include/linux/fs.h               |  3 ++
 include/linux/quotaops.h         |  9 ++++++
 include/linux/stat.h             |  2 ++
 include/uapi/linux/fcntl.h       |  1 +
 include/uapi/linux/stat.h        |  8 +++--
 tools/include/uapi/linux/fcntl.h |  1 +
 tools/include/uapi/linux/stat.h  |  8 +++--
 15 files changed, 175 insertions(+), 27 deletions(-)

Comments

Dave Chinner March 3, 2019, 9:11 p.m. UTC | #1
On Fri, Mar 01, 2019 at 11:05:33PM +0900, Wang Shilong wrote:
> From: Wang Shilong <wshilong@ddn.com>
> 
> Currently, Filesystem use FS_IOC_FS_SETXATTR ioctl
> to change project ID of file. However we don't
> support ioctl on symlink files, and it is desirable
> to change symlink files' project ID just like uid/gid.
> 
> This patch try to reuse existed interface fchownat(),
> use group id to set project ID if flag AT_FCHOWN_PROJID
> passed in.
> 
> Also extend statx() calles to get symlink files' project
> ID and inherit attribute.

I'll mention the generic book-keeping stuff here:

- Series needs to be cc'd to linux-api@vger.kernel.org
- commit messages should be formatted similar to email. i.e. line
  wrap at 68-72 columns, not 50
- all of the patches have duplicate "From:" lines in the commit
  message.
- most of the patches are missing commit messages.

Cheers,

Dave.