[0/9] xfs: make buffer functions return error codes

Message ID	157910781961.2028217.1250106765923436515.stgit@magnolia (mailing list archive)
Headers	show Return-Path: <SRS0=S7Al=3E=vger.kernel.org=linux-xfs-owner@kernel.org> Subject: [PATCH 0/9] xfs: make buffer functions return error codes From: "Darrick J. Wong" <darrick.wong@oracle.com> To: darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org, hch@infradead.org Date: Wed, 15 Jan 2020 09:03:39 -0800 Message-ID: <157910781961.2028217.1250106765923436515.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk
Series	xfs: make buffer functions return error codes \| expand [0/9] xfs: make buffer functions return error codes [1/9] xfs: make xfs_buf_alloc return an error code [2/9] xfs: make xfs_buf_read return an error code [3/9] xfs: make xfs_buf_get return an error code [4/9] xfs: make xfs_buf_get_uncached return an error code [5/9] xfs: make xfs_buf_read_map return an error code [6/9] xfs: make xfs_buf_get_map return an error code [7/9] xfs: make xfs_trans_get_buf_map return an error code [8/9] xfs: make xfs_trans_get_buf return an error code [9/9] xfs: make xfs_btree_get_buf functions return an error code

Message ID

157910781961.2028217.1250106765923436515.stgit@magnolia (mailing list archive)

Headers

Subject: [PATCH 0/9] xfs: make buffer functions return error codes
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Date: Wed, 15 Jan 2020 09:03:39 -0800
Message-ID: <157910781961.2028217.1250106765923436515.stgit@magnolia>
User-Agent: StGit/0.17.1-dirty
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-xfs-owner@vger.kernel.org
Precedence: bulk

Series

xfs: make buffer functions return error codes | expand

Message

Darrick J. Wong Jan. 15, 2020, 5:03 p.m. UTC

Hi all,

Let's fix all the xfs read/get buffer functions to return the usual
integer error codes and pass the buffer pointer as a out-argument.  This
makes it so that we can return useful error output instead of making
callers infer ENOMEM or EAGAIN or whatever other reality they crave from
the NULL pointer that they get when things don't go perfectly.

FWIW, all XBF_TRYLOCK callers must now trigger retries if they receive
EAGAIN.  This may lead to a slight behavioral change in that TRYLOCK
callers will no longer retry for things like ENOMEM, though I didn't see
any obvious changes in user-visible behavior when running fstests.

This has been lightly tested with fstests.  Enjoy!
Comments and questions are, as always, welcome.

--D