From patchwork Sun Jun 13 17:19:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12317799 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16262C48BCF for ; Sun, 13 Jun 2021 17:19:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D733A61284 for ; Sun, 13 Jun 2021 17:19:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbhFMRV6 (ORCPT ); Sun, 13 Jun 2021 13:21:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:41132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbhFMRV6 (ORCPT ); Sun, 13 Jun 2021 13:21:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3123761107; Sun, 13 Jun 2021 17:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623604797; bh=zFjmtF3LyB1hJQZywVmlXBt3FZeALPwJ7UCa/8mFQqU=; h=Subject:From:To:Cc:Date:From; b=jipwaBFGDydWd8pOnNKCI6putaxNuW34erCIOZ34xXfJrmB1JkKXfKEz5RjBIK6nf mSfUOGCommRKlyRCODnRgfZXgjdbHa/pribEY2An1845gSPGUHv/b3NGeMzD+3IwwR FXJJYJrKQNEtn2cqBytS/OjOj1PB8DnmsGSsqGMF5owA6BRWY2Vrk2lq+KVuO6P8In Mwj0s1w9VbPqBHzR09xHD0erAPnF7S+2m31H+l/YvTQJXRgxtUz02Yafltbu+eJq7i 9BAlehchfW9qFxrGeipyYHvXK0a1jnxMFKd9QDes30hbJcTA3CGYFGbctXzIP2z/zV lsUs02LQaZjaA== Subject: [PATCHSET v7 00/16] xfs: deferred inode inactivation From: "Darrick J. Wong" To: djwong@kernel.org Cc: Dave Chinner , Christoph Hellwig , linux-xfs@vger.kernel.org, david@fromorbit.com, hch@infradead.org, bfoster@redhat.com Date: Sun, 13 Jun 2021 10:19:56 -0700 Message-ID: <162360479631.1530792.17147217854887531696.stgit@locust> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hi all, This patch series implements deferred inode inactivation. Inactivation is what happens when an open file loses its last incore reference: if the file has speculative preallocations, they must be freed, and if the file is unlinked, all forks must be truncated, and the inode marked freed in the inode chunk and the inode btrees. Currently, all of this activity is performed in frontend threads when the last in-memory reference is lost and/or the vfs decides to drop the inode. Three complaints stem from this behavior: first, that the time to unlink (in the worst case) depends on both the complexity of the directory as well as the the number of extents in that file; second, that deleting a directory tree is inefficient and seeky because we free the inodes in readdir order, not disk order; and third, the upcoming online repair feature needs to be able to xfs_irele while scanning a filesystem in transaction context. It cannot perform inode inactivation in this context because xfs does not support nested transactions. The implementation will be familiar to those who have studied how XFS scans for reclaimable in-core inodes -- we create a couple more inode state flags to mark an inode as needing inactivation and being in the middle of inactivation. When inodes need inactivation, we set NEED_INACTIVE in iflags, set the INACTIVE radix tree tag, and schedule a deferred work item. The deferred worker runs in an unbounded workqueue, scanning the inode radix tree for tagged inodes to inactivate, and performing all the on-disk metadata updates. Once the inode has been inactivated, it is left in the reclaim state and the background reclaim worker (or direct reclaim) will get to it eventually. Doing the inactivations from kernel threads solves the first problem by constraining the amount of work done by the unlink() call to removing the directory entry. It solves the third problem by moving inactivation to a separate process. Because the inactivations are done in order of inode number, we solve the second problem by performing updates in (we hope) disk order. This also decreases the amount of time it takes to let go of an inode cluster if we're deleting entire directory trees. There are three big warts I can think of in this series: first, because the actual freeing of nlink==0 inodes is now done in the background, this means that the system will be busy making metadata updates for some time after the unlink() call returns. This temporarily reduces available iops. Second, in order to retain the behavior that deleting 100TB of unshared data should result in a free space gain of 100TB, the statvfs and quota reporting ioctls wait for inactivation to finish, which increases the long tail latency of those calls. This behavior is, unfortunately, key to not introducing regressions in fstests. The third problem is that the deferrals keep memory usage higher for longer, reduce opportunities to throttle the frontend when metadata load is heavy, and the unbounded workqueues can create transaction storms. v1-v2: NYE patchbombs v3: rebase against 5.12-rc2 for submission. v4: combine the can/has eofblocks predicates, clean up incore inode tree walks, fix inobt deadlock v5: actually freeze the inode gc threads when we freeze the filesystem, consolidate the code that deals with inode tagging, and use foreground inactivation during quotaoff to avoid cycling dquots v6: rebase to 5.13-rc4, fix quotaoff not to require foreground inactivation, refactor to use inode walk goals, use atomic bitflags to control the scheduling of gc workers v7: simplify the inodegc worker, which simplifies how flushes work, break up the patch into smaller pieces, flush inactive inodes on syncfs to simplify freeze/ro-remount handling, separate inode selection filtering in iget, refactor inode recycling further, change gc delay to 100ms, decrease the gc delay when space or quota are low, move most of the destroy_inode logic to mark_reclaimable, get rid of the fallocate flush scan thing, get rid of polled flush mode If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below. This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=deferred-inactivation-5.14 --- Documentation/admin-guide/xfs.rst | 10 fs/xfs/libxfs/xfs_ag.c | 3 fs/xfs/libxfs/xfs_ag.h | 3 fs/xfs/scrub/common.c | 10 fs/xfs/xfs_globals.c | 5 fs/xfs/xfs_icache.c | 863 ++++++++++++++++++++++++++++++++----- fs/xfs/xfs_icache.h | 6 fs/xfs/xfs_inode.c | 64 +++ fs/xfs/xfs_inode.h | 21 + fs/xfs/xfs_itable.c | 42 ++ fs/xfs/xfs_iwalk.c | 33 + fs/xfs/xfs_linux.h | 1 fs/xfs/xfs_log_recover.c | 7 fs/xfs/xfs_mount.c | 38 +- fs/xfs/xfs_mount.h | 28 + fs/xfs/xfs_qm.c | 28 + fs/xfs/xfs_qm_syscalls.c | 8 fs/xfs/xfs_quota.h | 2 fs/xfs/xfs_super.c | 110 +++-- fs/xfs/xfs_sysctl.c | 9 fs/xfs/xfs_sysctl.h | 1 fs/xfs/xfs_trace.h | 63 ++- fs/xfs/xfs_trans.c | 5 23 files changed, 1163 insertions(+), 197 deletions(-)