[PATCHSET,0/4] xfs: last bit of LARP and other fixes for 5.19

Message

Darrick J. Wong May 22, 2022, 3:27 p.m. UTC

Hi all,

Here's one last round of fixes for UAF bugs and memory leaks that I
found while testing the logged xattr code.  The first patch is a bug for
a memory leak in quotacheck that has been popping up here and there for
the last 10 years, and the rest are previously seen patches rebased
against where I /think/ Dave's current internal testing tree is right
now, based on his request on IRC Friday night.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=larp-fixes-5.19
---
 fs/xfs/libxfs/xfs_attr.c  |    6 +
 fs/xfs/libxfs/xfs_attr.h  |   11 ++
 fs/xfs/libxfs/xfs_defer.c |   59 ++++++++--
 fs/xfs/xfs_attr_item.c    |  268 +++++++++++++++++++++++++--------------------
 fs/xfs/xfs_attr_item.h    |   13 ++
 fs/xfs/xfs_log.h          |    7 +
 fs/xfs/xfs_qm.c           |    9 +-
 7 files changed, 235 insertions(+), 138 deletions(-)

Comments

Dave Chinner May 22, 2022, 10:59 p.m. UTC | #1

On Sun, May 22, 2022 at 08:27:46AM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> Here's one last round of fixes for UAF bugs and memory leaks that I
> found while testing the logged xattr code.  The first patch is a bug for
> a memory leak in quotacheck that has been popping up here and there for
> the last 10 years, and the rest are previously seen patches rebased
> against where I /think/ Dave's current internal testing tree is right
> now, based on his request on IRC Friday night.

The merge window has opened now, so I'm going to pull the critical
LARP bug fixes out of this (patch 2 and 3) because they are the ones
I've been waiting on to publish for-next before an initial pull
request.  I'll plan the rest for 2nd late merge window pull request
once we've got the main bulk merged later this week.

Cheers,

Dave.