[PATCHSET,v24.0,0/6] xfs_scrub: improve warnings about difficult repairs

Message ID	167243869365.715119.17881025524336922669.stgit@magnolia (mailing list archive)
Headers	show Return-Path: <linux-xfs-owner@vger.kernel.org> Subject: [PATCHSET v24.0 0/6] xfs_scrub: improve warnings about difficult repairs From: "Darrick J. Wong" <djwong@kernel.org> To: cem@kernel.org, djwong@kernel.org Cc: linux-xfs@vger.kernel.org Date: Fri, 30 Dec 2022 14:18:13 -0800 Message-ID: <167243869365.715119.17881025524336922669.stgit@magnolia> In-Reply-To: <Y69Unb7KRM5awJoV@magnolia> References: <Y69Unb7KRM5awJoV@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk
Series	xfs_scrub: improve warnings about difficult repairs \| expand [PATCHSET,v24.0,0/6] xfs_scrub: improve warnings about difficult repairs [1/6] xfs_scrub: collapse trivial superblock scrub helpers [2/6] xfs_scrub: get rid of trivial fs metadata scanner helpers [3/6] xfs_scrub: split up the mustfix repairs and difficulty assessment functions [4/6] xfs_scrub: add missing repair types to the mustfix and difficulty assessment [5/6] xfs_scrub: any inconsistency in metadata should trigger difficulty warnings [6/6] xfs_scrub: warn about difficult repairs to rt and quota metadata

Message ID

167243869365.715119.17881025524336922669.stgit@magnolia (mailing list archive)

Headers

Subject: [PATCHSET v24.0 0/6] xfs_scrub: improve warnings about difficult
 repairs
From: "Darrick J. Wong" <djwong@kernel.org>
To: cem@kernel.org, djwong@kernel.org
Cc: linux-xfs@vger.kernel.org
Date: Fri, 30 Dec 2022 14:18:13 -0800
Message-ID: <167243869365.715119.17881025524336922669.stgit@magnolia>
In-Reply-To: <Y69Unb7KRM5awJoV@magnolia>
References: <Y69Unb7KRM5awJoV@magnolia>
User-Agent: StGit/0.19
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Series

xfs_scrub: improve warnings about difficult repairs | expand

Message

Darrick J. Wong Dec. 30, 2022, 10:18 p.m. UTC

Hi all,

While I was poking through the QA results for xfs_scrub, I noticed that
it doesn't warn the user when the primary and secondary realtime
metadata are so out of whack that the chances of a successful repair are
not so high.  I decided that it was worth refactoring the scrub code a
bit so that we could warn the user about these types of things, and
ended up refactoring unnecessary helpers out of existence and fixing
other reporting gaps.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=scrub-better-repair-warnings
---
 scrub/phase1.c |    2 +-
 scrub/phase2.c |   53 +++++++++++++++++++++++++++++++++--------------------
 scrub/phase4.c |    9 +++++----
 scrub/phase5.c |   14 ++++++--------
 scrub/repair.c |   47 ++++++++++++++++++++++++++++++++++++-----------
 scrub/repair.h |   10 +++++++---
 scrub/scrub.c  |   52 +---------------------------------------------------
 scrub/scrub.h  |    7 ++-----
 8 files changed, 91 insertions(+), 103 deletions(-)