mbox series

[PATCHSET,v25.0,0/2] xfs: miscellaneous repair tweaks

Message ID 168506057223.3730021.15237048674614006148.stgit@frogsfrogsfrogs (mailing list archive)
Headers show
Series xfs: miscellaneous repair tweaks | expand

Message

Darrick J. Wong May 26, 2023, 12:29 a.m. UTC 
Hi all,

Before we start adding online repair functionality, there's a few tweaks
that I'd like to make to the common repair code.  First is a fix to the
integration between repair and the health status code that was
interfering with repair re-evaluations.  Second is a minor tweak to the
sole existing repair functions to make one last check that the user
hasn't terminated the calling process before we start writing to the
filesystem.  This is a pattern that will repeat throughout the rest of
the repair functions.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-tweaks
---
 fs/xfs/scrub/agheader_repair.c |   16 ++++++++++++++++
 fs/xfs/scrub/health.c          |   10 ++++++++++
 2 files changed, 26 insertions(+)

Comments

Dave Chinner June 22, 2023, 3:13 a.m. UTC | #1 
On Thu, May 25, 2023 at 05:29:27PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> Before we start adding online repair functionality, there's a few tweaks
> that I'd like to make to the common repair code.  First is a fix to the
> integration between repair and the health status code that was
> interfering with repair re-evaluations.  Second is a minor tweak to the
> sole existing repair functions to make one last check that the user
> hasn't terminated the calling process before we start writing to the
> filesystem.  This is a pattern that will repeat throughout the rest of
> the repair functions.
> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> kernel git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-tweaks
> ---
>  fs/xfs/scrub/agheader_repair.c |   16 ++++++++++++++++
>  fs/xfs/scrub/health.c          |   10 ++++++++++
>  2 files changed, 26 insertions(+)

LGTM.

Reviewed-by: Dave Chinner <dchinner@redhat.com>