Message ID | 169049623967.921701.643201943864960800.stgit@frogsfrogsfrogs (mailing list archive) |
---|---|
Headers | show |
Series | xfs: add usage counters for scrub | expand |
On Thu, Jul 27, 2023 at 03:19:19PM -0700, Darrick J. Wong wrote: > Hi all, > > This series introduces simple usage and performance counters for the > online fsck subsystem. The goal here is to enable developers and > sysadmins to look at summary counts of how many objects were checked and > repaired; what the outcomes were; and how much time the kernel has spent > on these operations. The counter file is exposed in debugfs because > that's easier than cramming it into the device model, and debugfs > doesn't have rules against complex file contents, unlike sysfs. I wish we could just put these in sysfs with all the other per-mount stats files we have. It's just stupid to have to put them somewhere else because we want to put all the stats in a single file and so grab them with a single read operation... Other than that, this series looks fine. Reviewed-by: Dave Chinner <dchinner@redhat.com>