[PATCHSET,0/1] xfs: fix EFI recovery livelocks

Message

Darrick J. Wong Aug. 29, 2023, 11:10 p.m. UTC

Hi all,

This series fixes a customer-reported transaction reservation bug
introduced ten years ago that could result in livelocks during log
recovery.  Log intent item recovery single-steps each step of a deferred
op chain, which means that each step only needs to allocate one
transaction's worth of space in the log, not an entire chain all at
once.  This single-stepping is critical to unpinning the log tail since
there's nobody else to do it for us.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been lightly tested with fstests.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=fix-efi-recovery-6.6
---
 fs/xfs/libxfs/xfs_log_recover.h |   22 ++++++++++++++++++++++
 fs/xfs/xfs_attr_item.c          |    7 ++++---
 fs/xfs/xfs_bmap_item.c          |    4 +++-
 fs/xfs/xfs_extfree_item.c       |    4 +++-
 fs/xfs/xfs_refcount_item.c      |    6 ++++--
 fs/xfs/xfs_rmap_item.c          |    6 ++++--
 6 files changed, 40 insertions(+), 9 deletions(-)