mbox series

[PATCHSET,v27.0,0/2] fstests: FIEXCHANGE is now an XFS ioctl

Message ID 169947992096.220003.8427995158013553083.stgit@frogsfrogsfrogs (mailing list archive)
Headers show
Series fstests: FIEXCHANGE is now an XFS ioctl | expand

Message

Darrick J. Wong Nov. 8, 2023, 9:45 p.m. UTC 
Hi all,

Minor amendments to the fstests code now that we've taken FIEXCHANGE
private to XFS.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been running on the djcloud for months with no problems.  Enjoy!
Comments and questions are, as always, welcome.

--D

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=private-fiexchange
---
 common/xfs            |    2 +-
 configure.ac          |    2 +-
 doc/group-names.txt   |    2 +-
 include/builddefs.in  |    2 +-
 ltp/Makefile          |    4 ++--
 ltp/fsstress.c        |   10 +++++-----
 ltp/fsx.c             |   20 ++++++++++----------
 m4/package_libcdev.m4 |   19 -------------------
 m4/package_xfslibs.m4 |   14 ++++++++++++++
 src/Makefile          |    4 ++++
 src/fiexchange.h      |   44 ++++++++++++++++++++++----------------------
 src/global.h          |    4 +---
 src/vfs/Makefile      |    4 ++++
 tests/generic/709     |    2 +-
 tests/generic/710     |    2 +-
 tests/generic/711     |    2 +-
 tests/generic/712     |    2 +-
 tests/generic/713     |    4 ++--
 tests/generic/714     |    4 ++--
 tests/generic/715     |    4 ++--
 tests/generic/716     |    2 +-
 tests/generic/717     |    2 +-
 tests/generic/718     |    2 +-
 tests/generic/719     |    2 +-
 tests/generic/720     |    2 +-
 tests/generic/722     |    4 ++--
 tests/generic/723     |    6 +++---
 tests/generic/724     |    6 +++---
 tests/generic/725     |    2 +-
 tests/generic/726     |    2 +-
 tests/generic/727     |    2 +-
 tests/xfs/122.out     |    1 +
 tests/xfs/789         |    2 +-
 tests/xfs/790         |    2 +-
 tests/xfs/791         |    6 +++---
 tests/xfs/792         |    2 +-
 36 files changed, 99 insertions(+), 97 deletions(-)

Comments

Christoph Hellwig Nov. 9, 2023, 5:21 a.m. UTC | #1 
On Wed, Nov 08, 2023 at 01:45:20PM -0800, Darrick J. Wong wrote:
> This has been running on the djcloud for months with no problems.  Enjoy!
> Comments and questions are, as always, welcome.

Isn't the branch all new?

Anyway, this fixes skipping the tests when not supported, and runs them
fine when supported:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Christoph Hellwig <hch@lst.de>

although I wonder a bit if keeping functionality not actually supported
upstream in upstream xfstests is such a good idea.  Keeping it in
a development branch for the feature seems more flexible to me.  I guess
there is no point doing a forth and back for this one now, but maybe
should be more careful in the future.
Darrick J. Wong Nov. 10, 2023, 4:48 a.m. UTC | #2 
On Thu, Nov 09, 2023 at 06:21:06AM +0100, Christoph Hellwig wrote:
> On Wed, Nov 08, 2023 at 01:45:20PM -0800, Darrick J. Wong wrote:
> > This has been running on the djcloud for months with no problems.  Enjoy!
> > Comments and questions are, as always, welcome.
> 
> Isn't the branch all new?
> 
> Anyway, this fixes skipping the tests when not supported, and runs them
> fine when supported:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christoph Hellwig <hch@lst.de>

Thanks!

> although I wonder a bit if keeping functionality not actually supported
> upstream in upstream xfstests is such a good idea.  Keeping it in
> a development branch for the feature seems more flexible to me.  I guess
> there is no point doing a forth and back for this one now, but maybe
> should be more careful in the future.

At the time Zorro proposed merging all the remaining online fsck tests I
didn't think review of the kernel patches was going to continue on for
years.

--D