[PATCHSET,v2,0/9] xfs: continue removing defer item boilerplate

Message ID	170191562370.1133395.5436656395520338293.stgit@frogsfrogsfrogs (mailing list archive)
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B9F21845 for <linux-xfs@vger.kernel.org>; Thu, 7 Dec 2023 02:22:58 +0000 (UTC) Date: Wed, 06 Dec 2023 18:22:56 -0800 Subject: [PATCHSET v2 0/9] xfs: continue removing defer item boilerplate From: "Darrick J. Wong" <djwong@kernel.org> To: chandanbabu@kernel.org, hch@lst.de, djwong@kernel.org Cc: linux-xfs@vger.kernel.org Message-ID: <170191562370.1133395.5436656395520338293.stgit@frogsfrogsfrogs> User-Agent: StGit/0.19 Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit
Series	xfs: continue removing defer item boilerplate \| expand [PATCHSET,v2,0/9] xfs: continue removing defer item boilerplate [1/9] xfs: don't set XFS_TRANS_HAS_INTENT_DONE when there's no ATTRD log item [2/9] xfs: hoist intent done flag setting to ->finish_item callsite [3/9] xfs: collapse the ->finish_item helpers [4/9] xfs: hoist ->create_intent boilerplate to its callsite [5/9] xfs: use xfs_defer_create_done for the relogging operation [6/9] xfs: clean out XFS_LI_DIRTY setting boilerplate from ->iop_relog [7/9] xfs: hoist xfs_trans_add_item calls to defer ops functions [8/9] xfs: collapse the ->create_done functions [9/9] xfs: move ->iop_relog to struct xfs_defer_op_type

Message ID

170191562370.1133395.5436656395520338293.stgit@frogsfrogsfrogs (mailing list archive)

Headers

Date: Wed, 06 Dec 2023 18:22:56 -0800
Subject: [PATCHSET v2 0/9] xfs: continue removing defer item boilerplate
From: "Darrick J. Wong" <djwong@kernel.org>
To: chandanbabu@kernel.org, hch@lst.de, djwong@kernel.org
Cc: linux-xfs@vger.kernel.org
Message-ID: <170191562370.1133395.5436656395520338293.stgit@frogsfrogsfrogs>
User-Agent: StGit/0.19
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Series

xfs: continue removing defer item boilerplate | expand

Message

Darrick J. Wong Dec. 7, 2023, 2:22 a.m. UTC

Hi all,

Now that we've restructured log intent item recovery to reconstruct the
incore deferred work state, apply further cleanups to that code to
remove boilerplate that is duplicated across all the _item.c files.
Having done that, collapse a bunch of trivial helpers to reduce the
overall call chain.  That enables us to refactor the relog code so that
the ->relog_item implementations only have to know how to format the
implementation-specific data encoded in an intent item and don't
themselves have to handle the log item juggling.

v2: pick up rvb tags

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been lightly tested with fstests.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=reconstruct-defer-cleanups-6.8
---
 fs/xfs/libxfs/xfs_defer.c  |   55 ++++++++++
 fs/xfs/libxfs/xfs_defer.h  |    3 +
 fs/xfs/xfs_attr_item.c     |  137 +++++++------------------
 fs/xfs/xfs_bmap_item.c     |  115 ++++++---------------
 fs/xfs/xfs_extfree_item.c  |  242 ++++++++++++++++----------------------------
 fs/xfs/xfs_refcount_item.c |  113 ++++++---------------
 fs/xfs/xfs_rmap_item.c     |  113 ++++++---------------
 fs/xfs/xfs_trans.h         |   10 --
 8 files changed, 284 insertions(+), 504 deletions(-)