mbox series

[v5,0/5] Try to squash metadump data leaks

Message ID 20181105213145.7560-1-stefanrin@gmail.com (mailing list archive)
Headers show
Series Try to squash metadump data leaks | expand

Message

Stefan Ring Nov. 5, 2018, 9:31 p.m. UTC
Another round... I'm starting to feel quite confident about it this time.

Since last time:

- Fixed the attribute corruption in the last patch.
- Changed the accidental 'a' and 'b' I had left in the code back to zeroes.
- Brought the flag for crc recalc a tiny bit more in line with the single_fsb code.
- Fixed the wrong control flow in the interim patch which duplicates a TODO comment in the code only to get rid of it in the next patch.


Stefan Ring (5):
  xfs_metadump: Extend data zapping to XFS_DIR{2,3}_LEAFN_MAGIC blocks
  xfs_metadump: Zap multi fsb blocks
  xfs_metadump: Zap freeindex blocks in directory inodes
  xfs_metadump: Zap unused space in inode btrees
  xfs_metadump: Zap dev inodes

 db/metadump.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 113 insertions(+), 15 deletions(-)

Comments

Stefan Ring Dec. 6, 2018, 5:04 p.m. UTC | #1
On Mon, Nov 5, 2018 at 10:32 PM Stefan Ring <stefanrin@gmail.com> wrote:
>
> Another round... I'm starting to feel quite confident about it this time.
>
> Since last time:
>
> - Fixed the attribute corruption in the last patch.
> - Changed the accidental 'a' and 'b' I had left in the code back to zeroes.
> - Brought the flag for crc recalc a tiny bit more in line with the single_fsb code.
> - Fixed the wrong control flow in the interim patch which duplicates a TODO comment in the code only to get rid of it in the next patch.
>
>
> Stefan Ring (5):
>   xfs_metadump: Extend data zapping to XFS_DIR{2,3}_LEAFN_MAGIC blocks
>   xfs_metadump: Zap multi fsb blocks
>   xfs_metadump: Zap freeindex blocks in directory inodes
>   xfs_metadump: Zap unused space in inode btrees
>   xfs_metadump: Zap dev inodes
>
>  db/metadump.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 113 insertions(+), 15 deletions(-)

Is this an appropriate time interval for pinging?
Eric Sandeen Dec. 6, 2018, 8:23 p.m. UTC | #2
On 12/6/18 11:04 AM, Stefan Ring wrote:
> On Mon, Nov 5, 2018 at 10:32 PM Stefan Ring <stefanrin@gmail.com> wrote:
>>
>> Another round... I'm starting to feel quite confident about it this time.
>>
>> Since last time:
>>
>> - Fixed the attribute corruption in the last patch.
>> - Changed the accidental 'a' and 'b' I had left in the code back to zeroes.
>> - Brought the flag for crc recalc a tiny bit more in line with the single_fsb code.
>> - Fixed the wrong control flow in the interim patch which duplicates a TODO comment in the code only to get rid of it in the next patch.
>>
>>
>> Stefan Ring (5):
>>   xfs_metadump: Extend data zapping to XFS_DIR{2,3}_LEAFN_MAGIC blocks
>>   xfs_metadump: Zap multi fsb blocks
>>   xfs_metadump: Zap freeindex blocks in directory inodes
>>   xfs_metadump: Zap unused space in inode btrees
>>   xfs_metadump: Zap dev inodes
>>
>>  db/metadump.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++-------
>>  1 file changed, 113 insertions(+), 15 deletions(-)
> 
> Is this an appropriate time interval for pinging?
> 

Yeah, this is back on my radar today as I try to assemble an xfsprogs-4.20.

Sorry for the delay, and thanks for the work.

-Eric