| Message ID | 20200715201253.171356-1-billodo@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | xfsprogs: xfs_quota error message and state reporting improvement | expand |
On 7/15/20 1:12 PM, Bill O'Donnell wrote: > > This patchset improves xfs_quota command error message output as well as > adding reporting for grace times and warning limits for state (u,g,p). > > Note that patches to xfstests to handle these changes will be forthcoming. > Also, patch 1 was originally submitted separately: > (xfsprogs: xfs_quota command error message improvement) > > patch 1 contains the command error message improvements. > patch 2 contains the warning limit reporting (originally SoB Darrick Wong). > patch 3 contains the additional state reporting of grace times for u,g,p. > > Comments appreciated. Thanks- > Bill Hi Bill - These look good and have reviews, but we need xfstests fixed up with filters now, multiple tests now have output that doesn't match expected, causing failures: xfs/106 - output mismatch (see /root/xfstests-dev/results//xfs/106.out.bad) --- tests/xfs/106.out 2017-08-28 12:17:34.950134054 -0400 +++ /root/xfstests-dev/results//xfs/106.out.bad 2020-07-30 13:34:26.889836623 -0400 @@ -102,7 +102,9 @@ Enforcement: OFF Inode: #[INO] (X blocks, Y extents) Blocks grace time: [3 days] +Blocks max warnings: 5 Inodes grace time: [3 days] +Inodes max warnings: 5 Realtime Blocks grace time: [7 days] Thanks, -Eric
On Thu, Jul 30, 2020 at 10:46:18AM -0700, Eric Sandeen wrote: > On 7/15/20 1:12 PM, Bill O'Donnell wrote: > > > > This patchset improves xfs_quota command error message output as well as > > adding reporting for grace times and warning limits for state (u,g,p). > > > > Note that patches to xfstests to handle these changes will be forthcoming. > > Also, patch 1 was originally submitted separately: > > (xfsprogs: xfs_quota command error message improvement) > > > > patch 1 contains the command error message improvements. > > patch 2 contains the warning limit reporting (originally SoB Darrick Wong). > > patch 3 contains the additional state reporting of grace times for u,g,p. > > > > Comments appreciated. Thanks- > > Bill > > Hi Bill - > > These look good and have reviews, but we need xfstests fixed up with filters > now, multiple tests now have output that doesn't match expected, causing > failures: I'll work on it. Thanks for the reminder. -Bill > > xfs/106 - output mismatch (see /root/xfstests-dev/results//xfs/106.out.bad) > --- tests/xfs/106.out 2017-08-28 12:17:34.950134054 -0400 > +++ /root/xfstests-dev/results//xfs/106.out.bad 2020-07-30 13:34:26.889836623 -0400 > @@ -102,7 +102,9 @@ > Enforcement: OFF > Inode: #[INO] (X blocks, Y extents) > Blocks grace time: [3 days] > +Blocks max warnings: 5 > Inodes grace time: [3 days] > +Inodes max warnings: 5 > Realtime Blocks grace time: [7 days] > > > Thanks, > -Eric >
On 7/30/20 10:52 AM, Bill O'Donnell wrote: > On Thu, Jul 30, 2020 at 10:46:18AM -0700, Eric Sandeen wrote: >> On 7/15/20 1:12 PM, Bill O'Donnell wrote: >>> >>> This patchset improves xfs_quota command error message output as well as >>> adding reporting for grace times and warning limits for state (u,g,p). >>> >>> Note that patches to xfstests to handle these changes will be forthcoming. >>> Also, patch 1 was originally submitted separately: >>> (xfsprogs: xfs_quota command error message improvement) >>> >>> patch 1 contains the command error message improvements. >>> patch 2 contains the warning limit reporting (originally SoB Darrick Wong). >>> patch 3 contains the additional state reporting of grace times for u,g,p. >>> >>> Comments appreciated. Thanks- >>> Bill >> >> Hi Bill - >> >> These look good and have reviews, but we need xfstests fixed up with filters >> now, multiple tests now have output that doesn't match expected, causing >> failures: > > I'll work on it. Thanks for the reminder. > -Bill Ah, sounds like Darrick has (sent?) some(?) patches for this already.... -Eric