mbox series

[0/4] Clean up xfs_attr_sf_entry

Message ID 20200831130423.136509-1-cmaiolino@redhat.com (mailing list archive)
Headers show
Series Clean up xfs_attr_sf_entry | expand


Carlos Maiolino Aug. 31, 2020, 1:04 p.m. UTC

this series has been suggested by Eric, and it's intended as a small clean up
for xfS_attr_sf_entry usage.

First patch changes the nameval array definition from 1 element to a
variable-size array. The array is already being used as a variable size array,
but by now, we need to subtract 1 from every time we use it.

Second patch just convert some macros to inline functions.

The remaining two patches are just 2 typedef cleanups that I think it's
appropriate since I'm already touching this code. I opted to leave the typedef
cleanups by last, since, if by any reason anybody think it's not worth it, both
patches can be simply discarded without needing to change any of the first 2.

All patches survived a few xfstests runs and the reproducer Eric shared on his
previous patch:

#touch file
#setfatt -n user.a file



Carlos Maiolino (4):
  xfs: Use variable-size array for nameval in xfs_attr_sf_entry
  xfs: Convert xfs_attr_sf macros to inline functions
  xfs: remove typedef xfs_attr_sf_entry_t
  xfs: Remove typedef xfs_attr_shortform_t

 fs/xfs/libxfs/xfs_attr.c      | 15 ++++++++++---
 fs/xfs/libxfs/xfs_attr_leaf.c | 42 +++++++++++++++++------------------
 fs/xfs/libxfs/xfs_attr_sf.h   | 27 +++++++++++++---------
 fs/xfs/libxfs/xfs_da_format.h |  6 ++---
 fs/xfs/xfs_attr_list.c        |  6 ++---
 fs/xfs/xfs_ondisk.h           | 12 +++++-----
 6 files changed, 60 insertions(+), 48 deletions(-)