mbox series

[v5,0/3] xfsprogs: consolidate stripe validation

Message ID 20201009052421.3328-1-hsiangkao@redhat.com (mailing list archive)
Headers show
Series xfsprogs: consolidate stripe validation | expand

Message

Gao Xiang Oct. 9, 2020, 5:24 a.m. UTC 
v4: https://lore.kernel.org/r/20201007140402.14295-1-hsiangkao@aol.com

Hi,

This is another approach suggested by Eric in the reply of v3
(if I understand correctly), which also attempts to use
i18n-enabled xfsprogs xfs_notice() to error out sanity check
failure suggested by Dave on IRC.

kernel side of [PATCH 2/3]
https://lore.kernel.org/r/20201009050546.32174-1-hsiangkao@redhat.com

Thanks,
Gao Xiang

Changes since v4:
 - [2/3] stretch columns for commit message (Darrick);
 - [2/3] add a comment to hasdalign check (Darrick);
 - [2/3] break old sunit / swidth != 0 check into two
         seperate checks (Darrick);
 - [2/3] update an error message description (Darrick);
 - [2/3] use bytes for sunit / swidth representation,
         so users can see values in the unique unit.
 - [3/3] introduce a userspace wrapper
         libxfs_validate_stripe_factors (Darrick).

Gao Xiang (3):
  libxfs: allow i18n to xfs printk
  xfs: introduce xfs_validate_stripe_factors()
  mkfs: make use of xfs_validate_stripe_factors()

 libxfs/libxfs_api_defs.h |  1 +
 libxfs/libxfs_priv.h     |  8 ++---
 libxfs/xfs_sb.c          | 65 +++++++++++++++++++++++++++++++++-------
 libxfs/xfs_sb.h          |  3 ++
 mkfs/xfs_mkfs.c          | 23 +++++---------
 5 files changed, 69 insertions(+), 31 deletions(-)