mbox series

[0/9] xfs: rework log quiesce to cover the log

Message ID 20210106174127.805660-1-bfoster@redhat.com (mailing list archive)
Headers show
Series xfs: rework log quiesce to cover the log | expand


Brian Foster Jan. 6, 2021, 5:41 p.m. UTC
Hi all,

This series modifies the log quiesce code path to cover the log instead
of mark it clean and separates the latter into a distinct step. This
allows existing users to determine whether to quiesce (i.e. cover) or
clean the log depending on the operation, and thus avoids the need for
contexts like freeze to have to redirty the log after a quiesce.

By covering the log on quiesce, we can also fold final superblock
updates (i.e., lazy superblock counters) into the quiesce sequence
because covering uses the same superblock transaction as the explicit
superblock updates. This same approach can accommodate (probably with
some additional tweaks) future final superblock updates, such as for log
feature compatibility bit management when the log is cleared of
incompatible items.

Patch 1 is a repost of a lazy sb accounting bug fix that was previously
sent (included here as a dependency). Patches 2-3 make some preliminary
cleanups. Patch 4 injects log covering into the log quiesce sequence.
Patches 5-6 fold the existing lazy superblock accounting update into
quiesce. Patches 7-8 make some final refactoring cleanups (these two
patches could probably be squashed now that I look at them again).
Finally, patch 9 updates fs freeze to cover the log instead of cleaning
and redirtying it.

Thoughts, reviews, flames appreciated.


Brian Foster (9):
  xfs: sync lazy sb accounting on quiesce of read-only mounts
  xfs: lift writable fs check up into log worker task
  xfs: separate log cleaning from log quiesce
  xfs: cover the log during log quiesce
  xfs: don't reset log idle state on covering checkpoints
  xfs: fold sbcount quiesce logging into log covering
  xfs: remove duplicate wq cancel and log force from attr quiesce
  xfs: remove xfs_quiesce_attr()
  xfs: cover the log on freeze instead of cleaning it

 fs/xfs/xfs_log.c   | 122 +++++++++++++++++++++++++++++++++++++--------
 fs/xfs/xfs_log.h   |   4 +-
 fs/xfs/xfs_mount.c |  34 +------------
 fs/xfs/xfs_mount.h |   1 -
 fs/xfs/xfs_super.c |  38 +-------------
 5 files changed, 106 insertions(+), 93 deletions(-)