[v18,00/11] Delay Ready Attributes

Message

Allison Henderson April 28, 2021, 8:09 a.m. UTC

Hi all,

This set is a subset of a larger series for Dealyed Attributes. Which is a
subset of a yet larger series for parent pointers. Delayed attributes allow
attribute operations (set and remove) to be logged and committed in the same
way that other delayed operations do. This allows more complex operations (like
parent pointers) to be broken up into multiple smaller transactions. To do
this, the existing attr operations must be modified to operate as a delayed
operation.  This means that they cannot roll, commit, or finish transactions.
Instead, they return -EAGAIN to allow the calling function to handle the
transaction.  In this series, we focus on only the delayed attribute portion.
We will introduce parent pointers in a later set.

The set as a whole is a bit much to digest at once, so I usually send out the
smaller sub series to reduce reviewer burn out.  But the entire extended series
is visible through the included github links.

Updates since v17: Mostly just review feed back from the previous revision.
I've tracked changes below to help reviews recall the changes discussed

xfs: Add xfs_attr_node_remove_name
   Renamed xfs_attr_node_remove_cleanup to xfs_attr_node_remove_name

xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
  Added extra reval handling in xfs_attr_node_addname

xfs: Add delay ready attr remove routines
  Applied Brians patch for comment clean up
  Fixed xfs_attr_node_removename_setup return code
  Renamed XFS_DAS_CLNUP to XFS_DAS_RM_NAME.  Diagram updated
  Removed unneeded error handling in xfs_attr_remove_iter
  Fixed error handling in xfs_attr_rmtval_remove
  Rebase updates

xfs: Add delay ready attr set routines
  Applied Brians patch for comment clean up
  Rebase updates

This series can be viewed on github here:
https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_v18

As well as the extended delayed attribute and parent pointer series:
https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_v18_extended

And the test cases:
https://github.com/allisonhenderson/xfs_work/tree/pptr_xfstestsv3

In order to run the test cases, you will need have the corresponding xfsprogs
changes as well.  Which can be found here:
https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_xfsprogs_v18
https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_xfsprogs_v18_extended

To run the xfs attributes tests run:
check -g attr

To run as delayed attributes run:
export MOUNT_OPTIONS="-o delattr"
check -g attr

To run parent pointer tests:
check -g parent

I've also made the corresponding updates to the user space side as well, and ported anything
they need to seat correctly.

Questions, comment and feedback appreciated! 

Thanks all!
Allison  

Allison Henderson (11):
  xfs: Reverse apply 72b97ea40d
  xfs: Add xfs_attr_node_remove_name
  xfs: Hoist xfs_attr_set_shortform
  xfs: Add helper xfs_attr_set_fmt
  xfs: Separate xfs_attr_node_addname and
    xfs_attr_node_addname_clear_incomplete
  xfs: Add helper xfs_attr_node_addname_find_attr
  xfs: Hoist xfs_attr_node_addname
  xfs: Hoist xfs_attr_leaf_addname
  xfs: Hoist node transaction handling
  xfs: Add delay ready attr remove routines
  xfs: Add delay ready attr set routines

 fs/xfs/libxfs/xfs_attr.c        | 897 ++++++++++++++++++++++++----------------
 fs/xfs/libxfs/xfs_attr.h        | 401 ++++++++++++++++++
 fs/xfs/libxfs/xfs_attr_leaf.c   |   2 +-
 fs/xfs/libxfs/xfs_attr_remote.c | 126 ++++--
 fs/xfs/libxfs/xfs_attr_remote.h |   7 +-
 fs/xfs/xfs_attr_inactive.c      |   2 +-
 fs/xfs/xfs_trace.h              |   2 -
 7 files changed, 1031 insertions(+), 406 deletions(-)