[RFC,0/2] xfsprogs: add error tags for log attribute replay test

Message

Catherine Hoang Nov. 11, 2021, 12:11 a.m. UTC

Hi all,

These are the corresponding userspace changes for the new log attribute replay
test. These are built on top of Allison’s logged attribute patch sets, which can
be viewed here:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v25_extended

This set adds the new error tags leaf_split and leaf_to_node, which are used to
inject errors in the tests. 

Suggestions and feedback are appreciated!

Catherine

Catherine Hoang (2):
  xfsprogs: add leaf split error tag
  xfsprogs: add leaf to node error tag

 io/inject.c            | 2 ++
 libxfs/xfs_attr_leaf.c | 5 +++++
 libxfs/xfs_da_btree.c  | 5 +++++
 libxfs/xfs_errortag.h  | 6 +++++-
 4 files changed, 17 insertions(+), 1 deletion(-)

Comments

Allison Henderson Nov. 11, 2021, 1:37 a.m. UTC | #1

Hi Catherine,

These new tags look good to me.  If folks like new testcase I'll be 
happy to add these new tags to the larger log attr set.  You can add my 
rvb to these four error tag patches.

Reviewed-by: Allison Henderson <[e-mail]>

Thanks!
Allison


On 11/10/21 5:11 PM, Catherine Hoang wrote:
> Hi all,
> 
> These are the corresponding userspace changes for the new log attribute replay
> test. These are built on top of Allison’s logged attribute patch sets, which can
> be viewed here:
> https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v25_extended
> 
> This set adds the new error tags leaf_split and leaf_to_node, which are used to
> inject errors in the tests.
> 
> Suggestions and feedback are appreciated!
> 
> Catherine
> 
> Catherine Hoang (2):
>    xfsprogs: add leaf split error tag
>    xfsprogs: add leaf to node error tag
> 
>   io/inject.c            | 2 ++
>   libxfs/xfs_attr_leaf.c | 5 +++++
>   libxfs/xfs_da_btree.c  | 5 +++++
>   libxfs/xfs_errortag.h  | 6 +++++-
>   4 files changed, 17 insertions(+), 1 deletion(-)
>