mbox series

[RFC,v3,0/2] xfsprogs: add error tags for log attribute replay test

Message ID 20220201171755.22651-1-catherine.hoang@oracle.com (mailing list archive)
Headers show
Series xfsprogs: add error tags for log attribute replay test | expand

Message

Catherine Hoang Feb. 1, 2022, 5:17 p.m. UTC
Hi all,

These are the corresponding userspace changes for the new log attribute
replay test. These are built on top of Allison’s logged attribute patch
sets, which can be viewed here:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v26_extended

This set adds the new error tags da_leaf_split and larp_leaf_to_node,
which are used to inject errors in the tests. 

v2->v3:
Rename larp_leaf_split to da_leaf_split

Suggestions and feedback are appreciated!

Catherine


Catherine Hoang (2):
  xfsprogs: add leaf split error tag
  xfsprogs: add leaf to node error tag

 io/inject.c            | 2 ++
 libxfs/xfs_attr_leaf.c | 5 +++++
 libxfs/xfs_da_btree.c  | 3 +++
 libxfs/xfs_errortag.h  | 6 +++++-
 4 files changed, 15 insertions(+), 1 deletion(-)

Comments

Darrick J. Wong Feb. 1, 2022, 8:06 p.m. UTC | #1
On Tue, Feb 01, 2022 at 05:17:53PM +0000, Catherine Hoang wrote:
> Hi all,
> 
> These are the corresponding userspace changes for the new log attribute
> replay test. These are built on top of Allison’s logged attribute patch
> sets, which can be viewed here:
> https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v26_extended
> 
> This set adds the new error tags da_leaf_split and larp_leaf_to_node,
> which are used to inject errors in the tests. 
> 
> v2->v3:
> Rename larp_leaf_split to da_leaf_split

With the XFS_ERRTAG_LARP_LEAF_TO_NODE -> XFS_ERRTAG_ATTR_LEAF_TO_NODE
change made, you can add:

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

For the whole series.

--D

> 
> Suggestions and feedback are appreciated!
> 
> Catherine
> 
> 
> Catherine Hoang (2):
>   xfsprogs: add leaf split error tag
>   xfsprogs: add leaf to node error tag
> 
>  io/inject.c            | 2 ++
>  libxfs/xfs_attr_leaf.c | 5 +++++
>  libxfs/xfs_da_btree.c  | 3 +++
>  libxfs/xfs_errortag.h  | 6 +++++-
>  4 files changed, 15 insertions(+), 1 deletion(-)
> 
> -- 
> 2.25.1
>
Catherine Hoang Feb. 1, 2022, 10:05 p.m. UTC | #2
> On Feb 1, 2022, at 12:06 PM, Darrick J. Wong <djwong@kernel.org> wrote:
> 
> On Tue, Feb 01, 2022 at 05:17:53PM +0000, Catherine Hoang wrote:
>> Hi all,
>> 
>> These are the corresponding userspace changes for the new log attribute
>> replay test. These are built on top of Allison’s logged attribute patch
>> sets, which can be viewed here:
>> https://urldefense.com/v3/__https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v26_extended__;!!ACWV5N9M2RV99hQ!e2WVNIakDohiZPdPKi-YzSjukd97AcL-PAGBteXwqTgvz2mtn0jADrAQbq-Js7j8A1E$ 
>> 
>> This set adds the new error tags da_leaf_split and larp_leaf_to_node,
>> which are used to inject errors in the tests. 
>> 
>> v2->v3:
>> Rename larp_leaf_split to da_leaf_split
> 
> With the XFS_ERRTAG_LARP_LEAF_TO_NODE -> XFS_ERRTAG_ATTR_LEAF_TO_NODE
> change made, you can add:
> 
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> 
> For the whole series.
> 
> --D

Sure, will change that. Thanks!
> 
>> 
>> Suggestions and feedback are appreciated!
>> 
>> Catherine
>> 
>> 
>> Catherine Hoang (2):
>>  xfsprogs: add leaf split error tag
>>  xfsprogs: add leaf to node error tag
>> 
>> io/inject.c            | 2 ++
>> libxfs/xfs_attr_leaf.c | 5 +++++
>> libxfs/xfs_da_btree.c  | 3 +++
>> libxfs/xfs_errortag.h  | 6 +++++-
>> 4 files changed, 15 insertions(+), 1 deletion(-)
>> 
>> -- 
>> 2.25.1
>>