[5.10,v2,0/5] xfs fixes for 5.10.y (part 1)

Message

Amir Goldstein May 27, 2022, 1:02 p.m. UTC

Hi Greg and Shasha!

It has been a while since you heard from xfs team.

We are trying to change things and get xfs fixes flowing to stable
again. Crossing my fingers that we will make this last this time :)

Please see this message from Darrick [4] about xfs stable plans.
My team will be focusing on 5.10.y and Ted and Leah's team will be
focusing on 5.15.y at this time.

This v2 is being sent to stable after testing and after v1 was sent
for review of the xfs list [5].

v2 includes an extra patch that Christoph has backported and tested
and was going to send to stable.

Please see my cover letter to xfs with more details about my plans
for 5.10.y below:

Hi all!

During LSFMM 2022, I have had an opportunity to speak with developers
from several different companies that showed interest in collaborating
on the effort of improving the state of xfs code in LTS kernels.

I would like to kick-off this effort for the 5.10 LTS kernel, in the
hope that others will join me in the future to produce a better common
baseline for everyone to build on.

This is the first of 6 series of stable patch candidates that
I collected from xfs releases v5.11..v5.18 [1].

My intention is to post the parts for review on the xfs list on
a ~weekly basis and forward them to stable only after xfs developers
have had the chance to review the selection.

I used a gadget that I developed "b4 rn" that produces high level
"release notes" with references to the posted patch series and also
looks for mentions of fstest names in the discussions on lore.
I then used an elimination process to select the stable tree candidate
patches. The selection process is documented in the git log of [1].

After I had candidates, Luis has helped me to set up a kdevops testing
environment on a server that Samsung has contributed to the effort.
Luis and I have spent a considerable amount of time to establish the
expunge lists that produce stable baseline results for v5.10.y [2].
Eventually, we ran the auto group test over 100 times to sanitize the
baseline, on the following configurations:
reflink_normapbt (default), reflink, reflink_1024, nocrc, nocrc_512.

The patches in this part are from circa v5.11 release.
They have been through 36 auto group runs with the configs listed above
and no regressions from baseline were observed.

At least two of the fixes have regression tests in fstests that were used
to verify the fix. I also annotated [3] the fix commits in the tests.

I would like to thank Luis for his huge part in this still ongoing effort
and I would like to thank Samsung for contributing the hardware resources
to drive this effort.

Your inputs on the selection in this part and in upcoming parts [1]
are most welcome!

Thanks,
Amir.

[1] https://github.com/amir73il/b4/blob/xfs-5.10.y/xfs-5.10..5.17-fixes.rst
[2] https://github.com/linux-kdevops/kdevops/tree/master/workflows/fstests/expunges/5.10.105/xfs/unassigned
[3] https://lore.kernel.org/fstests/[e-mail]/
[4] https://lore.kernel.org/linux-xfs/Yo6ePjvpC7nhgek+@magnolia/
[5] https://lore.kernel.org/linux-xfs/[e-mail]/

Changes since v1:
- Send to stable
- Add patch from Christoph

Darrick J. Wong (3):
  xfs: detect overflows in bmbt records
  xfs: fix the forward progress assertion in xfs_iwalk_run_callbacks
  xfs: fix an ABBA deadlock in xfs_rename

Dave Chinner (1):
  xfs: Fix CIL throttle hang when CIL space used going backwards

Kaixu Xia (1):
  xfs: show the proper user quota options

 fs/xfs/libxfs/xfs_bmap.c    |  5 +++++
 fs/xfs/libxfs/xfs_dir2.h    |  2 --
 fs/xfs/libxfs/xfs_dir2_sf.c |  2 +-
 fs/xfs/xfs_buf_item.c       | 37 ++++++++++++++++----------------
 fs/xfs/xfs_inode.c          | 42 ++++++++++++++++++++++---------------
 fs/xfs/xfs_inode_item.c     | 14 +++++++++++++
 fs/xfs/xfs_iwalk.c          |  2 +-
 fs/xfs/xfs_log_cil.c        | 22 ++++++++++++++-----
 fs/xfs/xfs_super.c          | 10 +++++----
 9 files changed, 87 insertions(+), 49 deletions(-)

Comments

Greg KH June 3, 2022, 2:32 p.m. UTC | #1

On Fri, May 27, 2022 at 04:02:14PM +0300, Amir Goldstein wrote:
> Hi Greg and Shasha!
> 
> It has been a while since you heard from xfs team.
> 
> We are trying to change things and get xfs fixes flowing to stable
> again. Crossing my fingers that we will make this last this time :)
> 
> Please see this message from Darrick [4] about xfs stable plans.
> My team will be focusing on 5.10.y and Ted and Leah's team will be
> focusing on 5.15.y at this time.
> 
> This v2 is being sent to stable after testing and after v1 was sent
> for review of the xfs list [5].
> 
> v2 includes an extra patch that Christoph has backported and tested
> and was going to send to stable.
> 
> Please see my cover letter to xfs with more details about my plans
> for 5.10.y below:

All now queued up, thanks for doing this and I look forward to more xfs
patches being sent to us!

greg k-h