mbox series

[5.4,CANDIDATE,0/6] xfs stable candidate patches for 5.4.y (from v5.8)

Message ID 20221103115401.1810907-1-chandan.babu@oracle.com (mailing list archive)
Headers show
Series xfs stable candidate patches for 5.4.y (from v5.8) | expand

Message

Chandan Babu R Nov. 3, 2022, 11:53 a.m. UTC
Hi Darrick,

This 5.4.y backport series contains fixes from v5.8 release.

This patchset has been tested by executing fstests (via kdevops) using
the following XFS configurations,

1. No CRC (with 512 and 4k block size).
2. Reflink/Rmapbt (1k and 4k block size).
3. Reflink without Rmapbt.
4. External log device.

None of the fixes required any other dependent patches to be
backported.

Brian Foster (1):
  xfs: don't fail verifier on empty attr3 leaf block

Chuhong Yuan (1):
  xfs: Add the missed xfs_perag_put() for xfs_ifree_cluster()

Darrick J. Wong (2):
  xfs: use ordered buffers to initialize dquot buffers during quotacheck
  xfs: don't fail unwritten extent conversion on writeback due to edquot

Dave Chinner (1):
  xfs: gut error handling in xfs_trans_unreserve_and_mod_sb()

Eric Sandeen (1):
  xfs: group quota should return EDQUOT when prj quota enabled

 fs/xfs/libxfs/xfs_attr_leaf.c |   8 --
 fs/xfs/libxfs/xfs_defer.c     |  10 ++-
 fs/xfs/xfs_dquot.c            |  56 +++++++++---
 fs/xfs/xfs_inode.c            |   4 +-
 fs/xfs/xfs_iomap.c            |   2 +-
 fs/xfs/xfs_trans.c            | 163 +++++-----------------------------
 fs/xfs/xfs_trans_dquot.c      |   3 +-
 7 files changed, 78 insertions(+), 168 deletions(-)

Comments

Darrick J. Wong Nov. 3, 2022, 3:36 p.m. UTC | #1
On Thu, Nov 03, 2022 at 05:23:55PM +0530, Chandan Babu R wrote:
> Hi Darrick,
> 
> This 5.4.y backport series contains fixes from v5.8 release.
> 
> This patchset has been tested by executing fstests (via kdevops) using
> the following XFS configurations,
> 
> 1. No CRC (with 512 and 4k block size).
> 2. Reflink/Rmapbt (1k and 4k block size).
> 3. Reflink without Rmapbt.
> 4. External log device.
> 
> None of the fixes required any other dependent patches to be
> backported.

Patch 2 is missing quite a bit of commit message context.  Something
filtered out the shell screencap:

"# mkfs.xfs -f /dev/sda"

Probably because some smart tool thought it was eliding unnecessary
comments or something?

For the other 5 patches,
Acked-by: Darrick J. Wong <djwong@kernel.org>

--D

> 
> Brian Foster (1):
>   xfs: don't fail verifier on empty attr3 leaf block
> 
> Chuhong Yuan (1):
>   xfs: Add the missed xfs_perag_put() for xfs_ifree_cluster()
> 
> Darrick J. Wong (2):
>   xfs: use ordered buffers to initialize dquot buffers during quotacheck
>   xfs: don't fail unwritten extent conversion on writeback due to edquot
> 
> Dave Chinner (1):
>   xfs: gut error handling in xfs_trans_unreserve_and_mod_sb()
> 
> Eric Sandeen (1):
>   xfs: group quota should return EDQUOT when prj quota enabled
> 
>  fs/xfs/libxfs/xfs_attr_leaf.c |   8 --
>  fs/xfs/libxfs/xfs_defer.c     |  10 ++-
>  fs/xfs/xfs_dquot.c            |  56 +++++++++---
>  fs/xfs/xfs_inode.c            |   4 +-
>  fs/xfs/xfs_iomap.c            |   2 +-
>  fs/xfs/xfs_trans.c            | 163 +++++-----------------------------
>  fs/xfs/xfs_trans_dquot.c      |   3 +-
>  7 files changed, 78 insertions(+), 168 deletions(-)
> 
> -- 
> 2.35.1
>
Chandan Babu R Nov. 4, 2022, 5:21 a.m. UTC | #2
On Thu, Nov 03, 2022 at 08:36:02 AM -0700, Darrick J. Wong wrote:
> On Thu, Nov 03, 2022 at 05:23:55PM +0530, Chandan Babu R wrote:
>> Hi Darrick,
>> 
>> This 5.4.y backport series contains fixes from v5.8 release.
>> 
>> This patchset has been tested by executing fstests (via kdevops) using
>> the following XFS configurations,
>> 
>> 1. No CRC (with 512 and 4k block size).
>> 2. Reflink/Rmapbt (1k and 4k block size).
>> 3. Reflink without Rmapbt.
>> 4. External log device.
>> 
>> None of the fixes required any other dependent patches to be
>> backported.
>
> Patch 2 is missing quite a bit of commit message context.  Something
> filtered out the shell screencap:
>
> "# mkfs.xfs -f /dev/sda"
>
> Probably because some smart tool thought it was eliding unnecessary
> comments or something?

Sorry, I had not noticed that. I have sent a V2 of Patch 2 which fixes this
problem.

Git, by default, uses # as the comment character. I was able to overcome this
by adding the following to my ~/.gitconfig,

[core]
	commentChar = $

>
> For the other 5 patches,
> Acked-by: Darrick J. Wong <djwong@kernel.org>
>
> --D