mbox series

[5.15,CANDIDATE,00/11] 5.15.y sgid fixes

Message ID 20230302203504.2998773-1-leah.rumancik@gmail.com (mailing list archive)
Headers show
Series 5.15.y sgid fixes | expand

Message

Leah Rumancik March 2, 2023, 8:34 p.m. UTC 
Hello,

I finished testing the sgid fixes which Amir graciously backported to
5.15. This series fixes the previously failing generic/673 and
generic/68[3-7]. No regressions were seen in the 25 runs of the auto
group x 8 configs. I also did some extra runs on the perms group and
no regressions there either. The corresponding fixes are already in
6.1.y.

- Leah

Christian Brauner (5):
  attr: add in_group_or_capable()
  fs: move should_remove_suid()
  attr: add setattr_should_drop_sgid()
  attr: use consistent sgid stripping checks
  fs: use consistent setgid checks in is_sxid()

Darrick J. Wong (1):
  xfs: use setattr_copy to set vfs inode attributes

Dave Chinner (3):
  xfs: remove XFS_PREALLOC_SYNC
  xfs: fallocate() should call file_modified()
  xfs: set prealloc flag in xfs_alloc_file_space()

Yang Xu (2):
  fs: add mode_strip_sgid() helper
  fs: move S_ISGID stripping into the vfs_*() helpers

 Documentation/trace/ftrace.rst |  2 +-
 fs/attr.c                      | 72 +++++++++++++++++++++++++--
 fs/fuse/file.c                 |  2 +-
 fs/inode.c                     | 90 ++++++++++++++++++++--------------
 fs/internal.h                  | 10 +++-
 fs/namei.c                     | 82 ++++++++++++++++++++++++++-----
 fs/ocfs2/file.c                |  4 +-
 fs/ocfs2/namei.c               |  1 +
 fs/open.c                      |  8 +--
 fs/xfs/xfs_bmap_util.c         |  9 ++--
 fs/xfs/xfs_file.c              | 24 +++++----
 fs/xfs/xfs_iops.c              | 56 ++-------------------
 fs/xfs/xfs_pnfs.c              |  9 ++--
 include/linux/fs.h             |  6 ++-
 14 files changed, 235 insertions(+), 140 deletions(-)

Comments

Darrick J. Wong March 3, 2023, 4:51 p.m. UTC | #1 
On Thu, Mar 02, 2023 at 12:34:53PM -0800, Leah Rumancik wrote:
> Hello,
> 
> I finished testing the sgid fixes which Amir graciously backported to
> 5.15. This series fixes the previously failing generic/673 and
> generic/68[3-7]. No regressions were seen in the 25 runs of the auto
> group x 8 configs. I also did some extra runs on the perms group and
> no regressions there either. The corresponding fixes are already in
> 6.1.y.

If Christian is ok with backporting all the setgid changes to 5.15,

Acked-by: Darrick J. Wong <djwong@kernel.org>

--D

> 
> - Leah
> 
> Christian Brauner (5):
>   attr: add in_group_or_capable()
>   fs: move should_remove_suid()
>   attr: add setattr_should_drop_sgid()
>   attr: use consistent sgid stripping checks
>   fs: use consistent setgid checks in is_sxid()
> 
> Darrick J. Wong (1):
>   xfs: use setattr_copy to set vfs inode attributes
> 
> Dave Chinner (3):
>   xfs: remove XFS_PREALLOC_SYNC
>   xfs: fallocate() should call file_modified()
>   xfs: set prealloc flag in xfs_alloc_file_space()
> 
> Yang Xu (2):
>   fs: add mode_strip_sgid() helper
>   fs: move S_ISGID stripping into the vfs_*() helpers
> 
>  Documentation/trace/ftrace.rst |  2 +-
>  fs/attr.c                      | 72 +++++++++++++++++++++++++--
>  fs/fuse/file.c                 |  2 +-
>  fs/inode.c                     | 90 ++++++++++++++++++++--------------
>  fs/internal.h                  | 10 +++-
>  fs/namei.c                     | 82 ++++++++++++++++++++++++++-----
>  fs/ocfs2/file.c                |  4 +-
>  fs/ocfs2/namei.c               |  1 +
>  fs/open.c                      |  8 +--
>  fs/xfs/xfs_bmap_util.c         |  9 ++--
>  fs/xfs/xfs_file.c              | 24 +++++----
>  fs/xfs/xfs_iops.c              | 56 ++-------------------
>  fs/xfs/xfs_pnfs.c              |  9 ++--
>  include/linux/fs.h             |  6 ++-
>  14 files changed, 235 insertions(+), 140 deletions(-)
> 
> -- 
> 2.40.0.rc0.216.gc4246ad0f0-goog
>