mbox series

[5.10,CANDIDATE,00/15] xfs backports for 5.10.y (from v5.15.103)

Message ID 20230317110817.1226324-1-amir73il@gmail.com (mailing list archive)
Headers show
Series xfs backports for 5.10.y (from v5.15.103) | expand

Message

Amir Goldstein March 17, 2023, 11:08 a.m. UTC
Darrick,

Following backports catch up with recent 5.15.y backports.

Patches 1-3 are the backports from the previous 5.15 round
that Chandan requested for 5.4 [1].

Patches 4-14 are the SGID fixes that I collaborated with Leah [2].
Christian has reviewed the backports of his vfs patches to 5.10.

Patch 15 is a fix for a build warning caused by one of the SGID fixes.

This series has gone through the usual kdevops testing routine.

Thanks,
Amir.

[1] https://lore.kernel.org/linux-xfs/874jrtzlgp.fsf@debian-BULLSEYE-live-builder-AMD64/
[2] https://lore.kernel.org/linux-xfs/20230307185922.125907-1-leah.rumancik@gmail.com/

Amir Goldstein (4):
  attr: add in_group_or_capable()
  fs: move should_remove_suid()
  attr: add setattr_should_drop_sgid()
  attr: use consistent sgid stripping checks

Christian Brauner (1):
  fs: use consistent setgid checks in is_sxid()

Darrick J. Wong (3):
  xfs: purge dquots after inode walk fails during quotacheck
  xfs: don't leak btree cursor when insrec fails after a split
  xfs: use setattr_copy to set vfs inode attributes

Dave Chinner (4):
  xfs: don't assert fail on perag references on teardown
  xfs: remove XFS_PREALLOC_SYNC
  xfs: fallocate() should call file_modified()
  xfs: set prealloc flag in xfs_alloc_file_space()

Gaosheng Cui (1):
  xfs: remove xfs_setattr_time() declaration

Yang Xu (2):
  fs: add mode_strip_sgid() helper
  fs: move S_ISGID stripping into the vfs_*() helpers

 Documentation/trace/ftrace.rst |  2 +-
 fs/attr.c                      | 70 ++++++++++++++++++++++++++---
 fs/inode.c                     | 80 +++++++++++++++++++---------------
 fs/internal.h                  |  6 +++
 fs/namei.c                     | 80 ++++++++++++++++++++++++++++------
 fs/ocfs2/file.c                |  4 +-
 fs/ocfs2/namei.c               |  1 +
 fs/open.c                      |  6 +--
 fs/xfs/libxfs/xfs_btree.c      |  8 ++--
 fs/xfs/xfs_bmap_util.c         |  9 ++--
 fs/xfs/xfs_file.c              | 24 +++++-----
 fs/xfs/xfs_iops.c              | 56 ++----------------------
 fs/xfs/xfs_iops.h              |  1 -
 fs/xfs/xfs_mount.c             |  3 +-
 fs/xfs/xfs_pnfs.c              |  9 ++--
 fs/xfs/xfs_qm.c                |  9 +++-
 include/linux/fs.h             |  5 ++-
 17 files changed, 229 insertions(+), 144 deletions(-)

Comments

Darrick J. Wong March 17, 2023, 3:51 p.m. UTC | #1
On Fri, Mar 17, 2023 at 01:08:02PM +0200, Amir Goldstein wrote:
> Darrick,
> 
> Following backports catch up with recent 5.15.y backports.
> 
> Patches 1-3 are the backports from the previous 5.15 round
> that Chandan requested for 5.4 [1].
> 
> Patches 4-14 are the SGID fixes that I collaborated with Leah [2].
> Christian has reviewed the backports of his vfs patches to 5.10.
> 
> Patch 15 is a fix for a build warning caused by one of the SGID fixes.
> 
> This series has gone through the usual kdevops testing routine.
> 
> Thanks,
> Amir.

Looks good to me, with the same caveat I gave Leah wherein I'm assuming
Christian's ok with his setgid changes ending up in 5.10 too. :)

Acked-by: Darrick J. Wong <djwong@kernel.org>

--D

> 
> [1] https://lore.kernel.org/linux-xfs/874jrtzlgp.fsf@debian-BULLSEYE-live-builder-AMD64/
> [2] https://lore.kernel.org/linux-xfs/20230307185922.125907-1-leah.rumancik@gmail.com/
> 
> Amir Goldstein (4):
>   attr: add in_group_or_capable()
>   fs: move should_remove_suid()
>   attr: add setattr_should_drop_sgid()
>   attr: use consistent sgid stripping checks
> 
> Christian Brauner (1):
>   fs: use consistent setgid checks in is_sxid()
> 
> Darrick J. Wong (3):
>   xfs: purge dquots after inode walk fails during quotacheck
>   xfs: don't leak btree cursor when insrec fails after a split
>   xfs: use setattr_copy to set vfs inode attributes
> 
> Dave Chinner (4):
>   xfs: don't assert fail on perag references on teardown
>   xfs: remove XFS_PREALLOC_SYNC
>   xfs: fallocate() should call file_modified()
>   xfs: set prealloc flag in xfs_alloc_file_space()
> 
> Gaosheng Cui (1):
>   xfs: remove xfs_setattr_time() declaration
> 
> Yang Xu (2):
>   fs: add mode_strip_sgid() helper
>   fs: move S_ISGID stripping into the vfs_*() helpers
> 
>  Documentation/trace/ftrace.rst |  2 +-
>  fs/attr.c                      | 70 ++++++++++++++++++++++++++---
>  fs/inode.c                     | 80 +++++++++++++++++++---------------
>  fs/internal.h                  |  6 +++
>  fs/namei.c                     | 80 ++++++++++++++++++++++++++++------
>  fs/ocfs2/file.c                |  4 +-
>  fs/ocfs2/namei.c               |  1 +
>  fs/open.c                      |  6 +--
>  fs/xfs/libxfs/xfs_btree.c      |  8 ++--
>  fs/xfs/xfs_bmap_util.c         |  9 ++--
>  fs/xfs/xfs_file.c              | 24 +++++-----
>  fs/xfs/xfs_iops.c              | 56 ++----------------------
>  fs/xfs/xfs_iops.h              |  1 -
>  fs/xfs/xfs_mount.c             |  3 +-
>  fs/xfs/xfs_pnfs.c              |  9 ++--
>  fs/xfs/xfs_qm.c                |  9 +++-
>  include/linux/fs.h             |  5 ++-
>  17 files changed, 229 insertions(+), 144 deletions(-)
> 
> -- 
> 2.34.1
>
Christian Brauner March 17, 2023, 10:18 p.m. UTC | #2
On Fri, Mar 17, 2023 at 08:51:30AM -0700, Darrick J. Wong wrote:
> On Fri, Mar 17, 2023 at 01:08:02PM +0200, Amir Goldstein wrote:
> > Darrick,
> > 
> > Following backports catch up with recent 5.15.y backports.
> > 
> > Patches 1-3 are the backports from the previous 5.15 round
> > that Chandan requested for 5.4 [1].
> > 
> > Patches 4-14 are the SGID fixes that I collaborated with Leah [2].
> > Christian has reviewed the backports of his vfs patches to 5.10.
> > 
> > Patch 15 is a fix for a build warning caused by one of the SGID fixes.
> > 
> > This series has gone through the usual kdevops testing routine.
> > 
> > Thanks,
> > Amir.
> 
> Looks good to me, with the same caveat I gave Leah wherein I'm assuming
> Christian's ok with his setgid changes ending up in 5.10 too. :)

I think consistency between LTS kernels is good. Worst case we have to
revert the setgid changes. That'll be unpleasant but hopefully doable.

On the other hand, this could very well be me nodding happily along on
my way to the guillotine. :)