From patchwork Thu Apr 25 12:08:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 13643268 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9AD512B151 for ; Thu, 25 Apr 2024 12:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714046954; cv=fail; b=gb13vbgol8CUW9T6s3eOdlFgSTOlbzEI0rxhpBprtmhjWq1KYc2dwzQPQvrS7dVRG8tkeJO9LEgG194VIN4wTedoIHYSAmZtZazw2E4v8E+PFaIiYESR+aKGI5l3gcR8EIYb+dxmRRPSNDy9lEv1al4cMqBa2TDQQFItmPqSURg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714046954; c=relaxed/simple; bh=hdlnhJWpkcdwn+cJBvHWvn5beLViXC3ynVMMBgyXR5Q=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=UXNgP1wpVapqJaDknmxVhDDpueaKUK34t4Z9gLGPsJDPq462JbrkkZFLjZ8O9yxEpyxce3NbdlOoccr3Ju2UcodvKa41ZozFpmtV1bzOek0lly5pFJq2eZIM6NUKmkEfC9m1hxK38q6p1ppyOwkv5UGLltdRXbYvupWC18s8LNE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=EMMRO1Nc; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=gw6j1mXH; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="EMMRO1Nc"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="gw6j1mXH" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43P8wuH1019565; Thu, 25 Apr 2024 12:09:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=cRk4TIxAobsRRKXQxrHVnqcjaRJBujVJ3N15MzVkMaQ=; b=EMMRO1Ncjr5NBWXTYWgzY3UeCZm6D2LDCj/XFkRxeU27wOoZZWkNKvdvJVC6m5cS8bXB n6gMiIebFu2UGe6BkUzeFDqIGdc3X/I9le1pE+FETcy7YTcOb+qQLtidmSKty9aZLnri XcsoKkl1uEDUVlRFxCrF1JCUoEDCMjLLB9cyEcbLqNEQfYRbpWVrA/qPzUZMhtlYbXAW r62K1d0Wku/Lx2c67oAr+mtntDRzwdXTNwTrtRiFRqDX734ae3dDwDAxlAReSVGk9jT7 bMlSP5tKsEwWYpi6c9Hxer0k0g/C4a7F0hzYQyi28ugJm/NWgGLqvuviGpHno8hEf2PS cQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xm44f26k7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 12:09:01 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43PBGSf1006164; Thu, 25 Apr 2024 12:09:01 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2041.outbound.protection.outlook.com [104.47.73.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xm45a9v1q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 12:09:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdyxJJItuSQfFEKlSB60EuOMcOwZC8X2GSZbp5eFlbqBwWsfG/V9slqdokbZbBZ3v/uV6Kmv0S0TctIbThXjyM9obXGG6POBJnlyeFIa5Um7tOiJlAHY/mGcnGWOPdc098sbNLnL3NMJv7QaDuc14JqloILGrDwFeMZu4KP+OnRQOTEF68Cj+9Wy14QN2OXsMoLGTVVCeS6I/KbpqBaq8rFY/vuf9s0ZlBVJbFZEbCwcgzfUtx62sWRbbOoBMk/92lXsAQfdDZcuZGzkdXY8tyPB/k62GwtG24T7F3t2OfiPiPL4fxIUnAdNq1IMW60MFknJDuIFXLWhG5OLiUH22w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cRk4TIxAobsRRKXQxrHVnqcjaRJBujVJ3N15MzVkMaQ=; b=NyhPHD6jusOawO3C7bQ1A37k6IFzweLEZOV9lkcu8KkJH0+WWHuQoRbCwH/1Lkm1lXN9ztOgh85tkE4bSMgyK00M4+ivZlSSTDfSOh26vl9EEbvRAYr8PEgADcjOF0bu1V9+3m0kvmIuDBWptm5gRsH9SySRCdpcqh+CLbNei+f9ZHpxINdmtKwb2Pi3xGPuiT20TV1leFXpNY3FrmKvcOfkCHXw01i5AGObQw1wFZfahFPQ2LMnAzXAXzF5qbz9pBG4IOb+I+x36KRjtKMRlyTLh/ZsrtJwNMstwcTWB67BI/yMHvXNfH6Xgi0fzipQbYoP9BKVFOdV40Epr4dRFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cRk4TIxAobsRRKXQxrHVnqcjaRJBujVJ3N15MzVkMaQ=; b=gw6j1mXHqd3VL1w7FFBsERSCYZBDBTy8XEYnlQppzft2FDiMjgLc4Rp/x5GViuMa2R9B6UqG1L1gWWEfNN5ugn9Nf2aA7CTG4UxL5ONPhHRySSwQgyA0Epx2u9hibk17lDdd9MXRnfv4S5ESSsuoowZhlMvfFPKBueQs2NsMyPk= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by IA1PR10MB7197.namprd10.prod.outlook.com (2603:10b6:208:3f2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Thu, 25 Apr 2024 12:08:58 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%4]) with mapi id 15.20.7519.021; Thu, 25 Apr 2024 12:08:58 +0000 From: John Garry To: chandan.babu@oracle.com, djwong@kernel.org Cc: linux-xfs@vger.kernel.org, John Garry Subject: [PATCH 0/2] xfs: Clear a couple of W=1 warnings Date: Thu, 25 Apr 2024 12:08:44 +0000 Message-Id: <20240425120846.707829-1-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: MN2PR04CA0012.namprd04.prod.outlook.com (2603:10b6:208:d4::25) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|IA1PR10MB7197:EE_ X-MS-Office365-Filtering-Correlation-Id: 924d6abd-4c55-4f9f-53dd-08dc65207c53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?kX0nhtYsAlSsxuFYA2pV2VPclkm3CgF?= =?utf-8?q?ehsnAGQzz27crW7b/hZozrFjsyQENVtU/8nTJlnPnJghSi+N+pNA/Cv5CClW5Hrtr?= =?utf-8?q?vhoANTbAW7SZ4TDNPNAQt0tetICnhPOznrDcIGaQOVqHZz+G9JBG1SQg6stIslMSO?= =?utf-8?q?po8P4Y9UcI8TW9EedzvpBkK+c1LEginU7Gk7aW/JyFuuCMG9mcYAUopjAbOOFyLna?= =?utf-8?q?ouBZBwNBMQP2/BkbZFIPrHk9DVHqOodHWjMd2cIPK5iZwSx8RO60qglPj8+wamIxT?= =?utf-8?q?6K3zgMu74cqqTej3ghqt4qLeGt3RCRotuqgXYW35tajH+RsGGcE+45TNHUJTuNQOB?= =?utf-8?q?OIvE06BKcfukJTLd4kOySC+GE0Ox0yuCvCNdYNAkIwKWp3VTNXmftdWRGwl4H9MBA?= =?utf-8?q?G99e6JsS3TZlPsoAshsz6VgHibKNHd3vetHShgq1y3U2cgLhQ9t+VP7akquldnRTm?= =?utf-8?q?N9jlvHzzVHsLJqXTPi5dAMhnBdCNvJRq+vUnKIojXS3P9zvLx9qn9LCSHpJt+/+Hi?= =?utf-8?q?2NLWbMkQEk+9hiLZzB+cqmlMS2CmgxZsvllcW7aTyDG4FU6U86zwS5RCKiiF7KqUE?= =?utf-8?q?5ddsEy3ODx+6eYZ74Lum183PEoiGkBtYfKE/dLHDIX65X5PKOxTVtNSnGlA6hqVZH?= =?utf-8?q?YUV+mxnQcqJlyywFWn1EAY+f4QweoQScJH6DRhr3oEn4g/E3lsq4gd2Wr3eXNEsOQ?= =?utf-8?q?GWjG8xkpus8DT5DQn5pLpVOAn7Qw5M876Jg5jv71kCgkDXySN16Uv2cY1p9iK5zHt?= =?utf-8?q?LqHjLMzfu7L/yRZ1qx7LH1Q4+zCsm8XR3pieU1flv6rzDvcVc0qDdk4aUlkukHI5D?= =?utf-8?q?/fxlfFlvB0erL7jJg1r7V7nR7kuC/Ej527exGt7OOCFMD8/JKyIHg6Rvv8iLcPYDM?= =?utf-8?q?4VPDkjBu9pBYChurZzuYsEMDRibLoKbC28ucO9gGNFhgnrhMqiiYIUpqJB1mP4J1q?= =?utf-8?q?szc/XdWUkkgnVEUKKGXXeockvN8756umWeJYrsUdiYKrLlgxgK9syje+iNGcSUeMJ?= =?utf-8?q?wx2SVXlg3NCxizfwm1TyWydXVz0jWshd7kVfHTZ6+IZ3qWR8JUMxdnY4DLYhhWg8d?= =?utf-8?q?bt6WXMHWLyyNPpPnX6YSVVqLwz5WfEUp3JcORKtkM9ag3JPAUOYfKEhJZW7mlp5AJ?= =?utf-8?q?VOC1K9WArgIiFNtAQDYGTwx+ebLI7+40IVkQ9C7sSzdVPKXVg5WBBEKKQDUdDrEYJ?= =?utf-8?q?8jd5Nk55HL99CGtsT7+iG22rKJCwxkE8Z1uQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?s01uEHWWyp4WHgab6ySfRvlACrHi?= =?utf-8?q?9HLTG3+wsRWJ5DLYT8Aqar/hDEIrI+aP5QP7KbDMGPFz/nAkQUMYr+Ml8w5IjFIuC?= =?utf-8?q?5Ync1w+FEl1Aer8bu6DjNX3TPk8AN1GDS9eVO+QkwSYwzSx1t5HJNmOQbMJczoL1W?= =?utf-8?q?AvUwAAhMmVRzIEvT9dfRVnRuGjPg0ATAE80YhF7ryJc32i9YYUN6zdhZ/YIP1zZUN?= =?utf-8?q?8k2yWYyzcB2ctP7jOnxHYIG/9R6ckUa2i3klTl+Yts5DE5binI1IFi4SajgTjlJYK?= =?utf-8?q?Fg+psPKsxPlN+RgjOUci0nmzXLc6e+xWQluV7BCMX+Z5C3DoO1cEh1LS8bgdDFHwJ?= =?utf-8?q?fIw24+nODiE0pXCUdwcUTT6FTCa+X+cHsooAWqzm1bmsu4nIuem3dCdXl9znndV0k?= =?utf-8?q?oyC2PNFhgLgfbnHSGNU0WCSlAH0c8/ifX6GF3DY0cpurbbvXABamRzhHTNqXS98I/?= =?utf-8?q?3QAJ69UzvQLh9P4kVpj2lurTtAsk7Xy0YgRIEHhDeLhj570oCua1pyuQ3rUaq2sPA?= =?utf-8?q?9JV6eQLBZ7JmH2OTIzVG8s+J5YFXyvkKNJv2kJoIFi6nmlL7VpGCnoEss50Mr+Hl0?= =?utf-8?q?f9h+/dG2hToLWFrA4gVf1rLBmE8PILwXprb6jMSeJkHLU3IFsa6n0VNMCO2eH0ZJB?= =?utf-8?q?MPJ3WgM6db8C1EvcpCGTqrG0sFiXM8xJZQ4ZlJgdFvuc6HXmU2OlXKpmfKagc9UvS?= =?utf-8?q?uYWEakiIAO6o6DdWD1sSDeFUl/bqG6hLuU/pAkYX65kS0EODtwcEw9JrJYSA3ZUOD?= =?utf-8?q?err7/uWMfg5Sqg2cVNVJvsPqfqSh6xn5Tbkv7OrWVqce6W5pHJFuFStQjPNCTYYVN?= =?utf-8?q?HbUOWOmLmhb8cHhPECk+PFgMqc6a2uJeGwlG80WOX/zcLeGUcvAn9y9+NQI6w8fqR?= =?utf-8?q?CZGAVgRMyY3uwIirodtof9ps2Sa8mMUCQ1Zj2d06UTNigqkeLWL68sOAC5xbUpL09?= =?utf-8?q?Cc/4wqw48drm00rp4OfgaVHn+/axbOJ9gBkKxRsYLI+d+P8bvFch9Bi69qp9LVDl2?= =?utf-8?q?5zmhNFp9Fis/ZpLIQ4OQwuVhVu/SEo4i8Cn1FS1P/3plycqPIoj8eTt6coIanBj0T?= =?utf-8?q?CgJqR+hqAOqBLI6AhHo2DmkupWtnCIyTInfWvWlN9W+RwKolzJvN/PQjcyQ37pxw0?= =?utf-8?q?ZtU/1r/ekSbvUfs/GQeEq2AiLofmCHjDmPSwYLSWr+FfoEQEWlPY0aSFDm6s5O8pu?= =?utf-8?q?8OUIxmEMfsk6k957kqjOdW/uxIU/w3kQzXHCew0xfxLuuCt+DteFK3G1NeuL+zfhX?= =?utf-8?q?TD7RTqba7nEAZrIpFhu/Li1WWP89wcdor1NExCLYxUrQ4+btgbmlxJzOYEJmK3WmU?= =?utf-8?q?acgd8ulWpUfEGyevhQflZDk2vJPyaHgPQCRDg8fGtb0Vlw9JFhmdxYSHYARQhKeVb?= =?utf-8?q?gpqFvUkUyOcZR0QWSDaGutJoS9nU588c9mARVwVKNouopr+0Qzi4XF2sVIjzz70CJ?= =?utf-8?q?wPbWpXqUhje4F1z94CtlRj9J1e7BSbxIYlJhkdngErVm/ugJiUOzK0nbcCCYJZMG3?= =?utf-8?q?BWw51doqrpQMz/ZZY5f0gpbb0zGMuJTbTQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nBP016cQtDEYbkUKTug1Tt9YaJwMB8PkpOvxdgdGn5scXWdtsdPyVVz8uaS1IEZ53f+YQ2zOFwvHSfQ6OC0lfChMimvEhSRReYvxcsuTq4NJqjgf51TsusAE/UzGasvVLAngf3KAUE3TEXOXX9KFJu9/Cr1Xa9CnwNTp1ZOCcmYOjYdzlx1trlLaQhPdr5F6Sm32hBiAx+IJh/wSssssSunMu661t9ZDebI32/JxBFbmFQ/rPOUrd1BmeX/PATFc86wKj2MYYVC2sPym4mq8c46qsgmXfjHkO4OrQEHZmuCs/daVIUJ7FHJnFYwaQg8H7iL1fdnguKQnIQ9k4wmkvk8tu/pCoiSjDNt0y20OchjcO63XhATV1pT4IhbwIpt0X3XEadazC8nfC53UOG9Rsfd/16n7FQtPSqpcp1Ivc/8yjYxkLC/8JfOIkPOBvbN0k7jBYwJfW9Ryjaq+SK/F7b7OTRlC7lxywNEk3Irm3xsuzbaV0tkpkKwzDVAXSi/44mTv/b2crQhAeP5JSc73OnG09AbQlziSsltIJ04WNDJEeYHKk0lrMGBLbf8DdAZdyfPNZHguPRsu7eAs7fPDcr8rC7AGgfIYYXvSwXBQByk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 924d6abd-4c55-4f9f-53dd-08dc65207c53 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 12:08:58.0020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gu8Sm+HeX1jVxK4TwmTbIOaHRPWJHOudFjqA8KzOb+AzUjJuMtLucpZ+wkbYwbAuq8wOod8xX2vhRIw//gfg3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7197 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_12,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404250088 X-Proofpoint-ORIG-GUID: oKWgcqlbfHBRSpkhF5dxsRAizsaZ7LaF X-Proofpoint-GUID: oKWgcqlbfHBRSpkhF5dxsRAizsaZ7LaF For configs XFS_DEBUG and XFS_WARN disabled, there are a couple of W=1 warnings for unused variables. I have attempted to clear these here by simply marking the unused variables as __maybe_unused. I suppose that another solution would be to change the ASSERT() statement relevant to this config from: #define ASSERT(expr) ((void)0) to: #define ASSERT(expr) ((void)(expr)) Then the problem is that some local variables need to lose the #ifdef XFS_DEBUG guards, as those variables are now referenced in ASSERT(). This means that the objcode grows ever so slightly. I assume that this has all been considered previously... Based on v6.9-rc5 John Garry (2): xfs: Clear W=1 warning in xfs_iwalk_run_callbacks(): xfs: Clear W=1 warning in xfs_trans_unreserve_and_mod_sb(): fs/xfs/xfs_iwalk.c | 2 +- fs/xfs/xfs_trans.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)