mbox series

[0/6] iomap: some minor non-critical fixes and improvements when block size < folio size

Message ID 20240731091305.2896873-1-yi.zhang@huaweicloud.com (mailing list archive)
Headers show
Series iomap: some minor non-critical fixes and improvements when block size < folio size | expand

Message

Zhang Yi July 31, 2024, 9:12 a.m. UTC
From: Zhang Yi <yi.zhang@huawei.com>

This series contains some minor non-critical fixes and performance
improvements on the filesystem with block size < folio size.

The first 4 patches fix the handling of setting and clearing folio ifs
dirty bits when mark the folio dirty and when invalidat the folio.
Although none of these code mistakes caused a real problem now, it's
still deserve a fix to correct the behavior.

The second 2 patches drop the unnecessary state_lock in ifs when setting
and clearing dirty/uptodate bits in the buffered write path, it could
improve some (~10% on my machine) buffer write performance. I tested it
through UnixBench on my x86_64 (Xeon Gold 6151) and arm64 (Kunpeng-920)
virtual machine with 50GB ramdisk and xfs filesystem, the results shows
below.

UnixBench test cmd:
 ./Run -i 1 -c 1 fstime-w

Before:
x86    File Write 1024 bufsize 2000 maxblocks       524708.0 KBps
arm64  File Write 1024 bufsize 2000 maxblocks       801965.0 KBps

After:
x86    File Write 1024 bufsize 2000 maxblocks       571315.0 KBps
arm64  File Write 1024 bufsize 2000 maxblocks       876077.0 KBps

Thanks,
Yi.

Zhang Yi (6):
  iomap: correct the range of a partial dirty clear
  iomap: support invalidating partial folios
  iomap: advance the ifs allocation if we have more than one blocks per
    folio
  iomap: correct the dirty length in page mkwrite
  iomap: drop unnecessary state_lock when setting ifs uptodate bits
  iomap: drop unnecessary state_lock when changing ifs dirty bits

 fs/iomap/buffered-io.c | 55 ++++++++++++++++++++++++++----------------
 1 file changed, 34 insertions(+), 21 deletions(-)