mbox series

[v2,0/2] iomap: flush dirty cache over unwritten mappings on zero range

Message ID 20240828181912.41517-1-bfoster@redhat.com (mailing list archive)
Headers show
Series iomap: flush dirty cache over unwritten mappings on zero range | expand

Message

Brian Foster Aug. 28, 2024, 6:19 p.m. UTC 
Hi all,

Here's v2 of the iomap zero range flush fixes. No real changes here
other than a comment update to better explain a subtle corner case. The
latest version of corresponding test support is posted here [1].
Thoughts, reviews, flames appreciated.

Brian

[1] https://lore.kernel.org/fstests/20240828181534.41054-1-bfoster@redhat.com/

v2:
- Update comment in patch 2 to explain hole case.
v1: https://lore.kernel.org/linux-fsdevel/20240822145910.188974-1-bfoster@redhat.com/
- Alternative approach, flush instead of revalidate.
rfc: https://lore.kernel.org/linux-fsdevel/20240718130212.23905-1-bfoster@redhat.com/

Brian Foster (2):
  iomap: fix handling of dirty folios over unwritten extents
  iomap: make zero range flush conditional on unwritten mappings

 fs/iomap/buffered-io.c | 57 +++++++++++++++++++++++++++++++++++++++---
 fs/xfs/xfs_iops.c      | 10 --------
 2 files changed, 53 insertions(+), 14 deletions(-)

Comments

Josef Bacik Aug. 28, 2024, 8:44 p.m. UTC | #1 
On Wed, Aug 28, 2024 at 02:19:09PM -0400, Brian Foster wrote:
> Hi all,
> 
> Here's v2 of the iomap zero range flush fixes. No real changes here
> other than a comment update to better explain a subtle corner case. The
> latest version of corresponding test support is posted here [1].
> Thoughts, reviews, flames appreciated.
> 
> Brian
> 

Took me a second to grok what you were doing in the second patch, mostly because
I'm not as familiar with the iomap code, so with that caveat you can add

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef