| Message ID | 1484904118-17703-1-git-send-email-amir73il@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Oops.. Time to add tests that use syncfs :)
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 20, 2017 at 12:05 PM, Christoph Hellwig <hch@infradead.org> wrote: > Oops.. Time to add tests that use syncfs :) > Was just about to when I saw this surprise.. problem is. I only figured out an easy way to test using xfs stats: https://github.com/amir73il/overlayfs/blob/master/tests/xfs_syncfs.sh and I am wondering what would be a more generic way to test it. This test case fails to flush xfs log on syncfs from overlayfs over xfs, which is why I wrote it. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/configure.ac b/configure.ac index 3a4655f..1506b5e 100644 --- a/configure.ac +++ b/configure.ac @@ -135,6 +135,7 @@ AC_HAVE_FIEMAP AC_HAVE_PREADV AC_HAVE_COPY_FILE_RANGE AC_HAVE_SYNC_FILE_RANGE +AC_HAVE_SYNCFS AC_HAVE_MNTENT AC_HAVE_FLS AC_HAVE_READDIR diff --git a/include/builddefs.in b/include/builddefs.in index 612b547..ec1fe61 100644 --- a/include/builddefs.in +++ b/include/builddefs.in @@ -105,6 +105,7 @@ HAVE_FIEMAP = @have_fiemap@ HAVE_PREADV = @have_preadv@ HAVE_COPY_FILE_RANGE = @have_copy_file_range@ HAVE_SYNC_FILE_RANGE = @have_sync_file_range@ +HAVE_SYNCFS = @have_syncfs@ HAVE_READDIR = @have_readdir@ HAVE_MNTENT = @have_mntent@ HAVE_FLS = @have_fls@ diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4 index 7d5a42d..bc3b4ce 100644 --- a/m4/package_libcdev.m4 +++ b/m4/package_libcdev.m4 @@ -189,7 +189,7 @@ AC_DEFUN([AC_HAVE_SYNCFS], #include <unistd.h> ], [ syncfs(0); - ], have_sync_fs=yes + ], have_syncfs=yes AC_MSG_RESULT(yes), AC_MSG_RESULT(no)) AC_SUBST(have_syncfs)
Fixes commit c7dd81c7cd ("xfs_io: add sync and syncfs commands") Signed-off-by: Amir Goldstein <amir73il@gmail.com> --- configure.ac | 1 + include/builddefs.in | 1 + m4/package_libcdev.m4 | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-)