| Message ID | 1492355130.64829487.1610706535069.JavaMail.zimbra@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs: Fix assert failure in xfs_setattr_size() | expand |
On Fri, Jan 15, 2021 at 05:28:55AM -0500, Yumei Huang wrote: > An assert failure is triggered by syzkaller test due to > ATTR_KILL_PRIV is not cleared before xfs_setattr_size. > As ATTR_KILL_PRIV is not checked/used by xfs_setattr_size, > just remove it from the assert. > > Signed-off-by: Yumei Huang <yuhuang@redhat.com> > --- LGTM. Thanks for the patch. Reviewed-by: Brian Foster <bfoster@redhat.com> > fs/xfs/xfs_iops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 67c8dc9..f1e21b6 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -846,7 +846,7 @@ > ASSERT(xfs_isilocked(ip, XFS_MMAPLOCK_EXCL)); > ASSERT(S_ISREG(inode->i_mode)); > ASSERT((iattr->ia_valid & (ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| > - ATTR_MTIME_SET|ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0); > + ATTR_MTIME_SET|ATTR_TIMES_SET)) == 0); > > oldsize = inode->i_size; > newsize = iattr->ia_size; > -- > 1.8.3.1 >
On Fri, Jan 15, 2021 at 05:28:55AM -0500, Yumei Huang wrote: > An assert failure is triggered by syzkaller test due to > ATTR_KILL_PRIV is not cleared before xfs_setattr_size. > As ATTR_KILL_PRIV is not checked/used by xfs_setattr_size, > just remove it from the assert. > > Signed-off-by: Yumei Huang <yuhuang@redhat.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri, Jan 15, 2021 at 05:28:55AM -0500, Yumei Huang wrote: > An assert failure is triggered by syzkaller test due to > ATTR_KILL_PRIV is not cleared before xfs_setattr_size. > As ATTR_KILL_PRIV is not checked/used by xfs_setattr_size, > just remove it from the assert. > > Signed-off-by: Yumei Huang <yuhuang@redhat.com> Looks ok, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/xfs_iops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 67c8dc9..f1e21b6 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -846,7 +846,7 @@ > ASSERT(xfs_isilocked(ip, XFS_MMAPLOCK_EXCL)); > ASSERT(S_ISREG(inode->i_mode)); > ASSERT((iattr->ia_valid & (ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| > - ATTR_MTIME_SET|ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0); > + ATTR_MTIME_SET|ATTR_TIMES_SET)) == 0); > > oldsize = inode->i_size; > newsize = iattr->ia_size; > -- > 1.8.3.1 >
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 67c8dc9..f1e21b6 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -846,7 +846,7 @@ ASSERT(xfs_isilocked(ip, XFS_MMAPLOCK_EXCL)); ASSERT(S_ISREG(inode->i_mode)); ASSERT((iattr->ia_valid & (ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| - ATTR_MTIME_SET|ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0); + ATTR_MTIME_SET|ATTR_TIMES_SET)) == 0); oldsize = inode->i_size; newsize = iattr->ia_size;
An assert failure is triggered by syzkaller test due to ATTR_KILL_PRIV is not cleared before xfs_setattr_size. As ATTR_KILL_PRIV is not checked/used by xfs_setattr_size, just remove it from the assert. Signed-off-by: Yumei Huang <yuhuang@redhat.com> --- fs/xfs/xfs_iops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)