| Message ID | 150905612541.28563.17883126104053106652.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 10/26/17 5:15 PM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > The DAX flag should only be set for files and directories. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > repair/dinode.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Reviewed-by: Eric Sandeen <sandeen@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/repair/dinode.c b/repair/dinode.c index e7de6d4..e62ec33 100644 --- a/repair/dinode.c +++ b/repair/dinode.c @@ -2510,6 +2510,18 @@ _("bad (negative) size %" PRId64 " on inode %" PRIu64 "\n"), flags2 &= XFS_DIFLAG2_ANY; } + if (flags2 & XFS_DIFLAG2_DAX) { + /* must be a file or dir */ + if (di_mode && !(S_ISREG(di_mode) || S_ISDIR(di_mode))) { + if (!uncertain) { + do_warn( + _("DAX flag set on special inode %" PRIu64 "\n"), + lino); + } + flags2 &= ~XFS_DIFLAG2_DAX; + } + } + if ((flags2 & XFS_DIFLAG2_REFLINK) && !xfs_sb_version_hasreflink(&mp->m_sb)) { if (!uncertain) {