From patchwork Fri Feb 2 21:36:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10198139 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 66CAC603D7 for ; Fri, 2 Feb 2018 21:36:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5588F28C05 for ; Fri, 2 Feb 2018 21:36:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A49928F85; Fri, 2 Feb 2018 21:36:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E7EB228C05 for ; Fri, 2 Feb 2018 21:36:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbeBBVgo (ORCPT ); Fri, 2 Feb 2018 16:36:44 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:38158 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbeBBVgo (ORCPT ); Fri, 2 Feb 2018 16:36:44 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w12LVpS9114678; Fri, 2 Feb 2018 21:36:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=8TUtbHZLvuvjiRyvS2Iz96ioVTIEHWdOXvru20bjSw0=; b=a1xabMq7qVg5fQoHXSaRCgItnm9glrwuqcUcmGiKDO+sAmnG9WXBqvVpOqmUqrHoluKB 6k+mnWbp8ORg6ME4WPCNU+YeNsocQqp6mMVeSn9/2RiXFCoz8WdSH6+FhHUIdj2nhlT1 jHyWtrCAvB0/wLJoP/q/XSW6u335RD9KKHb7M4j0b9GQ2hAvV97tglPnsIUM1y3WGUcy mJRbAxa/956yLj98nRaHNPL4yrdoTQ6ijhAkW72eV+X0rgyhsT9mrF0KUW7g2k4HLZzs jghhkQ2VV9nQf2Z4HGF1LW4gcDFfT/R3MmhJ6/nXsqtWNEQjojrqRM3/ffeXmAO94+jZ Nw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2fvv5810bb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 02 Feb 2018 21:36:41 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w12Lae8k008021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 Feb 2018 21:36:41 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w12LaeBY015894; Fri, 2 Feb 2018 21:36:40 GMT Received: from localhost (/10.159.251.82) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 02 Feb 2018 13:36:40 -0800 Subject: [PATCH 3/4] xfs_scrub: kill dead code From: "Darrick J. Wong" To: sandeen@redhat.com, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Fri, 02 Feb 2018 13:36:39 -0800 Message-ID: <151760739949.29371.1187587453029792957.stgit@magnolia> In-Reply-To: <151760738102.29371.13542858379823064383.stgit@magnolia> References: <151760738102.29371.13542858379823064383.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8793 signatures=668661 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=902 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802020259 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong We can't reach the return mess at the bottom of __xfs_scrub_test so get rid of it. Fixes-coverity-id: 1428798 Signed-off-by: Darrick J. Wong Reviewed-by: Eric Sandeen --- scrub/scrub.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scrub/scrub.c b/scrub/scrub.c index 0dbe11c..6abca2a 100644 --- a/scrub/scrub.c +++ b/scrub/scrub.c @@ -602,7 +602,6 @@ _("Kernel %s %s facility not detected."), str_info(ctx, ctx->mntpoint, "%s", strerror(errno)); return true; } - return error == 0 || (error && errno != EOPNOTSUPP && errno != ENOTTY); } bool