diff mbox

[4/4] mkfs: enable sparse inodes by default

Message ID 152151532462.18312.14450864420601203976.stgit@magnolia (mailing list archive)
State Accepted
Headers show

Commit Message

Darrick J. Wong March 20, 2018, 3:08 a.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

Enable the sparse inode feature by default.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 mkfs/xfs_mkfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eric Sandeen March 20, 2018, 9:16 p.m. UTC | #1 
On 3/19/18 10:08 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Enable the sparse inode feature by default.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

OK - the cli_opt_set stuff feels clunky but I know it's just the pattern
right now...

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  mkfs/xfs_mkfs.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 1ca6a2d..78d0ce5 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -1996,7 +1996,7 @@ _("finobt not supported without CRC support\n"));
>  		}
>  		cli->sb_feat.finobt = false;
>  
> -		if (cli->sb_feat.spinodes) {
> +		if (cli->sb_feat.spinodes && cli_opt_set(&iopts, I_SPINODES)) {
>  			fprintf(stderr,
>  _("sparse inodes not supported without CRC support\n"));
>  			usage();
> @@ -3811,7 +3811,7 @@ main(
>  			.crcs_enabled = true,
>  			.dirftype = true,
>  			.finobt = true,
> -			.spinodes = false,
> +			.spinodes = true,
>  			.rmapbt = false,
>  			.reflink = false,
>  			.parent_pointers = false,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 1ca6a2d..78d0ce5 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1996,7 +1996,7 @@  _("finobt not supported without CRC support\n"));
 		}
 		cli->sb_feat.finobt = false;
 
-		if (cli->sb_feat.spinodes) {
+		if (cli->sb_feat.spinodes && cli_opt_set(&iopts, I_SPINODES)) {
 			fprintf(stderr,
 _("sparse inodes not supported without CRC support\n"));
 			usage();
@@ -3811,7 +3811,7 @@  main(
 			.crcs_enabled = true,
 			.dirftype = true,
 			.finobt = true,
-			.spinodes = false,
+			.spinodes = true,
 			.rmapbt = false,
 			.reflink = false,
 			.parent_pointers = false,